From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC1DAC46CD2 for ; Wed, 24 Jan 2024 17:24:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D4AD8D0005; Wed, 24 Jan 2024 12:24:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 45DBE8D0001; Wed, 24 Jan 2024 12:24:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 325608D0005; Wed, 24 Jan 2024 12:24:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1F7658D0001 for ; Wed, 24 Jan 2024 12:24:24 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E26ADC0D64 for ; Wed, 24 Jan 2024 17:24:23 +0000 (UTC) X-FDA: 81714878406.03.276A69C Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by imf13.hostedemail.com (Postfix) with ESMTP id 2F3212000D for ; Wed, 24 Jan 2024 17:24:21 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VCXoemMm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of glider@google.com designates 209.85.219.50 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706117062; a=rsa-sha256; cv=none; b=EI6GRNIEGkc21G4E2DAGCi2dLczdO6Gran7Fr20+oYkpcKUeBCZMSegFG+sNRcsvxArV8Q Fp2KF+Z4qOfPintc3YXSTnAuTH9pE8cQ3rtazMoqkHk5jLm+L3GfjmEA60kD9Ac8iYbnx/ myPo9nsfj9+1OihK8ERAq9YMfmwwzb4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VCXoemMm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of glider@google.com designates 209.85.219.50 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706117062; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cSxEs95VFilTX9ZMn4g3/pmadRUIIAuhSiude60Z10U=; b=8MTlRo/l4jpFSEGEaeN2h/Em6y413QCqJhVbTtyzHr1UWHGHldxYu9Tmz6phDHn0bLppO+ jvtrOBDNhXbMUAd9QR0gdr5jfs3Z5hJEzIoik6vt8L0uk/tLyqsHuOIiYFu9e/Hr7fT4Gl 0OHoD5s0YN+mmDeW60sJhg6++4pksfI= Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-68687ff4038so24343666d6.1 for ; Wed, 24 Jan 2024 09:24:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706117061; x=1706721861; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cSxEs95VFilTX9ZMn4g3/pmadRUIIAuhSiude60Z10U=; b=VCXoemMmqJZLDV6IMxsDdi04+rUwixb/cRp/na66Ful1MR6sZ/bdRniAL2RqBX3Khy KSaBfxqvMvIqW9mMo7d867e7I6jsgqjx80SghET7BvoWh0SSDlM+7MleMvDpV2M9XfOe 1DV1op6a0mOU6vGHeOksuNJZeguYnXvqsGGZjc9h4945SwtuvqyEAGOvIyUpuN7azP66 hfPz1r9q6ZZ+YyBWZdpgCPayS+34E8pL0LlxEBWgqHSvdoZxMzFLHSOQNpPE8SQF4nv4 IHd7re7yZczkzFkKS6kApCqLEC1ZxBKSIbRNmAEVmRXP3PJJrZ+lkn86SVFsaMhmFHEo SXNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706117061; x=1706721861; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cSxEs95VFilTX9ZMn4g3/pmadRUIIAuhSiude60Z10U=; b=ZYFhWg5T20PNHjmskNWnDVxC2g8HVM9OJjSxTlt5bA/EhllqjtjGiFZPM9IZxTC3x9 dFbyvwwJ4NzfgiY/QUUF+DU5W4GrijThOcZleClx/Bzmz+UqWJGX5c9b6bmYmWXZfC23 jV8FRS0NOPAJcYKp3urZVvxrKER5GWUUCUMnBcCUJ1Fy4uWNq/qXpVM3na6FNB/3DnEL 4uggddRApKcmEc+NxedpobkksYNkvjd85JnyXri0MS0Pongcnf4VNu7hhVOF+yqmuRzM fHJGpHHHfTyv738XvULsQ32cqeoVKM7vtsSBcj6xYWqargeJD9Ru1g8oIsGXrHp2b1ha CD8Q== X-Gm-Message-State: AOJu0Yxwu1T23GrdhWxMo+4aGZjeWxLBhBX+wT+mQ9Jd9bAJYzIIXjvJ /G0KptZ8/G6zPoMIu0jVCsXlGBf3ezyY5lXg6i+Y8wGqpWLSoKdA79WXWZplqi9eh08m+bMybnZ UIyYhHRkQmIR5FWtJpQrbFJBXdOFJWrnpvIqD X-Google-Smtp-Source: AGHT+IGs4EAnLTqOrRz2UwlDg86+/nnU0Jr0Lj71LPz8P67AViTwza3MbkbNm73GbgmjRdC92VlVcmx1Xz9qVLmuwJQ= X-Received: by 2002:ad4:5dc8:0:b0:685:55d:18b5 with SMTP id m8-20020ad45dc8000000b00685055d18b5mr3888783qvh.84.1706117061161; Wed, 24 Jan 2024 09:24:21 -0800 (PST) MIME-Version: 1.0 References: <20240124164211.1141742-1-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Wed, 24 Jan 2024 18:23:39 +0100 Message-ID: Subject: Re: [PATCH] mm: kmsan: remove runtime checks from kmsan_unpoison_memory() To: Marco Elver Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, Dmitry Vyukov , Ilya Leoshkevich , Nicholas Miehlbradt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2F3212000D X-Stat-Signature: rtbbeamae6hg8gq139gs4761mqn145ok X-HE-Tag: 1706117061-1138 X-HE-Meta: U2FsdGVkX1+SZE5EdRTttbSUEBsAes+zi+Sdq3E3pm1Z504WJlth+3nIXravsPgaBx95y1fSdY8Fzf5OXRhlUJ10kylWGzj0Mtp++kA0Yb8hKuA2t3FcyokI/kD0/Gm0S/Y7lNqf+N4Ndk0pvmxZtiwY5yb2VjPRVNH9F+obgQhJHvgwMnaiWO54O3xpvsQb14uYJDDrU3H2xhchmI7DfFSG8v3JZEID+yMV/PTgyIw16lcmJENfjYuMuGcPsa5sPeo9dNJIceAnQexAWBzGHhi9slPo3mcLeaanTqoYvEQtbHOYf0KnZFB4DteaQ6DJ5s2Wlkw1JrjnUCXAPV0F+Xbf+B+lkYlLkHz4KNz5d8m67wwvDTrZGyUlRoovhwPw26sALFN5eZ3MdzcRqkFb1czdYRt0ns1TiW+Yf0bY79EdeMvYsEDGk+M6+fY9/24hMLWK9bM2ZS/9iScsgeQnAFu3YXZJEnrLCoUp9yNUgut/C9LiPK/PH2mF+vGJQ+ztrxeNccgH++Hz5Yd3Bs5bVoA2iKnFcYK//HY/UUPJIQN0MPMnhXFne3snYd5XjAsCmtIG+J2AbhZK5To47/K8Q2f46DYzo/S77TKS8PudcYY2gDjq54/vUwfeEkNZVymw3794f3O3JkVdZIR8BGeChD3ikzghv3359omm2aVaDKGL7AwOKPlgo9veR5DnXNLuUWnFLSQS/m/Vcz+jcBEtOCgINkwDUuAPOrBB2JOIWJiS2JHYHj28YWd1RZwRaoGe80yNa/Q0TUGMEl2g3aKEHlzwo0H0D+D/bBv+QgSD8XKQOKWZdl6rK6qz78i7PxOniSfgOzxcA1dPCsW0j5ZjGZU8OBlCjnLzkZ/7G8Z7SWXSWVLTABL60rtIQ4fhqG9t30xvzhIvAVE8uZlbzwebVC0Vmb6RcaUOHor16LYVj+SN7AcjCSTtkDRuCd1+sbMHVPRCxGGJH+aX/1Wh2fA lWibbew/ VEFvD+XO3Qxo977dRxUe2cZYd8XkF9S/XTqj5dsnytYGhYwut4zuLqXUBo+HHy9batfq5KzccZuW845/fm7R/gpwZeDz4eL8TiH1plLzxq350Kemy384M/wYUGSZxZ154LepQNXIxNgzyqi9X89fjVOs3+gX2gPSDum+as96ohEUCoJhwChVYUIUfqPxxoEzMpddR20zuQxDLKzWYzJjkls4uHoc20WqhWFk7b6sow74bxDX8od/c1LaFZrqxQ96cEsOrO0UoELJL2O12au/7IhnOAGt/qjWpLyBb7VmZ21K4zzRrPzzlhk6Zv4+2CvkfVWwssmHlpcMmuXtzI7EoCoAZ+66bBrm9IqHMu1msDTs5/W0sCOOtaL/70Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.143886, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 24, 2024 at 6:15=E2=80=AFPM Marco Elver wrot= e: > > On Wed, 24 Jan 2024 at 17:42, 'Alexander Potapenko' via kasan-dev > wrote: > > > > Similarly to what's been done in commit ff444efbbb9be ("kmsan: allow > > using __msan_instrument_asm_store() inside runtime"), it should be safe > > to call kmsan_unpoison_memory() from within the runtime, as it does not > > allocate memory or take locks. Remove the redundant runtime checks. > > > > This should fix false positives seen with CONFIG_DEBUG_LIST=3Dy when > > the non-instrumented lib/stackdepot.c failed to unpoison the memory > > chunks later checked by the instrumented lib/list_debug.c > > > > Also replace the implementation of kmsan_unpoison_entry_regs() with > > a call to kmsan_unpoison_memory(). > > > > Signed-off-by: Alexander Potapenko > > Cc: Marco Elver > > Cc: Dmitry Vyukov > > Cc: Ilya Leoshkevich > > Cc: Nicholas Miehlbradt > > Tested-by: Marco Elver > > missing ')', probably: > > + kmsan_unpoison_memory((void *)regs, sizeof(*regs)); My bad - you are right. Thanks for catching!