From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A33EC54FD0 for ; Mon, 27 Apr 2020 14:02:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0B67D2064C for ; Mon, 27 Apr 2020 14:02:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Xqhzy3+/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B67D2064C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AB6448E0007; Mon, 27 Apr 2020 10:02:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8D278E0001; Mon, 27 Apr 2020 10:02:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 955CD8E0007; Mon, 27 Apr 2020 10:02:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7B49B8E0001 for ; Mon, 27 Apr 2020 10:02:42 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 45CD4181AEF07 for ; Mon, 27 Apr 2020 14:02:42 +0000 (UTC) X-FDA: 76753800564.13.lead90_178d1de6fc310 X-HE-Tag: lead90_178d1de6fc310 X-Filterd-Recvd-Size: 6097 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Mon, 27 Apr 2020 14:02:41 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id e26so19683057wmk.5 for ; Mon, 27 Apr 2020 07:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8GTXqRR4CReDMOtX0/kiLGCHi6hrqsKpKFM8LuQaKIY=; b=Xqhzy3+/71mXcOp5PGpHYMoNr+WdgofocVvJI8cRlNsiFhWGBOnCbyRhSn4QMVweAo 7OSdlzM1D/V42cb99V7KakZhuCqtkVtOODb0u8CaZvPRJ0X38SGoYFpOfMeFGBUdaw0/ C/FwnqD9hou5uovHQPhRt0GraAm4RJUZxOx43xXGq07+TbTgQX7LKuPyI5mPegbGZ9r/ fXTa17QAsL3z7d0zzS9oV9illZhNCKCka0QSvitrRDj/nOCW0D9iDLHh+IppknOzTqYY q7m+zD//2FSBBreW6o/s0RHzsRsdJn+NkVsjLE/OBkEP55fPKLzgC5gRq1YfncDwTQee XZTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8GTXqRR4CReDMOtX0/kiLGCHi6hrqsKpKFM8LuQaKIY=; b=aakTl/rA/dI4Ak3R7eJ1pX8erboGAxH8F/zsoCLR5tnQZtAoJGWy+rv/36LLSAVoL9 r81v+Ts/WqHhc+V1134cq/jpZF5xwxh05mCyz8/84YP9Bjxzt/G0CYF/RwVmukjloeKc u4nklT6u4aJ6Y8+rIIH4tiGMN+t9TuzQ3Ip6H8mVRLEyRA3/ovwSV/G71BjEFCQyw+Jl aT4S+1SDpiuJffCcgdejMwtjBzd1kKhgWWQ4GaDDftDc+ZIY7r3dYJ3eEUaamajJnem6 pb/Bony9TgAR4AQNEBcmFmF0nK79KdlpoFBDICnj8HoXFt1QIKFpf339qkYhVGdrR8qe YaUQ== X-Gm-Message-State: AGi0PuYJwXpf5jH8sR+ZhrjPc+1VQH2/w4NYF49lh3Q/7hYu4HxByKtZ hhZ7MOUZafQpKi8WmsGDFz871kC0i/Kr88F+RK6gtw== X-Google-Smtp-Source: APiQypKbe3t8WNtBASuNMiNUWkmkuUV2hdjWz/FOoTBYaccO/FL0P1ZB2xTAw0veCTShNp8UJnitOntRPUyi+jiQUXI= X-Received: by 2002:a1c:6787:: with SMTP id b129mr27590078wmc.165.1587996160350; Mon, 27 Apr 2020 07:02:40 -0700 (PDT) MIME-Version: 1.0 References: <20200325161249.55095-1-glider@google.com> <20200325161249.55095-23-glider@google.com> In-Reply-To: <20200325161249.55095-23-glider@google.com> From: Alexander Potapenko Date: Mon, 27 Apr 2020 16:02:29 +0200 Message-ID: Subject: Re: [PATCH v5 22/38] kmsan: net: check the value of skb before sending it to the network To: Andrew Morton , Greg Kroah-Hartman , Eric Dumazet , Wolfram Sang , Petr Mladek , Vegard Nossum , Dmitry Vyukov , Marco Elver , Andrey Konovalov , Linux Memory Management List Cc: Al Viro , Andreas Dilger , Andrey Ryabinin , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , Christoph Hellwig , "Darrick J. Wong" , David Miller , Dmitry Torokhov , Eric Biggers , Eric Van Hensbergen , Harry Wentland , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Jens Axboe , Marek Szyprowski , Mark Rutland , "Martin K . Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S. Tsirkin" , Michal Hocko , Michal Simek , Qian Cai , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 25, 2020 at 5:14 PM wrote: > > Calling kmsan_check_skb() lets KMSAN check the bytes to be transferred > over the network for being initialized. > > Signed-off-by: Alexander Potapenko > To: Alexander Potapenko > Cc: Andrew Morton > Cc: Greg Kroah-Hartman > Cc: Eric Dumazet > Cc: Wolfram Sang > Cc: Petr Mladek > Cc: Vegard Nossum > Cc: Dmitry Vyukov > Cc: Marco Elver > Cc: Andrey Konovalov > Cc: linux-mm@kvack.org > > --- > > This patch was previously called "kmsan: call KMSAN hooks where needed" > > v4: > - split this patch away > > Change-Id: Iff48409dc50341d59e355ce3ec11d4722f0799e2 > --- > net/sched/sch_generic.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c > index 2efd5b61acef1..4b2cc309bb1e3 100644 > --- a/net/sched/sch_generic.c > +++ b/net/sched/sch_generic.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -654,6 +655,7 @@ static struct sk_buff *pfifo_fast_dequeue(struct Qdisc *qdisc) > } else { > WRITE_ONCE(qdisc->empty, true); > } > + kmsan_check_skb(skb); I'm going to drop this patch from v6 to reduce its size. We haven't found any bugs using this check, so something is probably going wrong here.