From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23671C636CC for ; Tue, 7 Feb 2023 15:56:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A7BE6B00F5; Tue, 7 Feb 2023 10:56:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1577B6B00F6; Tue, 7 Feb 2023 10:56:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0473F6B00F8; Tue, 7 Feb 2023 10:56:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EAFB56B00F5 for ; Tue, 7 Feb 2023 10:56:54 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A7D40A072D for ; Tue, 7 Feb 2023 15:56:54 +0000 (UTC) X-FDA: 80440949148.21.98EE84D Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by imf13.hostedemail.com (Postfix) with ESMTP id DAAB120018 for ; Tue, 7 Feb 2023 15:56:51 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=JgfNzpS6; spf=pass (imf13.hostedemail.com: domain of glider@google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675785412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UmeU/kdhBO7XqGPtfKBv9yIOYYG4GxNWHmPeVymMlSk=; b=gRNVp0Lp+WxT3VKn2oYAJmFHlFt/sErIqdlQ8MzYBmQ7MlQ0BSEfaCg+fr/1bNWtDV5hLo 6PXHQA7YDO64iPuXc0/zy4QrUo4bgALRgGS4FJs26UI5+8S02NEvlUlLutXIwoQZ+iN9iQ kTjQ+dNtlGegjF+At3dMX32gDoym4l0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=JgfNzpS6; spf=pass (imf13.hostedemail.com: domain of glider@google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675785412; a=rsa-sha256; cv=none; b=gTjQGyAB05+nzec0utT9CvgyfrQMoUKd0yoLQ0HwDg3HmBybVK9eBrrkKqWPXAoDG2rb3r UHDLGlmZtUfAbYSk0P3ROUA+thauVQwd0uLSD8fvm0MqwGQnrLn51mZTIfofcNMK5nYT1m 1dxWuzxcIwOL1JxtqTfulYsYF+AIGQw= Received: by mail-wm1-f45.google.com with SMTP id n13so11357074wmr.4 for ; Tue, 07 Feb 2023 07:56:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UmeU/kdhBO7XqGPtfKBv9yIOYYG4GxNWHmPeVymMlSk=; b=JgfNzpS6vm4jI/ig86lSvi/UfIsFWVK5xgmTjDvoqEvAbEoM3ewslD0LAYvLsmxrjE 3ftjM8GtgYhkFoJlS8i+LHEgvK0BcqQEVCsyOr0THnI3k7B3wfvRBa/n0I4kXLvd8Dh1 HBLzZ24rFGB2SHw6rIhwicGUdNT5zaJLNz6HS9jMUGW/K4K9ek5euT21bIYlIitNytYB y/GwqJYenMEL1HINk9KJ9izVJQSqZbtInbPhKN0xaszILLdPjCBlbMziFbk6172IRCNp Rkc6PiIMxblNspJ+7GxRKBZdE2zYXBQ5Y9WymKYGQk0o8iB88CLvY6vDrBs/Ak9Tmjb2 Ww/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UmeU/kdhBO7XqGPtfKBv9yIOYYG4GxNWHmPeVymMlSk=; b=ZQAxAEZ+vhsaiRQRdqCg6sLBPwmOyXOyS+2X280kZ8quVVaY56rF0+rwBkErEJTCLU OAFY8nswd9FCr/iwPBJhGXXwxCFiatQwpMN+w+3pUIVyjmkC7IQnyZD1/7nZ+7XUmFL8 K2k+tCYW/i59q23tUIl6nV3eDTxRt617UbYExp14rxCLSVmHhbMkN3b2pWEd6nns82Pq zsUhY96JrsIjuKvD6GxO0/Ia0+h5W3jFURP3zO9S6rmD3SE42/1VUlFhztB7kodFlAkp ekZfKUPx2i/RHEncWG2TkrBtvRIek0PFLw3dCJjTmmDTsnZt4K5kmVrMBEwqWoEKWLId SF7Q== X-Gm-Message-State: AO0yUKXym6t+kEFgygE519kE/9lkB1zHF5unT11OKfUK7HMHJZdy37tI 3IomdJRXBsdyqMm3UQmH2Z1B/j8ZIqBzt+hr6acI+w== X-Google-Smtp-Source: AK7set8+u6tdWke4vMZvca0h8lft43X0EZk3tFEUk91XommWgzTy3aoiaR0kZJ/qKA4sGkMdyA/4oJzIzQnlLUwSbSY= X-Received: by 2002:a05:600c:354b:b0:3e0:c45:3456 with SMTP id i11-20020a05600c354b00b003e00c453456mr438239wmq.44.1675785410384; Tue, 07 Feb 2023 07:56:50 -0800 (PST) MIME-Version: 1.0 References: <5456286e2c9f3cd5abf25ad2e7e60dc997c71f66.1675111415.git.andreyknvl@google.com> In-Reply-To: From: Alexander Potapenko Date: Tue, 7 Feb 2023 16:56:13 +0100 Message-ID: Subject: Re: [PATCH 09/18] lib/stackdepot: rename hash table constants and variables To: Andrey Konovalov Cc: andrey.konovalov@linux.dev, Marco Elver , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: dyfnmkiix39zo4s993gi8kbfs8wnn9h1 X-Rspamd-Queue-Id: DAAB120018 X-HE-Tag: 1675785411-284057 X-HE-Meta: U2FsdGVkX1+Xx/CtmNMUSb8G903ftrbg054Ft8Kp7mKEaDLmuMwW5HyZSGlWzx7ejmRTu7g1yO6MIR46+ZQtZnflkxLFlxtnh3gp/DMsriw3/VLEcsHW2KjMxR7wENs4+jd+zgoD7rAV8nh4lwlRAPp+Y1sw3RVIhOBjAmkZmI+YQWQUvV+faSIwpe3A7u1kHJhMajevgPECMy4oGFyseBf2rqN1xpCmsev+SBLbNdKpjttmGYndpC2nlxTSbjBNl1C8cPMx8PeEDNyTczGpJIUAFA1j1OO5UwmlxDUjg3iS+206Hh+4RJMEUi8ZZeWVg/m6IeT769OFn1TObfGKEJzQ105S0XC2Eu/pXOIDGc4VjwiSx6GrtDq/c9TyuZTDQ60hQ9mkZYZsfx/mXJ3Gaxi7e2Ba1/ogf3GtaUzLKLimT+gL6+cH47zDuumT52/hmeU33tJ70hBTceqjmRYrauKIP5w31wrgc3K6iinhX7z4c1nFt2IibYoeiJKKDfQDFtX3T13sLBd4BlWN6QYnVNzlhlfg52b54ocqvH4XTl5Dj7//paZ2equuyC29gd7TYaLCw2XviWw+Mco4ZqGDTtjSt5EUVWlojXj4Ulf001pwjM8KLhs26agGZPc1+yBTCCPg5jsOsSm1ZpXKW649DQEVN7VP+hVYXW5oZUQT8eF8xyOnrzG89u9z8Umv50+CVfF0aX8KjScN23/vIhNPxRwgEaPCB8sUkSA8JiNSlz5Qm/Q0D2Lp5hemXUDV79/n+RHwiFNQ8FlPlGKS4HgGneLk5NBbWfZP3EL9o9HUmWQIr5TSeb/i/DEIu83R3EhTI0uYbtWZF1T+2HtqjFhE9fnp4y3bf2FUzZwW4pddkZjphQ9xMymPXfoz/dCL5fMQjPZxoMavZMmfP8E9sI1kZF75uk8SlvvywRoV8t724fBZoHkeFdDzVOquYpxo8FCW8EQB3gPJRsXPGMeVRXr lOb3iNSr dGUMdQN5UArBzrcXlmzXwP4vD5nw8lVN/zJHbPK4tDGqy38OZ6XK29CG4DDzH5+OnFz89yMz+EDyj7QD66J8zB0Cp6h9QJTehyfzBWEj+EHGW8mamy5CArpKqRrIihquupC8SG9Y4v/rpSBC8Dty8DscT2POfRGyHg1DWRZYB29tyQLkec9EsX4YZ2N890wnuTJrZ0il5E1+taFzr9Xzb6NxaEVG7u9vcmjhvAOcj+ICiVcxQATMbxmZvJGnaKwzZWaebw+5aL4k/PaEFPT9yQZbhezCphl+EHSTz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000330, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 31, 2023 at 8:02 PM Andrey Konovalov wrote: > > On Tue, Jan 31, 2023 at 12:34 PM Alexander Potapenko wrote: > > > > On Mon, Jan 30, 2023 at 9:50 PM wrote: > > > > > > From: Andrey Konovalov > > > > > > Give more meaningful names to hash table-related constants and variables: > > > > > > 1. Rename STACK_HASH_SCALE to STACK_TABLE_SCALE to point out that it is > > > related to scaling the hash table. > > > > It's only used twice, and in short lines, maybe make it > > STACK_HASH_TABLE_SCALE to point that out? :) > > Sure, sounds good :) > > > > 2. Rename STACK_HASH_ORDER_MIN/MAX to STACK_BUCKET_NUMBER_ORDER_MIN/MAX > > > to point out that it is related to the number of hash table buckets. > > > > How about DEPOT_BUCKET_... or STACKDEPOT_BUCKET_...? > > (just bikeshedding, I don't have any strong preference). > > This is what I had initially actually but then decided to keep the > prefix as STACK_ to match the stack_slabs and stack_table variables. Ok, let's keep your version then. Thanks!