From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D676C4332B for ; Fri, 15 Jan 2021 12:53:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F08F2221F7 for ; Fri, 15 Jan 2021 12:53:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F08F2221F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 91DA98D0163; Fri, 15 Jan 2021 07:53:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F4C48D0162; Fri, 15 Jan 2021 07:53:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8327C8D0163; Fri, 15 Jan 2021 07:53:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0100.hostedemail.com [216.40.44.100]) by kanga.kvack.org (Postfix) with ESMTP id 6D8188D0162 for ; Fri, 15 Jan 2021 07:53:32 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3547E3635 for ; Fri, 15 Jan 2021 12:53:32 +0000 (UTC) X-FDA: 77708000664.14.feast78_5f153232752f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 18B5D18229835 for ; Fri, 15 Jan 2021 12:53:32 +0000 (UTC) X-HE-Tag: feast78_5f153232752f X-Filterd-Recvd-Size: 4163 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Jan 2021 12:53:31 +0000 (UTC) Received: by mail-qt1-f172.google.com with SMTP id a6so5872686qtw.6 for ; Fri, 15 Jan 2021 04:53:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h9BqWIgWq/g/lc4wxnz/C2MSjqoIDnb6hVrxU6/5964=; b=fsxbLQTv4QHG2UcsckTqMjmrG03y3+pTx+WTSO8AeJJ+GASM54h8CQ3OeflsRyvuBa ODfEbZ5T0w/m5QxidfUTRdMzn+1sRznlV+k4bL0o4mv3QWA9b7Tiwhy0eDdt8Ts/b6AV uTProyUUXB6BZ1FLkR75KQ4R+kbcatGnuYLZkPsmuoHQq47jRf4QsUdVv02hWSO6rEC5 71prJRRhVbmWvZnOQLdHfbwbFZxXN+EB/6TFYmLx0T5kVyFREPTx6GTtEHXxJa/8shd+ 2n31E30fmPRLW4xt4dfuJA0krrhXcYEGUB5m8nUjM6+irdLOK0yAqttoSbBSWrRtZBFB Tu2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h9BqWIgWq/g/lc4wxnz/C2MSjqoIDnb6hVrxU6/5964=; b=poIZg3sYxcRvfcyqEaEmV0gfUjQDnQRY3vSSSWUPuqfyj38tjmHWGWymRZOUWkWift CHqv8fPUAeHncPvHQzVx0kktTVRcEv5Epf8b4OClRAnBUhhAvKZQdjnmmncFZyXYoupC Jd3Vu19wqC0QHP1VHfuT3Ffe3SY2CLPeJRRzXkuHmqlor0taibRsBZXph4xjVhEZYyYR o+sLND/T3G//7O6eFYInYnSIAUB3CRutG1M2+ymHZxb6mWuGGJwQ2jOukdpDrYfheZfI chCqRk+vtcgF70vTzB6O+9vJeNQ5CcKPq/eSxjO9Y5WVJyTcw5T2k/J7YhN5XlyqBrO4 4Iyg== X-Gm-Message-State: AOAM531t1Fjimbll8UfBDZzYEO6Z8rSOudF2l6KUBytAvhSoPYvSoOoT jUxo0P+B3d2cK7jjNDmigdaZMgbdP7+F4q1qeG+tYw== X-Google-Smtp-Source: ABdhPJyR26Dq7PRJCQR60dg/UhwPOr3JlA1eLMB/yfyYpZYY3e3g+nHZdP7UF5zVM70UIkbAmIhp62krHnUXfAkZYII= X-Received: by 2002:ac8:7111:: with SMTP id z17mr11638832qto.369.1610715210857; Fri, 15 Jan 2021 04:53:30 -0800 (PST) MIME-Version: 1.0 References: <20210113091657.1456216-1-glider@google.com> <20210113091657.1456216-2-glider@google.com> <20210113161044.43bc1c1a@gandalf.local.home> <20210114095232.7ba3f9a8@gandalf.local.home> In-Reply-To: <20210114095232.7ba3f9a8@gandalf.local.home> From: Alexander Potapenko Date: Fri, 15 Jan 2021 13:53:19 +0100 Message-ID: Subject: Re: [PATCH 1/4] tracing: add error_report trace points To: Steven Rostedt Cc: Andrew Morton , LKML , Marco Elver , Andrey Konovalov , Dmitry Vyukov , Ingo Molnar , Petr Mladek , Sergey Senozhatsky , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 14, 2021 at 3:52 PM Steven Rostedt wrote: > > On Thu, 14 Jan 2021 08:49:57 +0100 > Alexander Potapenko wrote: > > > We'll need to explicitly list the enum values once again in > > __print_symbolic(), right? E.g.: > > > > enum debugging_tool { > > TOOL_KFENCE, > > TOOL_KASAN, > > ... > > } > > > > TP_printk(__print_symbolic(__entry->error_detector, TOOL_KFENCE, > > TOOL_KASAN, ...), > > Usually what is done is to make this into a macro: > > #define REPORT_TOOL_LIST \ > EM(KFENCE, kfence) \ > EMe(KASAN, kasan) Thanks, will be done in v2! Note that checkpatch doesn't really like this declaration style, claiming that "Macros with complex values should be enclosed in parentheses". (although it is consistent with what's done in other trace event headers) > > #define EM(a,b) TRACE_DEFINE_ENUM(a) > #define EMe(a,b) TRACE_DEFINE_ENUM(a) These lines must end with a semicolon, according to other headers (and that becomes yet another thing that checkpatch barks at).