From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A547EC61DA4 for ; Thu, 9 Feb 2023 14:07:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 261546B0071; Thu, 9 Feb 2023 09:07:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 211046B0074; Thu, 9 Feb 2023 09:07:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D9C66B0075; Thu, 9 Feb 2023 09:07:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EC5536B0071 for ; Thu, 9 Feb 2023 09:07:36 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9DC718046D for ; Thu, 9 Feb 2023 14:07:36 +0000 (UTC) X-FDA: 80447931312.11.3929034 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf30.hostedemail.com (Postfix) with ESMTP id B6DFD80018 for ; Thu, 9 Feb 2023 14:07:34 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=jkPObI5+; spf=pass (imf30.hostedemail.com: domain of glider@google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675951654; a=rsa-sha256; cv=none; b=wylymNgLf5x32AT74sIICc64Gr6gLsnkoF4csET/Onj7rYGOg9r70ttvWjYA648obWa/NL FwQOV5f8CGmOdFO8tZLLqKMVSznD5Txa89Jd6n0fZrEvBmwHEJaoLzJ7Ofs+zIfoLqS0YH zroSbaa0YryfkPuejeCifFqkLdx0zP0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=jkPObI5+; spf=pass (imf30.hostedemail.com: domain of glider@google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675951654; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/fZEZ23GYCuEsYGekWai0lOlR8LMbc3z0Q5wLhY0DnY=; b=t23Nj7G++ivA+SlQjzr+WZpA46c2k6x3kEKAQCBosNOOILGV3hy/l/hex0pQmDDGwW1R5O 7EB823yoevkaInSvNHP+enzely+/HJvEgPjjDL6BJxS72PfLUoVDxYpkXSmz7PWwrFMuHe Picqy3f63HBKyUo2YdoQFnLP53UtbU0= Received: by mail-wm1-f52.google.com with SMTP id l37-20020a05600c1d2500b003dfe46a9801so1647710wms.0 for ; Thu, 09 Feb 2023 06:07:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/fZEZ23GYCuEsYGekWai0lOlR8LMbc3z0Q5wLhY0DnY=; b=jkPObI5+N3I6WTrzoz8PySJW2OXbWE7M/TaX5gSBNfdEe2PKbUmzKHInXXTxQuv3no G6azc3jC2HqqwU409T31LoBrUiJdzxK29obgs14LShAz/g2+oRv9KXAeXjl7H2Nkapam PtK3N5gHfgf5ef1xXbQHDPaxs2yIXHpOy3uZ3iCgRFb+BFbtvsLfdJcXNcgsxYojQTnX i6d/F75LAN0ifHAa5TO1Wt5PQmMbhjcFamqOZlPH9DqHiuIQO+UEfKFGCds6mbMeoKqk Q2UgdcwhVWHgUHBQZ8bt9nSNxSR5kq6ZoVF8x2rNiDsRulyteh+oWIOF7iQLd6e3vLPP PZDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/fZEZ23GYCuEsYGekWai0lOlR8LMbc3z0Q5wLhY0DnY=; b=0Rg4aHrZKxJ3O+M4KGb6kiNoAsUx64iXXGndLlbLYe4L1qjRz58SZN8JHLH3zFnOIN uTQiLdpEMKq60wiIZsqKzjDCMLTKkpOMhodkdEZojzFFcEF4YNtcI8Ly4Z1laDHRWi06 KU5luxPo0Z2QcqeNYXKAjBz9X3OSiZSN4lEDE8yA3YDntFkuvandq1f3WsrYKYvqAKnh RsdypKSgx1dFjJHU63n2tgOMLAPsqtsCyDHZWUBDFRJSONHr9Z+EE9GmRg+sXUWZbwAd jmBu6F/w6ug6GnYXyBOP9ZN9xCwK/k+MrpDnN4EhfB8aeoMUQdkdAMd5Lv7Ny4MvG6Qg m8GA== X-Gm-Message-State: AO0yUKX4uCJf+GMiWYcUfceT759G6Bn3J7FXbbPkZ3F00YPEKYleXSoE sGA9RD/kYci0p7fjYvjaKZ7omiM9l37FYf4lp74tGA== X-Google-Smtp-Source: AK7set/URjElet4XCI6w57NojAjes/SdyT2eO9gZZEVC0ptDvfP2FrrjoKMVkjbQZ58kwzqB57ZB/jquHBcfJDWNlz0= X-Received: by 2002:a05:600c:29ca:b0:3dd:67c6:8c58 with SMTP id s10-20020a05600c29ca00b003dd67c68c58mr701410wmd.51.1675951653421; Thu, 09 Feb 2023 06:07:33 -0800 (PST) MIME-Version: 1.0 References: <20230123220500.21077-1-kirill.shutemov@linux.intel.com> <20230123220500.21077-3-kirill.shutemov@linux.intel.com> In-Reply-To: <20230123220500.21077-3-kirill.shutemov@linux.intel.com> From: Alexander Potapenko Date: Thu, 9 Feb 2023 15:06:56 +0100 Message-ID: Subject: Re: [PATCHv15 02/17] x86: Allow atomic MM_CONTEXT flags setting To: "Kirill A. Shutemov" Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, Kostya Serebryany , Andrey Ryabinin , Andrey Konovalov , Taras Madan , Dmitry Vyukov , "H . J . Lu" , Andi Kleen , Rick Edgecombe , Bharata B Rao , Jacob Pan , Ashok Raj , Linus Torvalds , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: B6DFD80018 X-Rspamd-Server: rspam01 X-Stat-Signature: w67ex1cm8disyou6k38769aqma353o5i X-HE-Tag: 1675951654-910244 X-HE-Meta: U2FsdGVkX1+ZffZfTykNpnPIFnNwsV15kI6qPMDX4uSVgVafsFEnKDyJ8wMmny23y4K1pTFjo4OIY5ZZK2iyIGk3lOU0QVMbTIJ3KrtmtG9MBn/88f5h+MuOpUsGiObDjf7guINoMWXSGRJST7W2UQaiyWGeGPfnP+Uqg2qg7nV8cUxGUp2KRsom+TfTR+zoMVX/Yz++IYapV8OwTgM+WXgG8XUaIoATL8JPhm3NGY1RntmP26LX6klU8NjyKzQhhzYSv9lDouhtuBH3FeA2SRvmqgHZVl8KXQuPQXO0aAqTYmy5zHxXSLYNTvHlxCiBEEBJfBHGVC9P7o66g8I8rfxsyQafcvno+NpyEKAsBLiaCwUelnjM0IBldNZmnjcJrtX8y0N4KDtVuQph6YqVpuV5s7GM3g8PO33+CQcB6mDJTuwuWtN+wzkqAn3x0Q9wAcI0AgQyx5jckg6qg0x1R25/cLoByzf3oYAfjbrFMTTgivdaGSDXKQj2B9SeXFtu4eZohopcChrBsR2bsMmy4A+KqheRfllwflQJKZ4m/l/iH6mJY/eacKWSUaxkDIpKWul04GASlcvdJjXDg/jXPWHLDj76mQlMI13uqvrWPNEKvGrx37iJ4nn00BX+irKrzz3yWm66eIUcgT2S78RTbjuMvUbZ7mfwWcn57JCepC2PweAU0ESKQZNUgUsYVJ2RqBkPOIOHJuKlunOA/rIXh/JQR/LcPi9eZLHsTtP/IHsRG9FpwZG2Cyviwm+Zg9k4Rwu69jnPfpzJucGv5p4Z+kWRaTcBWrtrYqmANnKNhx0tbk51/+mO1yasBe2kbFo5H9RSTgY8BFEbSI8hL0QZmpf+JHn2NU9Ib6w1VJsxroiidgNcpsUL6CUCOAM3me6uqlHjrXdFb7B3Fr+ggKKohKxoXvBqguvHtd04nhSwwjgKMIRuiPRo4HwQBb9mpRuLRrhXFOa1pDy9qBglywp lk8Ga0tA NCYjsIeVfZArfkj64a9JfaXE6SNJvgobIHNOOefZF7vsQGvkRrNZuLf0ZYXgPbsY4/opBSTKOTFqHvRfvSfF5ZqpqKTuehrY7m1m+//OMdx2K5ITzhHow3a8iZNvD7pz2iXN2CoNkLWId0UzxYDn54XUPrFUFkM/5EZAM9KUQwxFhcd4K2LXQG3rh960XgeMk2VAlnlWxZZlpfWbbOtWjCAZ5U7ayb/rN8yUh5q6vZa3FthLQFZ4XsoU2R43whMwpa3Jt47wgn3E38/cVw/ck7pP4wLVWc4AremMP6d02ELCMvlfHpWMNpgHmK/T+LOQT3d52KrmWQ/dgftX9S5T2ek0cvbe9xWalcgm6kszxx1VWiPBlN+b+zhd62hiIc6i23eM45wvjRsp7yRD5WFtjkhl8u2GIbPRd/aMjISUzMZH6FlhxeU9Bv8H5f4S08+GqFInCNYCmvB1rKZebEjfJwXFVUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 23, 2023 at 11:05 PM Kirill A. Shutemov wrote: > > So far there's no need in atomic setting of MM context flags in > mm_context_t::flags. The flags set early in exec and never change > after that. > > LAM enabling requires atomic flag setting. The upcoming flag > MM_CONTEXT_FORCE_TAGGED_SVA can be set much later in the process > lifetime where multiple threads exist. > > Convert the field to unsigned long and do MM_CONTEXT_* accesses with > __set_bit() and test_bit(). > > No functional changes. > > Signed-off-by: Kirill A. Shutemov > Acked-by: Peter Zijlstra (Intel) Tested-by: Alexander Potapenko