From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE4DC433DB for ; Mon, 18 Jan 2021 10:22:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 30E922223E for ; Mon, 18 Jan 2021 10:22:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30E922223E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1F9BD6B0132; Mon, 18 Jan 2021 05:22:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 182E46B016A; Mon, 18 Jan 2021 05:22:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 071918D0001; Mon, 18 Jan 2021 05:22:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id CB5D26B0132 for ; Mon, 18 Jan 2021 05:22:40 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 870493628 for ; Mon, 18 Jan 2021 10:22:40 +0000 (UTC) X-FDA: 77718506880.22.camp66_4208d6627548 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 6A2DD18038E89 for ; Mon, 18 Jan 2021 10:22:40 +0000 (UTC) X-HE-Tag: camp66_4208d6627548 X-Filterd-Recvd-Size: 4630 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Mon, 18 Jan 2021 10:22:39 +0000 (UTC) Received: by mail-qv1-f51.google.com with SMTP id l7so7245458qvt.4 for ; Mon, 18 Jan 2021 02:22:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=E7b4WeOHgdYLNAFctjfJGeS6VNWY7pPBdbCgdjKDlQE=; b=BvQ146S7SGydtHihAba7WPhV8kde08dutF5V3Og4H1Hux8g8ukOdUgJM/tAB8hBYP5 j/xHzYxgB7yeAJnSrPpZqIxdnX5v6jUtW1XzN+rrz42qYHBJdxc8f3aockmd2VbKXfvX iWtvFTHG8Q/fG0zElt3X2vzC31DMxoOH4+mUyI6ZiEQI8QcAvIXkxiLM/Pfsf5TCyCHc JedNhQM7phW6U0lug3Sv0kgcymER/CsfhACysE+EicDU5O7ITc9cRGx0pVCsfLUs/8DS 0HrGko+Osm4qKpbcDUoiuGrsk6yCe2RcK/pTBUFi46G7r9D0GrjKwm5VUkDmTnfWo7+5 LNOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=E7b4WeOHgdYLNAFctjfJGeS6VNWY7pPBdbCgdjKDlQE=; b=QqhzstwN2+bJ7Pwc20fN9MD57hIexMLfRHyhPgyfYxDGKfF0TYfSRlwSaMrEMZ4QZV /1+5BV3KKyx0yM4XXLFJdcf8k+nL9Sose3fTmyV70x5Ks2omlBrWaz6g7kIIPAR4Y7TR ICg7MB4rKC6Fq4xQGHM2liatgM8ubvsmXSfVSoUcGEBZaq0fdWOPv2moW4GOLLbW/zMz MwTjoL6SgngLqNOTOvsjfCvdkK2wpZS6gsRkojFnUkKflCZXqJ+WQ3aiqm4/xrL0JOaL LGV8AxosRHfQ8ShHyKs+5L++ZQNjriKwfzgdL3HDtfgsZx/HQqzqX2SfzzdS+p3uB/1I UIiw== X-Gm-Message-State: AOAM530b+NHMxB7FNQgDfVEgPbUzFeDUHSrDfXF6GU8wumPgLJHG2chm 89YdbP4XFaEcUvRMwC+I7Bbf8dG3ABhGst7F4ZKP9w== X-Google-Smtp-Source: ABdhPJzP4uRKQpGNsBPbV5cTd6x4Rw3Er5hnqwT7R5LyA1UDx04O9mEoFfnYa6c84TKooghfAteR2xPpcxJCqHA1TiY= X-Received: by 2002:a0c:e90a:: with SMTP id a10mr23809113qvo.38.1610965359033; Mon, 18 Jan 2021 02:22:39 -0800 (PST) MIME-Version: 1.0 References: <20210115130336.2520663-1-glider@google.com> <20210115130336.2520663-4-glider@google.com> <20210115115239.1f3693ac@gandalf.local.home> In-Reply-To: <20210115115239.1f3693ac@gandalf.local.home> From: Alexander Potapenko Date: Mon, 18 Jan 2021 11:22:27 +0100 Message-ID: Subject: Re: [PATCH v2 3/5] docs: ABI: add /sys/kernel/error_report/ documentation To: Steven Rostedt Cc: Greg KH , LKML , Andrew Morton , Andrey Konovalov , Dmitriy Vyukov , Ingo Molnar , Marco Elver , Petr Mladek , Sergey Senozhatsky , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > If you do use tracefs, add it to the top level tracing directory (no need > to have instances of it), and rename it to "kernel_warnings", as > "error_report" is too close to the existing "error_log" which holds error > messages of syntactic errors done by users entering in commands to some o= f > the special files. Will do. Is it conventional to add a new dentry* to struct trace_array for = that? If not, maybe it's better to create this dir in error_report_notify_setup(), like this is done e.g. for /sys/kernel/tracing/trace_stat - just to loosen the coupling? > That is, /sys/kernel/tracing/kernel_warnings/ would be your error_report/ > directory you have now. WDYT about "kernel_errors" or "kernel_error_reports"? "warnings" suggest we'll be notifying about any occurrence of WARN(), which is not what we are planning to do. Also, shall I rename the library/config/etc. accordingly (to e.g. CONFIG_KERNEL_WARN_NOTIFY)? > Use the function in kernel/trace/trace.c: tracer_init_tracefs() to add th= at > directory. That's for files in the tracefs directory that will not be > duplicated by instances. > > -- Steve --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg