From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f71.google.com (mail-vk0-f71.google.com [209.85.213.71]) by kanga.kvack.org (Postfix) with ESMTP id 940D66B0273 for ; Tue, 13 Mar 2018 10:44:39 -0400 (EDT) Received: by mail-vk0-f71.google.com with SMTP id n23so8623843vke.14 for ; Tue, 13 Mar 2018 07:44:39 -0700 (PDT) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id k35sor139631uad.186.2018.03.13.07.44.38 for (Google Transport Security); Tue, 13 Mar 2018 07:44:38 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1943a345f4fb7e8e8f19b4ece2457bccd772f0dc.1520017438.git.andreyknvl@google.com> References: <1943a345f4fb7e8e8f19b4ece2457bccd772f0dc.1520017438.git.andreyknvl@google.com> From: Alexander Potapenko Date: Tue, 13 Mar 2018 15:44:35 +0100 Message-ID: Subject: Re: [RFC PATCH 14/14] khwasan: default the instrumentation mode to inline Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Andrey Konovalov Cc: Andrey Ryabinin , Dmitry Vyukov , Jonathan Corbet , Catalin Marinas , Will Deacon , Theodore Ts'o , Jan Kara , Christopher Li , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Masahiro Yamada , Michal Marek , Mark Rutland , Ard Biesheuvel , Yury Norov , Nick Desaulniers , Marc Zyngier , Bob Picco , Suzuki K Poulose , Kristina Martsenko , Punit Agrawal , Dave Martin , James Morse , Julien Thierry , Michael Weiser , Steve Capper , Ingo Molnar , Thomas Gleixner , Sandipan Das , Paul Lawrence , David Woodhouse , Kees Cook , Geert Uytterhoeven , Josh Poimboeuf , Arnd Bergmann , kasan-dev , linux-doc@vger.kernel.org, LKML , linux-arm-kernel@lists.infradead.org, linux-ext4@vger.kernel.org, linux-sparse@vger.kernel.org, Linux Memory Management List , Linux Kbuild mailing list , Kostya Serebryany , Evgeniy Stepanov , Lee Smith , Ramana Radhakrishnan , Jacob Bramley , Ruben Ayrapetyan , Kees Cook , Jann Horn , Mark Brand On Fri, Mar 2, 2018 at 8:44 PM, Andrey Konovalov wr= ote: > There are two reasons to use outline instrumentation: > 1. Outline instrumentation reduces the size of the kernel text, and shoul= d > be used where this size matters. > 2. Outline instrumentation is less invasive and can be used for debugging > for KASAN developers, when it's not clear whether some issue is caused > by KASAN or by something else. Don't you think this patch can be landed separately from the KHWASAN series= ? > For the rest cases inline instrumentation is preferrable, since it's > faster. > > This patch changes the default instrumentation mode to inline. > --- > lib/Kconfig.kasan | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > index ab34e7d7d3a7..8ea6ae26b4a3 100644 > --- a/lib/Kconfig.kasan > +++ b/lib/Kconfig.kasan > @@ -70,7 +70,7 @@ config KASAN_EXTRA > choice > prompt "Instrumentation type" > depends on KASAN > - default KASAN_OUTLINE > + default KASAN_INLINE > > config KASAN_OUTLINE > bool "Outline instrumentation" > -- > 2.16.2.395.g2e18187dfd-goog > Reviewed-by: Alexander Potapenko --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg