From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FD43CE79A8 for ; Tue, 19 Sep 2023 16:14:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E64B6B0072; Tue, 19 Sep 2023 12:14:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 796086B0078; Tue, 19 Sep 2023 12:14:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 684D56B0087; Tue, 19 Sep 2023 12:14:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 592A36B0072 for ; Tue, 19 Sep 2023 12:14:34 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1538440D6B for ; Tue, 19 Sep 2023 16:14:34 +0000 (UTC) X-FDA: 81253844868.09.07AAB5F Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by imf18.hostedemail.com (Postfix) with ESMTP id F152C1C003B for ; Tue, 19 Sep 2023 16:14:31 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=iXTFcWtZ; spf=pass (imf18.hostedemail.com: domain of glider@google.com designates 209.85.166.46 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695140072; a=rsa-sha256; cv=none; b=ISt8wdZK7bQAj2peR6XBsa+KBg/PTE97b7yWPzJmIsjS598z0naLq1NWP6gH1N3hbIkx5+ 1VI1L9eVGB2ufl6AwISF6K0zI/8C4Mb9UtzhKkVQSg9OjMQtacW4kwc0CAEv3nUTdEV/vJ B4XXdszTVzpPziSaBQ1ol/uPCLY3X7U= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=iXTFcWtZ; spf=pass (imf18.hostedemail.com: domain of glider@google.com designates 209.85.166.46 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695140072; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wCIcJHAWFPOLBSbECabbg7duQStJvSvwou+mFA2mS48=; b=eZQXMtE7jyYbnCG/0dy6UuNU2cyco8r/HGnt6FJguNTHGGhCzwgbd32g0kfyfZS83R/SVz Jh1p49zw9o6Lscxecx9mwjDgKpOSzrY3wQd21MeOLE+cFxCuU/ePKuPwCkk1OwBse7Gof+ Ve5dZsrCVlS3DxCM2i62ZkXDkMXDWgo= Received: by mail-io1-f46.google.com with SMTP id ca18e2360f4ac-792717ef3c9so202296339f.3 for ; Tue, 19 Sep 2023 09:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695140071; x=1695744871; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wCIcJHAWFPOLBSbECabbg7duQStJvSvwou+mFA2mS48=; b=iXTFcWtZgBCK1VXC4RiFJMR3y5U+DosQ6peVk93nQV7fajjzTlu7xzsrwN2JQt0PiA sgvPgQuOGT++Z+AhduY3aER30sswfQMywnxx7cZEF8V5bW7G7u/5+R8nRlsFawSmJ3qP afguh2eB38JZEb4W1V1yzaS+dEy149Gag+Q/lH1YkPun+rGn282FZP80yuPOpdR40eMb IJxLakjr2vKuxow6TMjbBaKPXirnv1Y0eHXp+l9NjERPa/QGI5imvhjPjGebv2GxPTZY 4WmQ9amR23Nlqvpjwrs0NL/+Njeyphmob7LB9PYakCX9YlF9O5C2YqAvgWXS1spaYSx3 7SIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695140071; x=1695744871; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wCIcJHAWFPOLBSbECabbg7duQStJvSvwou+mFA2mS48=; b=t36r7ytPDJbrit3J3o1V0RLEX8qYmQSTTQr6ez1DDl6yypSWRU/xEya2oNfcuNcV56 ACnugfVRhYvZMbx8AeGF6OuYwvbynToBYvtPDYqm95CGU3kd+F1B1CBNZJWouxdcWm8D F9vFsBEAoeuddy9B5Ng3pOMyGarYLDzTUxUSnrlsk0iwElpyvWX5myV8obh6Hvjmy3OH whvHy/3leMi3S2LV0/uZMkoHE+HYQt0Akas5lf56eIv1z9TsEj6IVhrjfa6hikgyXt5M lIsWORPXWsIilSpvXBTbR5WghYaTQCX88bc0FMR+9KITjS1drufb69DmkQB5N4qNeMED 1bTQ== X-Gm-Message-State: AOJu0Yxx6dbIOyo6zE1yoc9rt46NZ+6jjjE3HDSreTsEqHip9zxoPrLr 86x7U1jl0bN8MWkKsjhfO5fl9KUJ+Nc9Oat96MpXNQ== X-Google-Smtp-Source: AGHT+IEzONpw2FaQZlL1wFbHl70DzyH8HlyBf+hDgw7+37EwZ4nnPMOsFqoEIUIPb1qQYUGfgkcn+sRpTBlQRy3ib10= X-Received: by 2002:a6b:7111:0:b0:790:f866:d717 with SMTP id q17-20020a6b7111000000b00790f866d717mr323374iog.10.1695140071037; Tue, 19 Sep 2023 09:14:31 -0700 (PDT) MIME-Version: 1.0 References: <3a7056408e391ff0c66b5f50c460a7b9f796228f.1694625260.git.andreyknvl@google.com> In-Reply-To: <3a7056408e391ff0c66b5f50c460a7b9f796228f.1694625260.git.andreyknvl@google.com> From: Alexander Potapenko Date: Tue, 19 Sep 2023 18:13:51 +0200 Message-ID: Subject: Re: [PATCH v2 09/19] lib/stackdepot: store next pool pointer in new_pool To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: F152C1C003B X-Stat-Signature: khc7kgfsypguy9qjrxjo4yri5xymuisg X-Rspam-User: X-HE-Tag: 1695140071-176477 X-HE-Meta: U2FsdGVkX18KFm8R21lJOdUAURvnq0qsDmL88/HNjRtbT8SdTp0OYbbOP4JgK4g4wjSYj0Yh1iwECrgSpmK47MaH9Ur18EHY3JArxkaGWB15bet/hwyoAahxEH1OewZRrB0fYJ2s5N3wl0muhjQVTU5s7hFganbHvK6OH3vVkyAjeWShOfqGIsz8t6/6ChtrLG/6oT+FG4Cc/8BOxe2VLCzc74nrDL7FMC7w2/1TCd/rtWsi+Kk0VMMa9mN+FyvRBq9neQopjYZtp4xS9q5Bxpeyps0TUvJ4d8KThIaFqagneZAECTifL6nLi9EAhLZsPQ1xjuCTvtAnbY/QhEeO3UDlritzmQHTr53lO0RUEH3+ikMcI83PCzzVPvclXcFvGBbpVbU8sJxu233amEOCW1ODmFmnvxQBTArR6KcRZPTJ6CUoysmrvnHokwO4thJSkGJ03Y8BeVLCxL/kWVNkVGT0wFGfjzlcudEqzMJFp0VMfYIgR/g7GsvU3VWibZjgjYxqPjOtBG0Lhkdxn3M3mTpP8dMdKYuMLKpyhj94Wm4zXY7snKdo5t15SDK/lLv0GlTMzVIDoVPDfl58ZXgE2Gm1Aw8FkKAvSdUpUiEW1d0mgfVBcyXowddD8iMlgxhDDVDjBKtjJpg9EX81bVZfg4geRujiAnAGB64XHEWtMKXyalzqxADBMG/uorvM+H81cYfVbQnaRA/76uVFP2tQ3+OtEOXUJzQMe+2B6gCjjJWoVqkIlaBnWflDu+Wxtt2r+R/L4UNG3csWgByOeDSHU6VK6s5cZK8Ux+u3F5Hd22lZ0n44OM1tjlAxZN+5lHoxlyuEH8NH8iYbsPGMRo29b8X0nAeMja5lB+3X4qKiBkdieVrqmmMBeVT99tQqqUu1B0iwU8Tdf+egB5F1udQ2IHNb2ZON52zwcHbNmXiQqq1C9ueI56EWRdF8wBl/Jtlvl6zKsz6bQk42pOPJ7qA 9UBUZMzI 6XuXWR0Uhcn+wiWXLUFUAfVyuIfSf3VhlarPy0BZRuRw3NlpQtMtwBMclPczNXu7BGvEuHLcFE/0AJ6Xxo2idvP4ANYvSLWDQ3QT45khWJt5ABz9D8hiv0cgHdVC3H+/dK+xhsQ2UP8D3vu9QRXRKswZxG3WcAasI5tFPGR2TzUqWBgIE0SlgIWWS3HP0p2xX65T5G+okAdKKH/peT724RLr3j+uZSdStBHkWqHok7H8Z4XhXEf+vL5KLv/Z6lech8wpmcqjBIVayCHHdG6zWcifvL6CJHTZ6csWAS5F35XIM9U3AodGb//7aAYxA3j7zqr4udEED6eOEYo4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000019, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 13, 2023 at 7:15=E2=80=AFPM wrote: > > From: Andrey Konovalov > > Instead of using the last pointer in stack_pools for storing the pointer > to a new pool (which does not yet store any stack records), use a new > new_pool variable. > > This a purely code readability change: it seems more logical to store > the pointer to a pool with a special meaning in a dedicated variable. > > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko