linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] kmsan: export kmsan_handle_urb
@ 2022-12-15 16:26 Arnd Bergmann
  2022-12-15 16:38 ` Alexander Potapenko
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2022-12-15 16:26 UTC (permalink / raw)
  To: Alexander Potapenko, Andrew Morton
  Cc: Arnd Bergmann, Marco Elver, Dmitry Vyukov, kasan-dev, linux-mm,
	linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

USB support can be in a loadable module, and this causes a link
failure with KMSAN:

ERROR: modpost: "kmsan_handle_urb" [drivers/usb/core/usbcore.ko] undefined!

Export the symbol so it can be used by this module.

Fixes: 553a80188a5d ("kmsan: handle memory sent to/from USB")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 mm/kmsan/hooks.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/kmsan/hooks.c b/mm/kmsan/hooks.c
index 35f6b6e6a908..3807502766a3 100644
--- a/mm/kmsan/hooks.c
+++ b/mm/kmsan/hooks.c
@@ -260,6 +260,7 @@ void kmsan_handle_urb(const struct urb *urb, bool is_out)
 					       urb->transfer_buffer_length,
 					       /*checked*/ false);
 }
+EXPORT_SYMBOL_GPL(kmsan_handle_urb);
 
 static void kmsan_handle_dma_page(const void *addr, size_t size,
 				  enum dma_data_direction dir)
-- 
2.35.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] kmsan: export kmsan_handle_urb
  2022-12-15 16:26 [PATCH] kmsan: export kmsan_handle_urb Arnd Bergmann
@ 2022-12-15 16:38 ` Alexander Potapenko
  0 siblings, 0 replies; 2+ messages in thread
From: Alexander Potapenko @ 2022-12-15 16:38 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Andrew Morton, Arnd Bergmann, Marco Elver, Dmitry Vyukov,
	kasan-dev, linux-mm, linux-kernel

On Thu, Dec 15, 2022 at 5:27 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> USB support can be in a loadable module, and this causes a link
> failure with KMSAN:
>
> ERROR: modpost: "kmsan_handle_urb" [drivers/usb/core/usbcore.ko] undefined!
>
> Export the symbol so it can be used by this module.
>
> Fixes: 553a80188a5d ("kmsan: handle memory sent to/from USB")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Alexander Potapenko <glider@google.com>

> ---
>  mm/kmsan/hooks.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/mm/kmsan/hooks.c b/mm/kmsan/hooks.c
> index 35f6b6e6a908..3807502766a3 100644
> --- a/mm/kmsan/hooks.c
> +++ b/mm/kmsan/hooks.c
> @@ -260,6 +260,7 @@ void kmsan_handle_urb(const struct urb *urb, bool is_out)
>                                                urb->transfer_buffer_length,
>                                                /*checked*/ false);
>  }
> +EXPORT_SYMBOL_GPL(kmsan_handle_urb);
>
>  static void kmsan_handle_dma_page(const void *addr, size_t size,
>                                   enum dma_data_direction dir)
> --
> 2.35.1
>


-- 
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Straße, 33
80636 München

Geschäftsführer: Paul Manicle, Liana Sebastian
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-12-15 16:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-15 16:26 [PATCH] kmsan: export kmsan_handle_urb Arnd Bergmann
2022-12-15 16:38 ` Alexander Potapenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox