From: Alexander Potapenko <glider@google.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>, Marco Elver <elver@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
kasan-dev@googlegroups.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kmsan: export kmsan_handle_urb
Date: Thu, 15 Dec 2022 17:38:43 +0100 [thread overview]
Message-ID: <CAG_fn=UcY0qE8OXRui1-du3TnMA06TZh0ANpDj9pqoUT4aqknQ@mail.gmail.com> (raw)
In-Reply-To: <20221215162710.3802378-1-arnd@kernel.org>
On Thu, Dec 15, 2022 at 5:27 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> USB support can be in a loadable module, and this causes a link
> failure with KMSAN:
>
> ERROR: modpost: "kmsan_handle_urb" [drivers/usb/core/usbcore.ko] undefined!
>
> Export the symbol so it can be used by this module.
>
> Fixes: 553a80188a5d ("kmsan: handle memory sent to/from USB")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Alexander Potapenko <glider@google.com>
> ---
> mm/kmsan/hooks.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/kmsan/hooks.c b/mm/kmsan/hooks.c
> index 35f6b6e6a908..3807502766a3 100644
> --- a/mm/kmsan/hooks.c
> +++ b/mm/kmsan/hooks.c
> @@ -260,6 +260,7 @@ void kmsan_handle_urb(const struct urb *urb, bool is_out)
> urb->transfer_buffer_length,
> /*checked*/ false);
> }
> +EXPORT_SYMBOL_GPL(kmsan_handle_urb);
>
> static void kmsan_handle_dma_page(const void *addr, size_t size,
> enum dma_data_direction dir)
> --
> 2.35.1
>
--
Alexander Potapenko
Software Engineer
Google Germany GmbH
Erika-Mann-Straße, 33
80636 München
Geschäftsführer: Paul Manicle, Liana Sebastian
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
prev parent reply other threads:[~2022-12-15 16:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 16:26 Arnd Bergmann
2022-12-15 16:38 ` Alexander Potapenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG_fn=UcY0qE8OXRui1-du3TnMA06TZh0ANpDj9pqoUT4aqknQ@mail.gmail.com' \
--to=glider@google.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox