From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2205C2D0C6 for ; Wed, 11 Dec 2019 14:23:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4D55A22B48 for ; Wed, 11 Dec 2019 14:23:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XrSTp2VO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D55A22B48 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AB7646B325A; Wed, 11 Dec 2019 09:23:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A67316B325B; Wed, 11 Dec 2019 09:23:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97E566B325C; Wed, 11 Dec 2019 09:23:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0206.hostedemail.com [216.40.44.206]) by kanga.kvack.org (Postfix) with ESMTP id 84F6D6B325A for ; Wed, 11 Dec 2019 09:23:13 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id F245A181AEF1A for ; Wed, 11 Dec 2019 14:23:12 +0000 (UTC) X-FDA: 76253077824.24.hate83_1bfee8fc15937 X-HE-Tag: hate83_1bfee8fc15937 X-Filterd-Recvd-Size: 4853 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Dec 2019 14:23:12 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id d16so24205638wre.10 for ; Wed, 11 Dec 2019 06:23:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5k+S5N42RlL6ZM1liWYYGXflOc03n3hOzRNJw8Um+Uk=; b=XrSTp2VOjOl+M9XmvqfyCLcTUAmcqREaJbXttAQYyCZZF0zcIPWnZDMHtrgHDPiHn/ nfiTvsCQ9BvIKOGABm/XUaUbDfvlobAHjG/0Okaf2ovXRnjIhdj3Rp3h9sKEF8/pO4d5 tVRTQwcbrjZip0flFC72zb21sHRhu5LkguEgu8+x+4fRo5OCKK4bWsnr6dh8lL06u0g/ FdIL0h73ewQ1FRs5A/iWlG+LZgBQBKIKs7mZF/43CmuCFln82Y+eOeBRsGNhvlxs4+ao lur8yeS1qWqA5+z4HFA7K5kO3X13NvrbWDHxfv5EMK7Z+BOS6X/WP0yWSx+ozQRnjlrF WrnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5k+S5N42RlL6ZM1liWYYGXflOc03n3hOzRNJw8Um+Uk=; b=dGdcKcPOZEheAn1Yt+UiEg9JfqMpF3G7vAAwvmlJRr1dBw1fO5kuj94ElEpaUk4SwT GXhHkUqsXp+eOE5ROqfxqmJCK4rGvnK6KUbDUoeI9eegGvMEL0RVRaoxb2cIFGQitFZu dq28ALaaCmtEm+6FkI0+Ld6XfH3KuY55vZkTLzBWtzfB3O4Ip26Q32qSjlFAb1KqBOWN unmYKQw5UV3so1bq5L1BMcqQGTTyzxIIrP9rW+TDVlaR4A13vZfMiWVtR7vil578uuf5 L0RhR5QVvJ1kv11C+qIEqm2QKIrHB5T1zwq6FzSrfLNOstYoVM2Uq/GjZMf8GgbqYTCC o/gw== X-Gm-Message-State: APjAAAWghEd07pWikz2fgblWcjXEF6k879QUpv53JGb9FgIDmvDIaOV8 MfeEM+K946e9DUfMDcIwy2ukFs6RcH5fcSRNJ6+Xyw== X-Google-Smtp-Source: APXvYqxDo5aRn5af5/fjus+r/t4sJJ7ZEiGkGSsSq95HqCpLUYo8XJ/aVTrldknx//2xzJ6uCLFTixDo69qnu97tn8w= X-Received: by 2002:adf:806e:: with SMTP id 101mr60321wrk.300.1576074190643; Wed, 11 Dec 2019 06:23:10 -0800 (PST) MIME-Version: 1.0 References: <20191122112621.204798-1-glider@google.com> <20191122112621.204798-28-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Wed, 11 Dec 2019 15:22:39 +0100 Message-ID: Subject: Re: [PATCH RFC v3 27/36] kmsan: hooks for copy_to_user() and friends To: Andrey Konovalov Cc: Alexander Viro , Vegard Nossum , Dmitry Vyukov , Linux Memory Management List , Andreas Dilger , Andrew Morton , Andrey Ryabinin , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , Christoph Hellwig , "Darrick J. Wong" , "David S. Miller" , Dmitry Torokhov , Eric Biggers , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Jens Axboe , Marek Szyprowski , Marco Elver , Mark Rutland , "Martin K. Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S . Tsirkin" , Michal Simek , Petr Mladek , Qian Cai , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > My point was that reasiggning the value of n to the return value of > raw_copy_from_user(), but saving the original n into to_copy is > confusing. It would be easier to read this code, is n was left as is, > and there was a new var for raw_copy_from_user() return value. > Ok, will do in v4. Thanks!