From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7448FC678D4 for ; Thu, 2 Mar 2023 15:17:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBACA6B0071; Thu, 2 Mar 2023 10:17:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E44CC6B0073; Thu, 2 Mar 2023 10:17:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBE296B0074; Thu, 2 Mar 2023 10:17:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B57766B0071 for ; Thu, 2 Mar 2023 10:17:51 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6AE461206F4 for ; Thu, 2 Mar 2023 15:17:51 +0000 (UTC) X-FDA: 80524313142.28.1B91A3F Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by imf13.hostedemail.com (Postfix) with ESMTP id 7FF3D2001F for ; Thu, 2 Mar 2023 15:17:49 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=CF2YWaUf; spf=pass (imf13.hostedemail.com: domain of glider@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677770269; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=swy0Vvp7k1UShoRmUJ7j46CPAn/D6prvkxRY/qzs/SE=; b=ETyjiAcJLmEtEDnvFoACuZEhARhJDH7I2VXn33KrsduwWaE0BkT35ETiYA5a9H6/LP6jyh 2NbWD1x48HLKr5ZA2vCkzKawQRUVZecA1NM6rTQCYk+7USgATZ7BYfYAnWK6QzbZ777z8R pfAXhehXzC4zYCFtQzmK5EbTEjsO5wI= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=CF2YWaUf; spf=pass (imf13.hostedemail.com: domain of glider@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677770269; a=rsa-sha256; cv=none; b=IdL0ZNhgd9UtbXNKRy2ay+Nk3MPAbbq441clpra7M3KuwtgQi0dfle93FHaX5F0ODhixFF 22rNqrKjfABvjQRi2gQypZ4QAO2UkE0XOURZbHV6xxO6+1YwLKGJ7ltpBPfP94lzaVD3Mf 693L3Jdtku1YLrHnTfp/dg6soFTNjwU= Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-53852143afcso433923837b3.3 for ; Thu, 02 Mar 2023 07:17:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=swy0Vvp7k1UShoRmUJ7j46CPAn/D6prvkxRY/qzs/SE=; b=CF2YWaUfaNqcOG3qLv84WuxL0ySDJynMHCuWXjDb6SBI6/hv9XsBfe7dnNpWQ75sYt RUBUbfEpveBvA3RMYD7fBkKlwx27eOJnrBYxHupNj2G/pgsT+ygbEk5Thhnk9x/7OB0v rn3/Q4c88hafo04aQczG5eI7ps3iCD1jgVntZ+0nTpDmxcKweFS4aCssk0rjGWPobWi8 chTNOSmRE3M8Lj3Dx5DVEQr6l4FxGjn5YU3xDAc65gIh47YSl1p+IY8CT4iqLvvyfRVO kNhOOfR+j6eQ9KlDg1HKESImS6URfOLplYCbFVLs1gqTbMnTdGuCmwXEvNTaFUFbCVDt 6h/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=swy0Vvp7k1UShoRmUJ7j46CPAn/D6prvkxRY/qzs/SE=; b=viHWtDLx+LSi7w9NnnU/G6IsS4mikUyGlWXDQhJoieof/krQmKHhYF9F1vGamC9C8s R0rtVMBKV5QI5+JoSa2NLZM5TOL92jgdIxs3Ez4+eu8Og75M9zG/ChzUy5cJRwh627og RM5nQzDpkeZ4BpGvtbX9MqWYS9Ygci8UqGVvJNY7h3HNVZZidD2aI9EvLnu3dQwZLG/r xAPpPDGQ20HcMjkNkB9e+7pfhjqs723sV5AzKcJ4KSTM3rH9bWmkbQ/m21Jodc5IkqKn YmUO8R++OZDlFZMkakW/ClWtS0EVUo0K6huCbJB8T75bqwe85/dRMvXOqnz9VEGmO6eZ T01A== X-Gm-Message-State: AO0yUKVWwIu+gvTXkPpXGhKnTRJU+Jzz2JsTuyf6xTXqgTCgVbIhyXrA EZOcbQP5qeYXuaQrftk1VCt9zF13y/IeJZsRO/L2Eg== X-Google-Smtp-Source: AK7set+3VrU1WkPMjDY7pE36z7iW24+fggQzrZ99elu49Vgl4quWaYlSQGHbSXoNkwjoVUmRjlbIWCDcD/wyj3OoPO8= X-Received: by 2002:a81:ad58:0:b0:52a:9f66:80c6 with SMTP id l24-20020a81ad58000000b0052a9f6680c6mr6418676ywk.9.1677770268490; Thu, 02 Mar 2023 07:17:48 -0800 (PST) MIME-Version: 1.0 References: <20230301143933.2374658-1-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Thu, 2 Mar 2023 16:17:11 +0100 Message-ID: Subject: Re: [PATCH 1/4] x86: kmsan: Don't rename memintrinsics in uninstrumented files To: Marco Elver Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, dave.hansen@linux.intel.com, hpa@zytor.com, akpm@linux-foundation.org, dvyukov@google.com, nathan@kernel.org, ndesaulniers@google.com, kasan-dev@googlegroups.com, Kees Cook Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: ixyra1exm131cbkgsda4p398bhuuoihm X-Rspamd-Queue-Id: 7FF3D2001F X-HE-Tag: 1677770269-565664 X-HE-Meta: U2FsdGVkX19EEglR8WRDH7k16kDWjsZxcgOIEJhRUpUrNzfydbgUI1hYxNhXRdBpt31S3+GXZ1Xccq3tOwPwNCisdywczJC/Vgu+ST8kz13AEJgQ9UUJ/GDA4wqU+94B6p5zVyorjv960nOF8stCUb7j3aHtRnFpHdSPxMuXAILlGwMqoEwgOkf4GUvgwptSfOCdhrEy+/vjR1cIKbi+/MoZcdDQcSmUq/oM1cKGe4mtu80ZcsfRx3jHf9GGJPfMBz0e1Kwk5uluK1m2Y899zJhmp8Jb2zTJxNmeStt8VxkMS50GqktdmItE8L1yGGEUo7vRbK0liRWeHZ9wEtxPhhXvg+rDvfLpjHo29f9/7JDEptCmYdH2aoP++zZuyOStT3MEp1b3MWwq38nnCwKNUto6tVPv8AflRedtXwR0pOdihfT1ouYn6ETl/ziUTjAWwNrPKC4EYZCT31r6ntXk53gevfewAyMYvTIEwAvssMZiUIJnEz4D+L6i7lXSLm/3eLI78qmNVnjYS9i8VyZQx8CuJCq0uLDZfg2ky811lIX5HRBGSLtEj39zQoRDoAjy7MKl36gL+PR11XZa6qASSIY1O1lp4GaWgWBgevJI9kEXp98vBxHOkY3pxw0o0+9rVAVYDqwLMaxWoV1HPi3bfGAIghmZkbBa1CPoR+N1KK34gxbS1TW1DKZ/rKJBGSI4TV4bb/MqOPL3KbRLvNEgEGeKYfFLapF879UImJ8BoJ6EGKZFDePj1K3Fg7MVISg8+LF1Ks9oZdG+50okWAqTV0BkToVL23sGsLpMteXohgBsLjufEBtDhktCFjscGVrQdM4p2By7dd5jW5RYIFQ19oTe8WIa03A4ABu6Low0f+xtTOPENoEBiHh/u7t+F/wNnoH1TjKwmrGOaWc5q2hM3PPqhN2ZvExo6jdOgmZCpOV3dDnaa96Sz6AoBhpnXeJEL0Q18jciepRG018w9eN /mBqeVh5 t8sQMwUmAXFVR/2QvZnK3CiOyFa53dxi9zqNT+/KWin7g1QR6W30ZLiA24g5JCjCorD0+g56keiOlTG9tGWsgHr80YK09CU0Q0xbesEcRdJTYpJGaYcymwGbVMygnGD85AADeJNZPAzn5vRpfuyEdYJPQQApvZkHlKTXaNVeelnvMvJp5tcVMPNngxDU7QQBLrINpwMCor6kx0lz0R6dxHMG/3ye9hTs87lKogs/mrh+XIDK2ZYWhxqpoilTXr+Dd9RWElbmYc81rW+gQ3XD/nSWFQHvI4JSZ3PQRTimAeFefvrx7KUvk7Q6cBw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 2, 2023 at 4:13=E2=80=AFPM Marco Elver wrote= : > > On Thu, 2 Mar 2023 at 15:28, Alexander Potapenko wrot= e: > > > > On Thu, Mar 2, 2023 at 12:14=E2=80=AFPM Marco Elver = wrote: > > > > > > On Wed, 1 Mar 2023 at 15:39, Alexander Potapenko = wrote: > > > > > > > > KMSAN should be overriding calls to memset/memcpy/memmove and their > > > > > > You mean that the compiler will override calls? > > > All supported compilers that have fsanitize=3Dkernel-memory replace > > > memintrinsics with __msan_mem*() calls, right? > > > > Right. Changed to: > > > > KMSAN already replaces calls to to memset/memcpy/memmove and their > > __builtin_ versions with __msan_memset/__msan_memcpy/__msan_memmove in > > instrumented files, so there is no need to override them. > > But it's not KMSAN - KMSAN is the combined end result of runtime and > compiler - in this case we need to be specific and point out it's the > compiler that's doing it. There is no code in the Linux kernel that > does this replacement. Agreed. I'll replace with "clang -fsanitize=3Dkernel-memory"