From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CEEAC636CC for ; Tue, 31 Jan 2023 09:08:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 784476B0078; Tue, 31 Jan 2023 04:08:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 70CF36B007B; Tue, 31 Jan 2023 04:08:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AD546B007D; Tue, 31 Jan 2023 04:08:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3E9186B0078 for ; Tue, 31 Jan 2023 04:08:38 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DDD68A0ACE for ; Tue, 31 Jan 2023 09:08:37 +0000 (UTC) X-FDA: 80414518674.15.E14E97D Received: from mail-vs1-f52.google.com (mail-vs1-f52.google.com [209.85.217.52]) by imf02.hostedemail.com (Postfix) with ESMTP id 2B58180003 for ; Tue, 31 Jan 2023 09:08:35 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=sGuXmQgy; spf=pass (imf02.hostedemail.com: domain of glider@google.com designates 209.85.217.52 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675156116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ahEni0vEoNstNN4puWfSl0I1TRpDbWT6saFFu8LT9dw=; b=2wOSi+6YcZv69v7UhBzdT4AvtsQwxTtYSJ27kiRy6TZkBx5sOvHKJDGGXo+7jwT8hfuyeZ eYEsMgpXLCRsL0PPkPPayVp596e2OmnFQZ76/qMS6LzeiBtlcqmnJFRedEkQ7c1d5woWE0 sLxkKgdZMFygW4hODgwgJR+xpwudFxs= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=sGuXmQgy; spf=pass (imf02.hostedemail.com: domain of glider@google.com designates 209.85.217.52 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675156116; a=rsa-sha256; cv=none; b=q1czu5KlYucNqtsr6Z4NDcFZIg5SmQqyYquwnsBHJBxXqd0pkhVdhsrUFc8Mlw1LOzXqb5 Hc8QNmmxjqHGuiicVQ0RyH3rs5Jw7S1yhKLNooYz6jI1xE2oKamE+ou23NrBni9NqxpDmM s0XMCS1U+MmnuC1E/UF46fLd8M8vrcs= Received: by mail-vs1-f52.google.com with SMTP id k6so15398788vsk.1 for ; Tue, 31 Jan 2023 01:08:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ahEni0vEoNstNN4puWfSl0I1TRpDbWT6saFFu8LT9dw=; b=sGuXmQgy7fDR1rKCzZt5UMQht6+7DH0x6DAlL7Sce1QlorgtKchNH3jySV9wVGyDRE uS79UdqXctE41UgKA+u9zVUr0f2EI0SaPS4rrzLMgadqALs6CbPTuKx9XMf1Udjyt3cj R4h9fL6pyaxzFAsSXSPs0chSrBXkHdCTfjxBRJ2TomZTnt+nyc7lRv/pzKsKs2ud8Fqq X1YnOjSlQatGeBlskWUeOicLapRQ6Vu8Gf7Ldjmw6CaARi7jhYJNjC5IGspjNyazSh3S L0rNMbzY8fyGAv10rUQqtvQ/TCYzN5cmbAqG1laaDW3qzoHerrWApJOfIIq5Ujsh/PJ9 TCRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ahEni0vEoNstNN4puWfSl0I1TRpDbWT6saFFu8LT9dw=; b=VskNj5vQFA4Rd0lt4YUY3qaUculOfI1HkIteeL7+lZzE0vdcSuOsOtH8iAWiYs18ub 8wEEO9gjW77+LVA6O2iSOpKbBE0EbF92re9OyBKGtXUZF3a+aGBn812Ix6GLD22edYUH tHwkKwX25B9DYnpFXA9zkRkd2qqoFIfxVcRvlJf5BRiPaH7K0pthXfuD5LGb2dgGGyY1 b5JmeNTQsOwl6n9GeIB85k4t1nHIlprwzFBDmwxvAVnDGODSZU29uv7KuzALCDC3HlNk a1SmdM6rbS9nUy0sNJG9DqU8N5OTN7lDuQZIjTz8p8L4tS0k/xcffIDVNy4M6AcO3f79 Rdug== X-Gm-Message-State: AO0yUKXwjx6xQQYBLzh82iiuIvqgn3EsbAqWIBmk2F5nZS6WCFpFqyAS 0+15hzdWw9wDDNl1EOsMWQCqcl87Op/glbJs5VXpAQ== X-Google-Smtp-Source: AK7set9KOq1qsK4tfr85oQrSa246WDWxkItg3+dwzH1IwyEgdnmwdGOPPnP0UdfR7d3xYktL27QVnVfk/TpiqpFd1Lw= X-Received: by 2002:a67:c31e:0:b0:3ed:1e92:a87f with SMTP id r30-20020a67c31e000000b003ed1e92a87fmr2260239vsj.1.1675156115140; Tue, 31 Jan 2023 01:08:35 -0800 (PST) MIME-Version: 1.0 References: <9fbb4d2bf9b2676a29b120980b5ffbda8e2304ee.1675111415.git.andreyknvl@google.com> In-Reply-To: <9fbb4d2bf9b2676a29b120980b5ffbda8e2304ee.1675111415.git.andreyknvl@google.com> From: Alexander Potapenko Date: Tue, 31 Jan 2023 10:07:58 +0100 Message-ID: Subject: Re: [PATCH 01/18] lib/stackdepot: fix setting next_slab_inited in init_stack_slab To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2B58180003 X-Stat-Signature: 5bsamge3t7bbmgitxwia8w7rjj5wijro X-Rspam-User: X-HE-Tag: 1675156115-943233 X-HE-Meta: U2FsdGVkX18/SivxVln0bZOjp9NvoY5bR+awuiE916zXCOZRCGsYCdlhFrrSSt2tapakWB00rAKhTxtiIKdU3ecNxe6b3y7Br2EIxR+9Lmgf6EJpK1jXL51DdkRRKvY7u6zyAmS1/NhgEH8GL6u3M/VV8oPj3ZilmqixaV4SHhRPO16EIk1lNUcIZse1InO5VQOEdbFYx5jIoQwjLDBdMYa0ttVrEeQr2iluFZ1NAecK5xFx5i0WGjw/CMdO5ZQ8QYtKjs77vg52aYzTi1cBw/DPt9LTDh3X7fnyg3MjczjJrrmW98NkDbNW7YUX7Ua7aMyBl5RcrFjyNy2J4TEeSNToRccsODX5uTGQgUqZhdcp8Odx0kspYUZb9IJrw856rD3TawptHFJkghKuYEEhpCs0CQAH8wKWYrkXAVj7ztkwdJIglmG/XsU6jGtEzb4cTlOq1K/FKjIHd8c2gFjrm74PcrkaTGBDpY8hs1+fgKQNCdTLc9RDl+70Ncsrv8GdLvKRtDFA6XDlrDtjIRoZt/Ox0fPWieywT+YlXGiLV0rIYwsLCpaVHXucpZ4QL/cKPBmXOg8h3OwHOkidbo9dEBnN3mCHTjCtOh6hDujDqKQeZ8Pi79o8cit1VFKLq60K+PYa/MnW1Pf/rbFJY1pWGbs/f4sicjdBelAMF0dg56/H+hFwLD2gWqSFK+auubwwqt2hJm/fw7/eXdNg9nF9ANqrdfNYCNHpdxWxF7Gdn4kLgOFi4NndNAhmjss/+mWuUw/g7Rj99wWmyCzt0sgQI24AoTWXqmSmREJal0R8+11uidhFjIy84me7LVyFRsG+Aj4vx39QseAovj2zqpG9YLFn6ilJ4VEOT/P3LE4FP1Ijwy53nfVjzZRkKVYn5doWQQxU/rbpOb27Qsvx3Z4t96FBqrLNER2zLXuNr/FEMXkDbZxXiOUawM6Ar0EwiJ2TkRQD7qB3khy1M04qiEw RZH914oC 0oMxIanMjC88ztHmGNEKkGm0C53klt8Y4gzVtYfuGU3K+ratLzR8ljPhB1Cu5t132d2phux8zgzhmWP31XZ6wK9Y3NBUk9l6DTV/icDsZ9iCFdUEl342wLJAVX0f6Ywv79FaY0UGl08c0vFoA4lFAEXOzzSufmOJQQgUwxl7s/aeHY7IRETXwRIEIfNTeqeWlCRMXVFjc38OOTDpjcUxVU6K8WeRjjDpEEsMuGW3akjDYZLkLBN5Io+kJ9RoSR44hVlhJZMP5eF0NJzdu/lOpJAL+UigkhxM3zUSThwYJEt3OOmuvfVFnnPokcy0e+W4TU33mgmlavuhFbPhdvWUq4pMT54pps7mF2df6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 9:49 PM wrote: > > From: Andrey Konovalov > > In commit 305e519ce48e ("lib/stackdepot.c: fix global out-of-bounds in > stack_slabs"), init_stack_slab was changed to only use preallocated > memory for the next slab if the slab number limit is not reached. > However, setting next_slab_inited was not moved together with updating > stack_slabs. > > Set next_slab_inited only if the preallocated memory was used for the > next slab. > > Fixes: 305e519ce48e ("lib/stackdepot.c: fix global out-of-bounds in stack_slabs") > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko