From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5959E95A91 for ; Mon, 9 Oct 2023 12:25:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 284508D0059; Mon, 9 Oct 2023 08:25:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2357B8D0031; Mon, 9 Oct 2023 08:25:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 123598D0059; Mon, 9 Oct 2023 08:25:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 028FB8D0031 for ; Mon, 9 Oct 2023 08:24:59 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BA1BA1A0210 for ; Mon, 9 Oct 2023 12:24:59 +0000 (UTC) X-FDA: 81325842318.07.A76E3F9 Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) by imf11.hostedemail.com (Postfix) with ESMTP id 0555040019 for ; Mon, 9 Oct 2023 12:24:57 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Fb5GyPYt; spf=pass (imf11.hostedemail.com: domain of glider@google.com designates 209.85.160.52 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696854298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/XMSmBSmrIghDRAMwSWs7YuLmGLdnz0rmjgVzyIhrZM=; b=wXpgzipDaiJfmUuXI2rl4DsjdcjsIKcX76e0wMw9s2HwlF7w7LKgqds6eo+cN/WhN2fVre jaoRGfXYc+LN81HjJEcGHEf2e26LbmTguhbc9Tmkv67gEMReD9ESxjATDN9FIybrJwJw8t 20JFmNysFoCOsRRf/a+mHlDU+DUU23w= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Fb5GyPYt; spf=pass (imf11.hostedemail.com: domain of glider@google.com designates 209.85.160.52 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696854298; a=rsa-sha256; cv=none; b=H3S3O+ADMqKGfGwZ0o/WoWzAXSvtaWylzvZ6mIrkPpZ6jPhPSxz45m7/PKtbNb9Cw8ofPr U2a1zMZKvznbhB1gptitjeb8MoWx8dfjorf6meA3MxLYi7MtrcX5kXrISeKbUAkdZtB2PU F0X7UkEsGIZMvTwEwdO5Fs7nnEDfJSk= Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-1e58a522e41so1944507fac.2 for ; Mon, 09 Oct 2023 05:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696854297; x=1697459097; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/XMSmBSmrIghDRAMwSWs7YuLmGLdnz0rmjgVzyIhrZM=; b=Fb5GyPYtVsCR4yYpZRUibkMlZlxyMN8SKoP7rqLcrPddwMcihqQ1DoDr+RTjDmC53F T6A8hX8QDQTcHT1qfNMQ91XAIFVdNRUW6S9mGAFQOtwQF1Ci5ZLYoFjy3THQ9lILBNlY +s2Ny51e3OVxDFA+/G/8RjMyM89YfAISLz6lN/PM/FeRyvxC13j5O1kr5VvAaxiYOvXQ /cd5G+S8FiDl5a8ZAjsa7Ej5ZJflY9s7zEmG2Yn2fw9dX2JHunlt4xbFZXdhoGg2AQv+ lT++vZAjQ1BmYbkAvPchaF2lFclI448PoKkNduKjiigczbVdPtzU12s6/4vIHr/2TNce x47w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696854297; x=1697459097; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/XMSmBSmrIghDRAMwSWs7YuLmGLdnz0rmjgVzyIhrZM=; b=I27xtkFZOQ9Mk5k4ZoE4LKK7oFiL/NLEJuCIkGHwasPtZvqeD5HM87DJHzw9XPDJrs qrLfoWQtubHgVTrPD6yzJNGz+V3YLyL9vRG9f1znxC3CvgVwpJcM3N97Leb0KO/mhsgo z1u+WqeXLp0XXpl1uwCFNUNkpkPyv/pLDH2bscKV9gjeruf73KmukYRsNsJa83prtYs5 823kREacdd5bIoN9w6Uv8jlV55cMrMw0jw6KDDFAtVMLTwUp18hX2Ks6UaVkeh/7y6uY l0xop3As7hoAkMovd57ppGQ1xZUgm7bR/ye6zwPB0UN4gVCm7l03Zxyx9Tfb8QuqwQQ+ 0DnQ== X-Gm-Message-State: AOJu0YzYGjn78kVhrITxQIWKAShBx2tRsA066PM6AMBWsUlUi35b3k9y R7Fs9SNY2718nBUAfBAK+M1qc2iVp+hLxgQnY8A7Xw== X-Google-Smtp-Source: AGHT+IH6/QocEv3JYM+yilbyZ1Xl7cqTgYJqQlPc2w8elKWmV5kM+Lc10JwYbAVsPnJzVeUI1EZn0iGeXNJoP3bX9SE= X-Received: by 2002:a05:6870:5252:b0:1e1:6cee:26b6 with SMTP id o18-20020a056870525200b001e16cee26b6mr19546563oai.8.1696854296959; Mon, 09 Oct 2023 05:24:56 -0700 (PDT) MIME-Version: 1.0 References: <6e2367e7693aa107f05c649abe06180fff847bb4.1694625260.git.andreyknvl@google.com> In-Reply-To: <6e2367e7693aa107f05c649abe06180fff847bb4.1694625260.git.andreyknvl@google.com> From: Alexander Potapenko Date: Mon, 9 Oct 2023 14:24:21 +0200 Message-ID: Subject: Re: [PATCH v2 19/19] kasan: use stack_depot_put for tag-based modes To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 0555040019 X-Rspam-User: X-Stat-Signature: d54uc36awqgeg73y6anpnoe7jn7igxtp X-Rspamd-Server: rspam01 X-HE-Tag: 1696854297-94247 X-HE-Meta: U2FsdGVkX1+upPetn2MUEx2iOQu5yLgI4v9Jn3kzzUaKEU+oSYBndHRnqZ9RYg9tb8yFaWCwNEiQfPpaotrt/qIncx2rk7wkcR0qHM2GEiFn3jd2DxoQUVNJKJFS6mcaB7zDlnZx//iuzAIbYpM7Ox8twbdWM8QzkoL14R5+UqC5D/ZBl9xzV/JMOUPIevKh0Y3SaBVFNxTHmIM663r8pLZhmXdVSC7vDUmD5z6T9JVeOASqQvIIRcBPnZvGqT9qGiiaiYv+ct1ldgbh0KQp6wm0p5xUOZGgrllapfptAV3rKGpgiSl9K9yoInYsELAkcp6tRzTbIlp3Mr9GQaBXSQJbFKIB2Tz13wUq0Prf0ECwo2z5O153lVrM6FPqyG0fD1bGNHBO9LHWb6fGtOfP5JI+kIP5UqtdqqoGHNa14W/2YguJxHHcaCUnIxN53nSUtBYZdFfxhBgb7SSfMV7uQpPBX8fMdkDB/Cop5mLRnR1nmqK6yqtd5n24tG8TOSZSM8j3T9IETLloOK6Pc83PGdUQeVK9UKR7R7+0IToDHVoWmKB1mq67fjp1G1oYi4F/nfqPpcnKXP+qfDPovIQ3Pe/wDyxZYgqqO7Aiy0CflAnMtbkLohNbYIZx7ACDMiMjsfyydsVAuAK4KqjYI8dZlnfQdp1tPBa5gRRBt1hJISrQrrasY24Uxd9TW18q08ynFYNJ3dAXMjXud6HCXcG9RBtK+ajfStlxmamXaD25FPHBx2l0u+v/PjWPs1gnwvlT2vocAbPTqN0uubx0+A31+8FPaeMbb9Pgqj1LA/t0t25mQo/4oJStqxFgk/6TvtD4r1y2A6U1t7oHd+JSLAqVxOhk+MRQKq9Fy2EM+9J9dxIcsCMfElabaT8kqEPmEr65vbWliwz084834MLItssNVw3X0aHHwIUguPQstfNeI44a+67KWRg9d5iXtvRNqbaj34ufd+7kVLOHijkSqAY d8TfwPBT T0mOxR5ekWpjmcB6ZlxSeYVSWMyf2lmeEhvTqXxnH41SKp41OQMWT/Z1f1q3jBrxRdRvI/pQKIwsLUsVVo2l2KixVMk2CnjfVKdY54CjPHPF6qwBRBXd2WVoXg/F3HIT+wYtAZxfK0C3ujcZFwSWNYoNU0IqQPnCFMzaf8Z0dzI6g2deuZ2XwsZl2MyTVUxlFhI1XJS/NJlAFDmnihOAZNfffyvXgCMqbramoPoYxdvmONO4E8cRBbV0Zv7NpCnkKKHgXRnPSwtaQZ8ogCSD8e2q6/W88np0wbQVXxkO52m269JGfQrMr7V3Mhn1LOviYSZC4W89hGFYoc20= X-Bogosity: Ham, tests=bogofilter, spamicity=0.015366, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 13, 2023 at 7:18=E2=80=AFPM wrote: > > From: Andrey Konovalov > > Make tag-based KASAN modes to evict stack traces from the stack depot "Make tag-based KASAN modes evict stack traces from the stack depot" (without "to") > Internally, pass STACK_DEPOT_FLAG_GET to stack_depot_save_flags (via > kasan_save_stack) to increment the refcount when saving a new entry > to stack ring and call stack_depot_put when removing an entry from > stack ring. > > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko (but see the two other comments) > --- a/mm/kasan/report_tags.c > +++ b/mm/kasan/report_tags.c > @@ -7,6 +7,7 @@ > #include > > #include "kasan.h" > +#include "../slab.h" Why?