From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 569FFC19F28 for ; Wed, 3 Aug 2022 09:42:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9446A6B0071; Wed, 3 Aug 2022 05:42:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F3BD6B0072; Wed, 3 Aug 2022 05:42:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BB988E0002; Wed, 3 Aug 2022 05:42:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 695706B0071 for ; Wed, 3 Aug 2022 05:42:24 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 36E44ABD93 for ; Wed, 3 Aug 2022 09:42:24 +0000 (UTC) X-FDA: 79757791008.18.53BEFB6 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf07.hostedemail.com (Postfix) with ESMTP id B2D9340064 for ; Wed, 3 Aug 2022 09:42:23 +0000 (UTC) Received: by mail-yb1-f178.google.com with SMTP id 123so27520898ybv.7 for ; Wed, 03 Aug 2022 02:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=/5J/hTicAQKvIdTCsN8vIr3eGdVqz6oWNgR8PbCUFZ0=; b=UW16xIvrWocqAhSPd2fuZKeM91zaflQgPYWDJgcud8Cri8Ym2URa03dCI1zYrFIezW fICUhA0MZ7uec2/HuZSKY8g8uGB5q9N7Au4XQr5K6FFHmZ0hO8ktztxtkSHEE/vb6IJn KEbgA906UOjZ2Rsii9K4/vyPRuud1tCOtgEnGKmFhWYZsrm+DJlhbb1l0W8029yPcEw/ 8c52Bmse7AJhuI4irdCL1QGGKXLNRBxfMKaBMuCSsl1oJGfOPZbVh8tpZKDkfDCUULtN JQPCee3tCjakxMT3yWiBiUPIVoXDmFby7RIPPsTaDJd+7IqvhfoTZn6FAP+2a7YrsBk5 gNYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=/5J/hTicAQKvIdTCsN8vIr3eGdVqz6oWNgR8PbCUFZ0=; b=R83wu1VGq0n6Sq2ukl6K1hiS6GZL3c97Y5k5PqaHMYQMQFQfgqM5fAN0BldNpSw5FW XWGrSP5CcJl7Lsa7jl76pirgEWjKv6PQDvjKvGymHsCG1mTWnjO+lR7M5jwptsyxLWhc tFnoZCYB19QCTFzL2Yn2CAK4q9T0MA5dVg08pGGQXKHelBkHheo33RDqQJ0p4GltmFSn +ruiYQDkQqWDvIO5B8sMB2LIHHJrl2dcNVCWbJ1S9YSdN/zag3EhFxH3H0/IFxP6K/JP ufREHG82PdnNybOCkB6n6Dlcuj7HKUOX55JrztFDMM8voxSM9fc1R5dRr+OCplAJti1/ 5srw== X-Gm-Message-State: ACgBeo1KWyfpgDeyqLbglh8+MURC4dq4asp5JDXObSDVXi0NbCf4XDdJ tcVexHIbmWlEbma1CH8CQeweStzFBD+N+r8p6tMQ3g== X-Google-Smtp-Source: AA6agR7WMDXiL70b6NLngI/XHKFbP2/r+w7WmXN1qYL7/w1ywK0n4OfWAmZKsLbnW7QxKw6oUWpd6k7KLsAW0q+NLBo= X-Received: by 2002:a25:d7d3:0:b0:671:899b:eafc with SMTP id o202-20020a25d7d3000000b00671899beafcmr18510665ybg.485.1659519742790; Wed, 03 Aug 2022 02:42:22 -0700 (PDT) MIME-Version: 1.0 References: <20220701142310.2188015-1-glider@google.com> <20220701142310.2188015-11-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Wed, 3 Aug 2022 11:41:46 +0200 Message-ID: Subject: Re: [PATCH v4 10/45] libnvdimm/pfn_dev: increase MAX_STRUCT_PAGE_SIZE To: Marco Elver , Dan Williams Cc: Alexander Viro , Alexei Starovoitov , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev , Linux Memory Management List , Linux-Arch , LKML Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659519743; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/5J/hTicAQKvIdTCsN8vIr3eGdVqz6oWNgR8PbCUFZ0=; b=EvFayGT+SHOPTmZxkIqCp+8PswcxZvI9uom6WG5rsNrz34RP1s4La2mT1vdbYxWRSM4BFg lkfTKNLUvtJzj6K5XZ15qSh5rJPArIM9Xgjzavh5hLeHtNvZv0i8K4H2CtU3l+QoWdLWKM QyyuGJ3TK4A29GqJKNBnQhkGEQOoPDc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=UW16xIvr; spf=pass (imf07.hostedemail.com: domain of glider@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659519743; a=rsa-sha256; cv=none; b=wLceBJuFy4kOBCNtK+5E/STLdFj8fbzdl5j4dMuoIg7cLy8nQfXYoLTsPQ59b5QwMHo4l7 sTvczVkbR8e3gJwL2SuOxIl9AnfqjLJutpwAcslTFFK14rH7RH6Or5riKU7AnY+J1yNqbv 9P5Duz/uzUH3SMeii03xyEdGEUZEZ7U= X-Rspam-User: X-Stat-Signature: euoo6yc6z41frgt7ja79cci93zxr87k7 X-Rspamd-Queue-Id: B2D9340064 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=UW16xIvr; spf=pass (imf07.hostedemail.com: domain of glider@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam08 X-HE-Tag: 1659519743-192561 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: (+ Dan Williams) On Mon, Jul 11, 2022 at 6:27 PM Marco Elver wrote: > > On Fri, 1 Jul 2022 at 16:23, Alexander Potapenko wrote: > > > > KMSAN adds extra metadata fields to struct page, so it does not fit into > > 64 bytes anymore. > > Does this somehow cause extra space being used in all kernel configs? > If not, it would be good to note this in the commit message. I actually couldn't verify this on QEMU, because the driver never got loaded. Looks like this increases the amount of memory used by the nvdimm driver in all kernel configs that enable it (including those that don't use KMSAN), but I am not sure how much is that. Dan, do you know how bad increasing MAX_STRUCT_PAGE_SIZE can be? > > > Signed-off-by: Alexander Potapenko > > Reviewed-by: Marco Elver