From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99742C2B9F4 for ; Tue, 22 Jun 2021 09:28:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 27AC46044F for ; Tue, 22 Jun 2021 09:28:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27AC46044F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B84456B0036; Tue, 22 Jun 2021 05:28:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B344A6B0062; Tue, 22 Jun 2021 05:28:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 987386B006C; Tue, 22 Jun 2021 05:28:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0146.hostedemail.com [216.40.44.146]) by kanga.kvack.org (Postfix) with ESMTP id 676CC6B0036 for ; Tue, 22 Jun 2021 05:28:29 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0BDF29885 for ; Tue, 22 Jun 2021 09:28:29 +0000 (UTC) X-FDA: 78280834338.31.DE0C977 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by imf18.hostedemail.com (Postfix) with ESMTP id BA1A720010B9 for ; Tue, 22 Jun 2021 09:28:28 +0000 (UTC) Received: by mail-qk1-f175.google.com with SMTP id bj15so35998842qkb.11 for ; Tue, 22 Jun 2021 02:28:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E4DQbfXpC/jltQHrmKqBHkqXNz4Cwyp0eCIHowO6dsE=; b=UuHF70wnNI3ul+ZHhqnG6aOsBavnT4oLVZB+yfHB/nEC0ISs1e1rg+GAlcDJncL/Np tR9CBRszzXT9NkQpQ7rnJZaFEwYtKPcLqx5uH+0gcWQ5dgg6eF9burvSkSFUTArQNxo9 bmQhvemRjqXGhPOW80wdSpGuA+BGQdiSOza8AI77rD/GjqmozYM2kQpJOrcxvSy6q95h GDEDzMT2Mex2wl6yqQvb1A1r7msSftqBdCkUTW1ONCuoZP14B/FB8qRhQibg9ExwdxjU KjymMi9bWIdb7RjBEkVaaWZOHlSYlwwVwYhkImS8j6ebeIIOH0mjrQD/yNbuPDmObCdh 1sNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E4DQbfXpC/jltQHrmKqBHkqXNz4Cwyp0eCIHowO6dsE=; b=tdg1RVqwSjYMQra1PhUfoAkzTKZxYPsDSgOVqcla7vThVysot2hU1eHc1Dkjv7Omug H+vB+ZH1cYnmtjdH5UMn3Mk3lwfVixpuCLUo+1/Yr/4rhxdRw3MGy9vm9jjCqWBKFXlJ H2MT1sbTS3XMkOPBKlY0KeYG76/Gs7TJCvfUWSgwlW6CqZtI0KmLhc4Lmn7gifVUpcKc p0IlfhIQ33iVrhwEViQ+gfSSTSOl6fFy8OJ4C3B2vPoT2QzQd5AMj7JVYbR6hCRrE2IR 2CdjeASliL2t2lXJ6Tyk0g7aR123jrS1sa7YnUW1en/Hwox5lUNjAJ6hoct+WbbrpWNx Tnug== X-Gm-Message-State: AOAM5323EP46p4E/rWFrgM9ibDG1Q4v75uHGC3ZGD7yBpzhTFOk47fCz +ArLBpuK0M3RCyAR/3gP0lTGPBMcfgO2LL1h4PbDCg== X-Google-Smtp-Source: ABdhPJzpBHPyht+lAjdu5BHc9KbrkBS1r7WeeCuc7EkB1p9/MtfIKFKON+Lj/E/4fUHj/Tk6lQGR93DsQjYoUZHYv/U= X-Received: by 2002:a37:670a:: with SMTP id b10mr3184065qkc.352.1624354107698; Tue, 22 Jun 2021 02:28:27 -0700 (PDT) MIME-Version: 1.0 References: <20210620114756.31304-1-Kuan-Ying.Lee@mediatek.com> <20210620114756.31304-3-Kuan-Ying.Lee@mediatek.com> In-Reply-To: <20210620114756.31304-3-Kuan-Ying.Lee@mediatek.com> From: Alexander Potapenko Date: Tue, 22 Jun 2021 11:27:51 +0200 Message-ID: Subject: Re: [PATCH v3 2/3] kasan: integrate the common part of two KASAN tag-based modes To: Kuan-Ying Lee Cc: Andrey Ryabinin , Andrey Konovalov , Marco Elver , Dmitry Vyukov , Andrew Morton , Matthias Brugger , kasan-dev , LKML , Linux Memory Management List , Linux ARM , linux-mediatek@lists.infradead.org, wsd_upstream , chinwen.chang@mediatek.com, nicholas.tang@mediatek.com Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=UuHF70wn; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of glider@google.com designates 209.85.222.175 as permitted sender) smtp.mailfrom=glider@google.com X-Rspamd-Server: rspam02 X-Stat-Signature: c1m5ditftinhe1dtj8fiiwd1hi8tcp8n X-Rspamd-Queue-Id: BA1A720010B9 X-HE-Tag: 1624354108-77813 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > diff --git a/mm/kasan/report_tags.h b/mm/kasan/report_tags.h > new file mode 100644 > index 000000000000..1cb872177904 > --- /dev/null > +++ b/mm/kasan/report_tags.h Why don't you make it a C file instead? > +const char *kasan_get_bug_type(struct kasan_access_info *info) If this function has to be in the header, it should be declared as static inline. But I don't think it has to be there in the first place.