From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73C01C77B73 for ; Wed, 31 May 2023 13:32:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DECE48E000F; Wed, 31 May 2023 09:32:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9C098E000C; Wed, 31 May 2023 09:32:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C64308E000F; Wed, 31 May 2023 09:32:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B6EAC8E000C for ; Wed, 31 May 2023 09:32:35 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8911816012E for ; Wed, 31 May 2023 13:32:35 +0000 (UTC) X-FDA: 80850639870.10.C2E24A2 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by imf15.hostedemail.com (Postfix) with ESMTP id 8CD33A000F for ; Wed, 31 May 2023 13:32:32 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=eALIl38K; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of glider@google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685539952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FC5ZHQYhVGruRZzu25rwbdk8lIo1ZkShJ8yWfi2XGG0=; b=l+LOei990Dl1omVBE/UDi2QVpgOmDcvFJ8oqeeWKhcJ40In2hO8/msJwu9qDr9DXNFTeBx WCsSGkOCkQTGlEdiqAd7eVHPuoReLLIHEpKZ+ay4kLfhxZHdEr9IzEE1wlc/Mi5jishlwZ HyDEc/Wo/bG83g56z6tYDgeWuTnC7qI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=eALIl38K; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of glider@google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685539952; a=rsa-sha256; cv=none; b=KDsYd449HlriiQcUiw50USjXbxveA5415WLggjdWfsJx485CdIvcYjrQ9LKdX5ge0e9uCs mJkoV3bvBPFPJ0t68wCsd62Bv5WhWAWxm61F8BZkxLwVkW6UVgP37TgFz/ICQASRoFzVDF awMm6S561J3+/bF64svKoK+331WKevw= Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-3f60b3f32b4so42630025e9.1 for ; Wed, 31 May 2023 06:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685539951; x=1688131951; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FC5ZHQYhVGruRZzu25rwbdk8lIo1ZkShJ8yWfi2XGG0=; b=eALIl38KhtbsHSpudpUPnjFrsOEIYSkrFAnkXigWE5hAC3vH8XbYRoq8HRuIpEGWxB 8mMC1gPYsQnxGnNso/OImew+TmSdLSwzQ12UDAhmMoKKGNZblQLc6YX6MsOJ1b02sLCq aV+am/0aRRy+DRgYxMeoHCuUgemwXD6UWPAP5HUB6etrBCg8r8HpNUYafkUGmPzcJV/B XJNmnPfHrcywJY5BEF8pM018GXiT3TjjyxxnffBa9vnFQ4tRY8RHTkvDVR5Lp7nz8DpA H4OQmN7KGkr9ZWKW5yqB3YA5R+yeOWgAzIBG0N9OsaIEbi3ANFvtAY3PaRo57D1fyH8x 4+1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685539951; x=1688131951; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FC5ZHQYhVGruRZzu25rwbdk8lIo1ZkShJ8yWfi2XGG0=; b=U40K4wLOBUxc+0gWOU/gjDBB/S34yk8R/xCe8dL72oquSW7z4cQ2lPQfnp/UVQN2yq 8xSGJSCMlhM5h4PqR04tyawUVLqqcwPfe/2lp0V0wXUromBDhBOJ62UAAGULWLdD0SWd XBMREtKpvoc9M/Lq2rNKqo6V7rF6ynq7Xxsq3VHAWgQh5yQQRItpKZQBrHOj321Mr+78 hWl3imAgUd7qj1ytT0wYyDV6ZYVbBkoxvkiHDIfAFuK5MKpSgQkvvzRRASx4nlqke2a/ XGl+YQffd6B6By6cONXAjPgktd+1vNFDxukRtNFiqPJ0o/0SeKbRgyB/Z73MkrWr7mD7 mRKg== X-Gm-Message-State: AC+VfDzZ9zW5ugQTgmOdUY/YTHPGrGVBdX+Yv1ljrpg+hm/LxchOhqLq 9gGBY/1kRdVuJ7nmj1DB+soJUddc7YuhVVrj501k8A== X-Google-Smtp-Source: ACHHUZ5u4KjvA0gwE0At2gd1E44HsIggY8a3QySWzJEwaj31gxC6Up3Q7TUkUG3QSPJUy9Imu2Ippma36zHVpE/S6aU= X-Received: by 2002:a05:600c:2941:b0:3f6:174:8c32 with SMTP id n1-20020a05600c294100b003f601748c32mr3696783wmd.6.1685539950854; Wed, 31 May 2023 06:32:30 -0700 (PDT) MIME-Version: 1.0 References: <000000000000cef3a005fc1bcc80@google.com> <656cb4f5-998b-c8d7-3c61-c2d37aa90f9a@I-love.SAKURA.ne.jp> <87353gx7wd.fsf@yhuang6-desk2.ccr.corp.intel.com> In-Reply-To: <87353gx7wd.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Alexander Potapenko Date: Wed, 31 May 2023 15:31:53 +0200 Message-ID: Subject: Re: [PATCH] kasan,kmsan: remove __GFP_KSWAPD_RECLAIM usage from kasan/kmsan To: "Huang, Ying" Cc: Tetsuo Handa , syzbot , syzkaller-bugs@googlegroups.com, Mel Gorman , Vlastimil Babka , Andrew Morton , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , Vincenzo Frascino , Marco Elver , kasan-dev , linux-mm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 8as1xnso9cb9zq76fzpsr35pziwt4d7r X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8CD33A000F X-HE-Tag: 1685539952-12170 X-HE-Meta: U2FsdGVkX19QQzajVfd4wAluWiutTLRG8DcdMUvraAv7ClrGxqUy9dTF5J7rA8u/0z9ODyMHB6qagfIUK1iEnHpfgZguXNPxb+uL6Z5jf5ZaRV1HJf298O+uRw/m6+DIaBZy+XQ4EMsKUAeNSui5S1CPyjHxCJN/lsBjWlHPczNXLYGwSn+AH5HSJ1z0ImefVJHiWQ+jQeyLXIKUHLlWt5WsxfkfhyUoIHAHiTu8WKzgidUHJyh2PWtzA3JQVZBdUKSvjEnNGxEbuFRq4bwvbbGtoL7wfts+m7S99bhz0c6jEj9Kxn1WhxU2Eazy1obTfOItqThW7Z9LbEIBAxHQZKb3wwWLoiVpzQ3kU5G2nLG4vNuMJBuxwlQ4W4Nsj8sqr+OjGM0Uj4LNyLluRuUrjQfiJCfKUM98DjQlH60NDom1cbvQGK++Dm9EmzE4AmBE5uWw0Srzf6pC/JiOEKkY58M+UuM8szskDQBuXW3EiJHo9y/rmeixJTDuA6N/+tMsev4KIDMmFii7MWFk3ICKRnIHNeWxTsgQuVlb87V/pDyjJ8RsR7fEmFyDGCE6+B13RUoSqEXU2JROLuxgAxR8Rc/udiACDJD7AyabNqkZRFUQGR8msdnLKoDQaYEHXigaC6dCRMP2wcjKZ1o+lAcBR/T4GoZ15KuTE0StOfVRypKiaAbrJnfnPzrYyBwdc5Wqsi8+yJk22F4c88QPDmUO3bU/mBXgmHFb5akxQxFvuG8VVjBK8t15VNRl8KXPHhAUi73qKaFcSfg8CZHxGkSb9VVdDkxZdq4IOqATKC0XaSBh9PAC1FR0BnaWA2KUX7pdy42R85vWlJHjcDsH6uI11CaXY7UgIiN3eQpZ5qqWmrJ2W5vP8uGhvX5k7szZnkQGBv9UfnN6rZcHhVCVKSDAlkFuUWP25x9XlfGvopLxmMFvdnw+l5+iNECrLWnoXxRQt7MdwPgTla2s4/jZE5f TW7IMXZK 5wSWrCre4EA/bd6AukzC01Zhp5v9Wlutfj2n+flrRuvHhMPxzEz48GHlMKat4bHNar8k1cOiRGSQZFQun92k/DuH4OjaDJrGQSYmIpGUujDaPs+PZIUI7ZZ2cLPeTOFpeOpHTOyBQ7T2GK378B/qrSS/X/DMY5C2CQ86z7FaXR76vB7WZHzZW+ExFfKF7t5ZQWY8vcpRFYYPbbgkGXzfv8wg0AfMvSgoe1zFBaEBI/3V3758aPxn9X5XILjCTM9xCLLpAv99OF6yI7j4OQxPu3s+4vGWV74Q83c5kpogvdVvbGJxwQc7OTT/eYs4y5EIzeVgJ2zpG7TDiYuULmIgrut/Qrjc0uh3DWnMfdhkiyAk6VSW2qKBoSugCyed2UDcF890CvJlvIQgCxfopy5+grlhSAc++1kCHKKA1W+t5oHFsa6eDWcBVwu2ldJgGUjr82mqroHPbA3GHisir8VgfsTNYF/CjEjZpdCAnSnHhFTq9WHTtAfizZxYxZlsNEYoGv6Jq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 29, 2023 at 3:08=E2=80=AFAM Huang, Ying = wrote: > > Tetsuo Handa writes: > > > syzbot is reporting lockdep warning in __stack_depot_save(), for > > the caller of __stack_depot_save() (i.e. __kasan_record_aux_stack() in > > this report) is responsible for masking __GFP_KSWAPD_RECLAIM flag in > > order not to wake kswapd which in turn wakes kcompactd. > > > > Since kasan/kmsan functions might be called with arbitrary locks held, > > mask __GFP_KSWAPD_RECLAIM flag from all GFP_NOWAIT/GFP_ATOMIC allocatio= ns > > in kasan/kmsan. > > > > Note that kmsan_save_stack_with_flags() is changed to mask both > > __GFP_DIRECT_RECLAIM flag and __GFP_KSWAPD_RECLAIM flag, for > > wakeup_kswapd() from wake_all_kswapds() from __alloc_pages_slowpath() > > calls wakeup_kcompactd() if __GFP_KSWAPD_RECLAIM flag is set and > > __GFP_DIRECT_RECLAIM flag is not set. > > > > Reported-by: syzbot > > Closes: https://syzkaller.appspot.com/bug?extid=3Dece2915262061d6e0ac1 > > Signed-off-by: Tetsuo Handa > > This looks good to me. Thanks! > > Reviewed-by: "Huang, Ying" Sorry for the late reply, but maybe it would be better to mask this flag in __stack_depot_save() (lib/stackdepot.c) instead? We are already masking out a number of flags there, and the problem seems quite generic.