From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EB3CC433F5 for ; Wed, 27 Apr 2022 13:23:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F3246B0071; Wed, 27 Apr 2022 09:23:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A12C6B0072; Wed, 27 Apr 2022 09:23:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 543626B0073; Wed, 27 Apr 2022 09:23:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 421806B0071 for ; Wed, 27 Apr 2022 09:23:04 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0A08F612E3 for ; Wed, 27 Apr 2022 13:23:03 +0000 (UTC) X-FDA: 79402724688.16.A73CD84 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf30.hostedemail.com (Postfix) with ESMTP id 31E3D80060 for ; Wed, 27 Apr 2022 13:22:56 +0000 (UTC) Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-2f7ca2ce255so18276717b3.7 for ; Wed, 27 Apr 2022 06:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lTChzR1l6Fyb/9cgX7AZvSL07PrKsVlUDY8Ot51JsZM=; b=jemas5/kgwe4e5p2WH/ABhbm+hV9+1VwxHxGqX6rOoJrOOwBuZDDg/Mla7cN4hkQg8 45bxkyhcVJ30C8RzKi0W85x+NfodoXuu39ZoneyPrXeaXdeRF2X5b5/aBMIzkEGtm+so xfAms82T69JBHNRIJejUKV6bua3YbV+fhfLTvfZ5TAdMApw4HjGYBzVE1nESkqqL33l5 XchY7XQikuI4WnHm1rfj3q7t+GquROyonlQDCQKgFnitk5r2sJtwkGQ5hTJISYpx7SW7 BGsV2EbOhQiCtF5uv5DmPQtpXJRUI2sEsK7k3a2JDW+wG9rqVGzA46a4+MwEBKb4d/qY VcOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lTChzR1l6Fyb/9cgX7AZvSL07PrKsVlUDY8Ot51JsZM=; b=slMzZpOYAQqoovaWCPIeMFAkI5ucAQ0JbF6kL4FSMan+Bbh/AF79+ewEsoQZ9YzimK MozrQtIGyl9lLwRHgqlcv/5lRjbi+YLNlbcVSW9glbgScshzuXfqZwaYXqQx1351JdQk dqb9pT2FkdjWYQxQAE0ZsCpG8nRDOi+onI9mstlPHi/AWDb67ip9wJPoCj+LkLW/j/ie 5S5Qx9E+fQ4BsHZo3MxW61qTOR2W2XJAWfPmlujEc8ig9DjMbNc4U6Xjb2BAwkpGxgMB kcF23iBkRadKbNKwpea/fQtxFnv+EmuKsuLRQrUDiY2/FsCDjFcX78pPFtKGEkVfffAE uRAA== X-Gm-Message-State: AOAM531cb/CH7HB+8hX1Nt35Mf5rc5/aic+2C/xkEEZMW3RuBu4vqnfo qmlZ743gZAJxAK8oDXPXZjQjDSAO4EdeAdEYzNu6yA== X-Google-Smtp-Source: ABdhPJwcgwbhlyZzr6yNIcrnUlabKlatanswrveeVyNVkmQ1Y1Ijzji3kbes2UXPG+1ee/V1TxbScq0pUpNPv+2lj1g= X-Received: by 2002:a0d:d615:0:b0:2f7:cdc9:21c0 with SMTP id y21-20020a0dd615000000b002f7cdc921c0mr18939638ywd.486.1651065782601; Wed, 27 Apr 2022 06:23:02 -0700 (PDT) MIME-Version: 1.0 References: <20220426164315.625149-1-glider@google.com> <20220426164315.625149-2-glider@google.com> In-Reply-To: <20220426164315.625149-2-glider@google.com> From: Alexander Potapenko Date: Wed, 27 Apr 2022 15:22:49 +0200 Message-ID: Subject: Re: [PATCH v3 01/46] x86: add missing include to sparsemem.h To: Alexander Potapenko Cc: Alexander Viro , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Marco Elver , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev , Linux Memory Management List , Linux-Arch , LKML Content-Type: multipart/alternative; boundary="00000000000079773105dda2b5b6" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 31E3D80060 X-Stat-Signature: 17noww8d45zfhr7betps3qp11a34yn7i X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="jemas5/k"; spf=pass (imf30.hostedemail.com: domain of glider@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1651065776-242561 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --00000000000079773105dda2b5b6 Content-Type: text/plain; charset="UTF-8" Sorry, I somehow failed to update the commit message as requested by Borislav in v2. On Tue, Apr 26, 2022, 18:44 Alexander Potapenko wrote: > From: Dmitry Vyukov > > sparsemem.h:34:32: error: unknown type name 'phys_addr_t' > extern int phys_to_target_node(phys_addr_t start); > ^ > sparsemem.h:36:39: error: unknown type name 'u64' > extern int memory_add_physaddr_to_nid(u64 start); > ^ > Signed-off-by: Dmitry Vyukov > Signed-off-by: Alexander Potapenko > --- > Link: > https://linux-review.googlesource.com/id/Ifae221ce85d870d8f8d17173bd44d5cf9be2950f > --- > arch/x86/include/asm/sparsemem.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/x86/include/asm/sparsemem.h > b/arch/x86/include/asm/sparsemem.h > index 6a9ccc1b2be5d..64df897c0ee30 100644 > --- a/arch/x86/include/asm/sparsemem.h > +++ b/arch/x86/include/asm/sparsemem.h > @@ -2,6 +2,8 @@ > #ifndef _ASM_X86_SPARSEMEM_H > #define _ASM_X86_SPARSEMEM_H > > +#include > + > #ifdef CONFIG_SPARSEMEM > /* > * generic non-linear memory support: > -- > 2.36.0.rc2.479.g8af0fa9b8e-goog > > --00000000000079773105dda2b5b6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sorry, I somehow failed to update the commit message as r= equested by Borislav in v2.

On Tue, Apr 26, 2022, 18:44 Alexander Potapenko = <glider@google.com> wrote:
From: Dmitry Vyukov <dvyukov@goog= le.com>

sparsemem.h:34:32: error: unknown type name 'phys_addr_t'
extern int phys_to_target_node(phys_addr_t start);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^
sparsemem.h:36:39: error: unknown type name 'u64'
extern int memory_add_physaddr_to_nid(u64 start);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Alexander Potapenko <glider@google.com>
---
Link: h= ttps://linux-review.googlesource.com/id/Ifae221ce85d870d8f8d17173bd44d5cf9b= e2950f
---
=C2=A0arch/x86/include/asm/sparsemem.h | 2 ++
=C2=A01 file changed, 2 insertions(+)

diff --git a/arch/x86/include/asm/sparsemem.h b/arch/x86/include/asm/sparse= mem.h
index 6a9ccc1b2be5d..64df897c0ee30 100644
--- a/arch/x86/include/asm/sparsemem.h
+++ b/arch/x86/include/asm/sparsemem.h
@@ -2,6 +2,8 @@
=C2=A0#ifndef _ASM_X86_SPARSEMEM_H
=C2=A0#define _ASM_X86_SPARSEMEM_H

+#include <linux/types.h>
+
=C2=A0#ifdef CONFIG_SPARSEMEM
=C2=A0/*
=C2=A0 * generic non-linear memory support:
--
2.36.0.rc2.479.g8af0fa9b8e-goog

--00000000000079773105dda2b5b6--