From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFAB6C7EE26 for ; Mon, 22 May 2023 08:41:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F201900003; Mon, 22 May 2023 04:41:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47C3A900002; Mon, 22 May 2023 04:41:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F3DD900003; Mon, 22 May 2023 04:41:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 199FE900002 for ; Mon, 22 May 2023 04:41:36 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C1C118074F for ; Mon, 22 May 2023 08:41:35 +0000 (UTC) X-FDA: 80817247350.10.75D0623 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by imf14.hostedemail.com (Postfix) with ESMTP id EC4D010000D for ; Mon, 22 May 2023 08:41:33 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=P7E1GPik; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of glider@google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684744894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WQPFzLEwac+E5AoIBX7hUXtHAL/mEVRDL3gEWHhERoM=; b=ekgawmXWsss9KBbOOVvguyWHgZ0kxKShHX1/BCVL09GTB/gprjcXetFdi29yXENIBpKt02 cvMOjG/rXEOR0tovHpAxLTdCy4yGqMLPT/eJoympWWk4+7pUmb94gH6ve8x1URJMMW68EC fBfrFl2LziWkVrY+c1Ixelkc0yimoRw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=P7E1GPik; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of glider@google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684744894; a=rsa-sha256; cv=none; b=kXDCaIQ0Vz+4Y1zlVMsiDadKAFO0eP7hBQYu8e0jws941sUpzxh5fkSJPCr2ls+ynHTqOU qRzi6Wx9eqD4vJO9owyO6bOedaZRDVarabUr/2I2Rt83lztFe2NhSxLvRS+8ci4e/OZdkm qL5eS4qO6an+kgzHSP+cwB+6zMr1Ews= Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-3f607dc98cdso1484655e9.1 for ; Mon, 22 May 2023 01:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684744892; x=1687336892; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WQPFzLEwac+E5AoIBX7hUXtHAL/mEVRDL3gEWHhERoM=; b=P7E1GPikLVt35N2MgYkkC6MJEueFa+/LwbcxXJ6JhTBmv3oTFGoIVnphyX67MGILnQ KcdrZVwfeaG0F/t8ms/2YSdc4i5dq1nzyD6m7IOiSc/P88Mt1SblJAUIsn5UiySv8G6h JVObu2ucqORbd9tjWDrfZy5mEJFS2UVrrgj2ldUWqmjHCZkf6LNrj7nTHEHFHHox/6W1 Ex4AC7Gao7i19lwq8W0S825VwWAbuyn/rA1ZDqPaYGcuOJ4qUFx3CN/S8cWXRjTrQ6Si 1e4ffhnivTT1fonDJa7ahEc77RkatBQW0lzGwtNT3RvE3K9JHlWEfAb3wYYdCB0F+RTb +BhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684744892; x=1687336892; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WQPFzLEwac+E5AoIBX7hUXtHAL/mEVRDL3gEWHhERoM=; b=cQbD+8j2J9ps4W1IAn0X9uk6QkmZ6+rploD45unX8nodpf0WKjFHHy7/GUonZqmH5y Ku8wnDMiEWenV3+NBIjmTklzTmAasx9fr9aQd/pYsOyD9Chy7ucgDxzh+SMtUrJem7aj 8hKpo71MbZHE+8YMzhBK9p2Ar4XN3q6SL8Rva/wtnDtxW414mErBlcedUD94l1XIYEaj b3ZGN4LSMwyeCq4K0f95/uzroKDUOBw012+pZMHmbD+YaQq8UgNzVyAzxIKPrtM5Kr97 P6+95mPo3FQu5ohMmb6oGJrJFtB2yqxWwjOYZN69u1+SR281PuPOGJnIPduVKJneps/U wh3w== X-Gm-Message-State: AC+VfDxTZnMzFQvb/a3s5V8aa4Yp0hAL0Pf6ud9gKEKCPCf4dhQoBveI f9k+U6IEsU3IV3u2D3sbIOvpnPakfkWYbe7Bmiz6Xg== X-Google-Smtp-Source: ACHHUZ5Av3kRe5PCmqrWW6oRTQaSgZDrHTgmfB1+0sby4qvFXFelR7YauVzomYRbNYZBgn7ZMPzGfu6P2RAsEWOUZGY= X-Received: by 2002:a1c:7315:0:b0:3f5:9ba:442d with SMTP id d21-20020a1c7315000000b003f509ba442dmr7273496wmb.33.1684744892238; Mon, 22 May 2023 01:41:32 -0700 (PDT) MIME-Version: 1.0 References: <20230516182537.3139-1-osalvador@suse.de> <20230516182537.3139-4-osalvador@suse.de> In-Reply-To: <20230516182537.3139-4-osalvador@suse.de> From: Alexander Potapenko Date: Mon, 22 May 2023 10:40:55 +0200 Message-ID: Subject: Re: [PATCH v5 3/3] mm,page_owner: Filter out stacks by a threshold counter To: Oscar Salvador Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Waiman Long , Suren Baghdasaryan , Marco Elver , Andrey Konovalov , Eric Dumazet Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: w5g6mahffm3bxq1qhzb3j4mbcpqpznau X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EC4D010000D X-HE-Tag: 1684744893-283557 X-HE-Meta: U2FsdGVkX1/o2/KupuMhKHrF5T0pnOkdiZpyoU1rBzt0nm1zm6eacs5EWuZEizhNalfD9SObE328JX2obgaKv0J7NnWV6IIkeRfQ121nGbZ0AM7MBbzI+PQst3axWIPUdDtKnXs1BsE6pNRNhhJDEAjiArPCF4d+Mm7dvNyZG+I1aOWm/1w9Dpd0SFVwyKAGtZxxSkLWajY0+QC921fwvxJtKLT6ssRa0CC6ZiE6W5RqTrhaRReMg8SH6JN1dK7W7HPTABobYP40brGivx4cC3cMhvuDbx7wlG7ozVFG7Veneym9CEMlabl76slPljM/37qPN3AptAyWY+NNsWP7LRhcmr2XIe9RjS3iWFjs3wA6PlDzYA1Aem2xxvMvA0JndDCvIZ4nFhNFAEHFTLpMv6zAZhaIye8f2sHEjX82L1ioyWvXDposLjqfRc0DijW+SY8pkyI/muIQNRZSIWVxOVZde2npWaVxOi0q43kRhX6g47KDr0nwccHX4biah5XigSmxS8APkSi8O0ZDuXnezP+KLvImhDTpjcBm18ms9SxhETHtT73tdkLJmawdGoVs0y0+aqRcvf/s2P69584ERdBZ1MXVGrx1hJChHcEscuUqwpVG4K1n04ac9lwrudgwaW+1+Jd2eXtrcsBZVC+LTwoUkEwD80PETMv8Po0EJh40ngSVXYczc96o011NVwgdoL+I6Mi/80DAHVHInlN8MgCUohLl1ZOV0XmGsEAgkMCxHPXtu8oJ9qDQ5s4jUrfWf7cjPhKutMFn0HH2lKRukQj9JTbfnRWb6YpxoXP9JJ+65OUlkn+WQ4jHUIOTuCwvpEFRZEv/YsBhg54nvUg/EI+8W7wIVnsnTw6xCo/esGZtBpMZo7qIwrUjO9MHzMgw+Ac6LO/O9wktCNYKZai329HLHktxaUjLxxne1ZIg9H49trsaCw8XVrtFJ6UaXyfVpGlFugC5qWQvmaC+8xZ gg/y2ycG wO1WKx4M8i0dcvH+M1aMN6ZJEP6NA8rEGdbj4ZQmB3zQGVlKZrLRy2YYOxGIrQJaf7HTZ6CHKKfi71JGaPe+u6mUvSOnHWBQgyIzBH/lB8bryKWqWsRLxlvPseV8hZK2GFRdyyx7I1/AT2eTMM0GZdroB19igZVVCAc09Potdh5DHF3sEjUeNmY3b9aIpWiS3+oSjSXRRaw3CJXgO71xhmV4VbLRovO7VoAD3vkPQH4Vz3pnMeMcLosNMTQtwylJuX3mlxZewCGyQmwFi+52DXnpKAL+xNQ1DT7kokRcUOSfH1PE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002809, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 16, 2023 at 8:25=E2=80=AFPM Oscar Salvador = wrote: > > We want to be able to filter out the output on a threshold basis, > in this way we can get rid of a lot of noise and focus only on those > stacks which have an allegedly high counter. > > We can control the threshold value by a new file called > 'page_owner_threshold', which is 0 by default. > > Signed-off-by: Oscar Salvador Nack. We must decouple stackdepot from page_owner as much as possible, not add extra dependencies by sharing variables between the two. What you need here is a pair of xxx_iter_start()/xxx_iter_next() functions in stackdepot.c that will hold the iteration state in a struct and return the next stack trace. The threshold value can also be part of that struct.