From: Alexander Potapenko <glider@google.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
Waiman Long <longman@redhat.com>,
Suren Baghdasaryan <surenb@google.com>,
Marco Elver <elver@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH v5 3/3] mm,page_owner: Filter out stacks by a threshold counter
Date: Mon, 22 May 2023 10:40:55 +0200 [thread overview]
Message-ID: <CAG_fn=UJgnLFGgpkXbMeD6axZN_ifEPHvWpy2_oiPyG1a6PXng@mail.gmail.com> (raw)
In-Reply-To: <20230516182537.3139-4-osalvador@suse.de>
On Tue, May 16, 2023 at 8:25 PM Oscar Salvador <osalvador@suse.de> wrote:
>
> We want to be able to filter out the output on a threshold basis,
> in this way we can get rid of a lot of noise and focus only on those
> stacks which have an allegedly high counter.
>
> We can control the threshold value by a new file called
> 'page_owner_threshold', which is 0 by default.
>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
Nack.
We must decouple stackdepot from page_owner as much as possible, not
add extra dependencies by sharing variables between the two.
What you need here is a pair of xxx_iter_start()/xxx_iter_next()
functions in stackdepot.c that will hold the iteration state in a
struct and return the next stack trace.
The threshold value can also be part of that struct.
next prev parent reply other threads:[~2023-05-22 8:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230516182537.3139-1-osalvador@suse.de>
2023-05-16 18:25 ` [PATCH v5 2/3] mm, page_owner: Add page_owner_stacks file to print out only stacks and their counte Oscar Salvador
2023-05-17 0:59 ` kernel test robot
2023-05-22 8:27 ` Alexander Potapenko
2023-05-16 18:25 ` [PATCH v5 3/3] mm,page_owner: Filter out stacks by a threshold counter Oscar Salvador
2023-05-22 8:40 ` Alexander Potapenko [this message]
2023-06-12 10:53 ` Vlastimil Babka
2023-05-16 21:12 ` [PATCH v5 0/3] page_owner: print stacks and their counter Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG_fn=UJgnLFGgpkXbMeD6axZN_ifEPHvWpy2_oiPyG1a6PXng@mail.gmail.com' \
--to=glider@google.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=edumazet@google.com \
--cc=elver@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox