From: Alexander Potapenko <glider@google.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Popov <alex.popov@linux.com>,
Quentin Casasnovas <quentin.casasnovas@oracle.com>,
Dmitriy Vyukov <dvyukov@google.com>,
Andrey Konovalov <andreyknvl@google.com>,
Kees Cook <keescook@chromium.org>,
Vegard Nossum <vegard.nossum@oracle.com>,
syzkaller <syzkaller@googlegroups.com>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] Makefile: support flag -fsanitizer-coverage=trace-cmp
Date: Wed, 11 Oct 2017 11:57:08 +0200 [thread overview]
Message-ID: <CAG_fn=UFQe7wrTcDxGAfi3Gr=JMjYDg_cRLxeDsxm508mR3yKg@mail.gmail.com> (raw)
In-Reply-To: <6184cd73-6d78-b490-3fdd-2d577ef033a6@virtuozzo.com>
On Tue, Oct 10, 2017 at 5:51 PM, Andrey Ryabinin
<aryabinin@virtuozzo.com> wrote:
>
>
> On 10/10/2017 06:27 PM, Alexander Potapenko wrote:
>>
>> v3: - Andrey Ryabinin's comments: reinstated scripts/Makefile.kcov
>> and moved CFLAGS_KCOV there, dropped CFLAGS_KCOV_COMPS
>
> Huh? Try again.
Reverted Makefile.lib in v4. Thanks!
>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>> index 5e975fee0f5b..7ddd5932c832 100644
>> --- a/scripts/Makefile.lib
>> +++ b/scripts/Makefile.lib
>> @@ -142,6 +142,12 @@ _c_flags += $(if $(patsubst n%,, \
>> $(CFLAGS_KCOV))
>> endif
>>
>> +ifeq ($(CONFIG_KCOV_ENABLE_COMPARISONS),y)
>> +_c_flags += $(if $(patsubst n%,, \
>> + $(KCOV_INSTRUMENT_$(basetarget).o)$(KCOV_INSTRUMENT)$(CONFIG_KCOV_INSTRUMENT_ALL)), \
>> + $(CFLAGS_KCOV_COMPS))
>> +endif
>> +
>> # If building the kernel in a separate objtree expand all occurrences
>> # of -Idir to -I$(srctree)/dir except for absolute paths (starting with '/').
>>
>>
--
Alexander Potapenko
Software Engineer
Google Germany GmbH
Erika-Mann-Straße, 33
80636 München
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-11 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 15:27 [PATCH v3 1/3] kcov: support comparison operands collection Alexander Potapenko
2017-10-10 15:27 ` [PATCH v3 2/3] Makefile: support flag -fsanitizer-coverage=trace-cmp Alexander Potapenko
2017-10-10 15:51 ` Andrey Ryabinin
2017-10-11 9:57 ` Alexander Potapenko [this message]
2017-10-10 15:27 ` [PATCH 3/3] kcov: update documentation Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG_fn=UFQe7wrTcDxGAfi3Gr=JMjYDg_cRLxeDsxm508mR3yKg@mail.gmail.com' \
--to=glider@google.com \
--cc=akpm@linux-foundation.org \
--cc=alex.popov@linux.com \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=quentin.casasnovas@oracle.com \
--cc=syzkaller@googlegroups.com \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox