From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03165C2BB85 for ; Tue, 18 Jun 2024 12:23:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FBEF6B009D; Tue, 18 Jun 2024 08:23:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4ABD86B00A0; Tue, 18 Jun 2024 08:23:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 373366B00A2; Tue, 18 Jun 2024 08:23:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 186996B009D for ; Tue, 18 Jun 2024 08:23:29 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 993711C162B for ; Tue, 18 Jun 2024 12:23:28 +0000 (UTC) X-FDA: 82243924896.19.F194C6E Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by imf17.hostedemail.com (Postfix) with ESMTP id BD7554001E for ; Tue, 18 Jun 2024 12:23:26 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qO0nME9e; spf=pass (imf17.hostedemail.com: domain of glider@google.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718713403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7r9377QHeRx4YGuRMxxudwYWoomRsoHVd1b1XjrAH4c=; b=JZLxsntTqI4LTLEd/iKVWf3g0WIEuMQ8j3vun64TkQEroh+ZD3yZKxPE89YSxfWXemRbiF oVUXEPTHtpHaxlt1Hd52vsFlBvBijAHGz/LnWNBQR9pfeBdUALFraQQn2lCJsIjlGAqys1 mSc3QdHw6qpI3qhrHnHSjh2xq2Hm0D0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qO0nME9e; spf=pass (imf17.hostedemail.com: domain of glider@google.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718713403; a=rsa-sha256; cv=none; b=Twlwkcy8K17ezuIvBszsK1MWo9k5MqbsAGe3p22Ap1mbNHOtQziUOHsOtJEQfqXpXil8QV eXd03ey6HLUHVDagUGBkOYJ2X7RMeHLYtG5c3jsylnQuAODrsZob/3hV9U3/kd+a0zF/uJ IpLJXINx+wNXHbWgWIDLngjHLpxGqOU= Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-62a087c3a92so51555887b3.2 for ; Tue, 18 Jun 2024 05:23:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718713406; x=1719318206; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7r9377QHeRx4YGuRMxxudwYWoomRsoHVd1b1XjrAH4c=; b=qO0nME9efpVP7sU2xaNFNTGppPderipAp202KlqCt7z2Q5liRhjuLMUqjwPQEoWhAT lT45IHfU+G4pshPeHGqhdo838/1NcI1Ul9P5FbrZoMDSj1jvqEfLova4AVbyg8ATTWLx j54Gwga+CSE5drKfY6bCKfutTwhUnr+vkXVF40ATPTNgUF7KEOv/kzt+jCttmkUhSI2z VGT9ymU/Cuk8ndQZZQTBRNv452pzbNGHMzfPUtJtLH5TWOEYXiFjXd/4PxyTaaZn4eV9 38JSYT8pAw4XJM+Ypfig4XqIr2r4SPP6aXSXFNAzx3PoxTM/6vYNSXj6LX1ZJMsrE/9v 49cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718713406; x=1719318206; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7r9377QHeRx4YGuRMxxudwYWoomRsoHVd1b1XjrAH4c=; b=PbeGVYcVjN5hYZgdqFH2fQXLs2ybTpRWwToJ8uFIIFrB2YIQb06NF5lWEWlQ7vw3kj QpTwG23ZDxKeKAFCh63WcgGGOee9dnXZ5Q9KvNILhUDnDPSV9WeAzImcGhEAw7dCU17Q 9D+ab/PoPPyByvna+jEiPJRdR47edFNWhwZr1JMo4IEkImMD482uLkjRdjmSFc/6eP27 lARfBQ0sEhYCmONwADarRV4/PgiUX7pR/ohHfsXbPZjl8nvr236iguDLEMYGTIQWUeZ5 KjRwnQJe45zn+quG4tinPOji8t17IE6hIHBUOHcCi56pZ/Dr+aI6gb0KpBhcydQ1ocU2 M5OA== X-Forwarded-Encrypted: i=1; AJvYcCWncqAbkla8Hw/cT2+0d0UqN6+PItLY0KOQ+OTPN9I8z9HJVLCV3V52m/jKJosvxhntZNYzkgXIlocndN+oVW2nV/4= X-Gm-Message-State: AOJu0YysXlXFfA0P0eTRUReqwATCKplHHlECnnE5mRHrm9eljUVcWh3Z nGsMjK+M5V6F4T8joOxQUjYUyU+09HzJyzfwhMKCKcm3Ew3YtzRt00IkEtKU0+CIe4Iby6mxOcu 8AjDoVmOd1h0sSJusgySzTBm+5hsLJHFf5Gb6 X-Google-Smtp-Source: AGHT+IGByXTFHMVNXIbwEPuEy6ECS8UlQ7NjRzqMyf5rOrRSa+3k76BSDfeXF6KiRmwBQfl6+NuPndA17rE7v9lMezs= X-Received: by 2002:a05:690c:6a09:b0:62c:f01a:17a3 with SMTP id 00721157ae682-63222a586e9mr136731667b3.15.1718713405543; Tue, 18 Jun 2024 05:23:25 -0700 (PDT) MIME-Version: 1.0 References: <20240613153924.961511-1-iii@linux.ibm.com> <20240613153924.961511-12-iii@linux.ibm.com> In-Reply-To: <20240613153924.961511-12-iii@linux.ibm.com> From: Alexander Potapenko Date: Tue, 18 Jun 2024 14:22:44 +0200 Message-ID: Subject: Re: [PATCH v4 11/35] kmsan: Allow disabling KMSAN checks for the current task To: Ilya Leoshkevich Cc: Alexander Gordeev , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka , Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: BD7554001E X-Stat-Signature: hpqb6mik7qjtppy6ztext1c3xqtrkjda X-HE-Tag: 1718713406-130101 X-HE-Meta: U2FsdGVkX19KMTs/bK7LDB1/6sTU6WaEYsjeMMdq9NZzIIT++8S5gESd444xrRXEYWTvbYYMIKpMcfJlnPFGdtXFUxLjBt2jLCjLWOjipu2gJP9xnWNpZVWVO2CIq36vBx4Z1WXLALuvfoT0+Aw/gPUPaQ2Ing9JzBMmwqUU2OLdAHoJmZ2re4IuQ2J787u3pkL1wrTp+3qKcVXff/B4zaNw29fDu1MJctt+l1LsRvAZDJVJ5mFkg+FWB6EnUgD1G45u/APP4yqGcOAm8Ll9/YpE20uGcj5XbBCYohCmOvLrua/8href9KgMH9q+AfnhP28R0/ZIBTGe9xGVcOi01a24gmvdCT9EJXyypfi4H8y8PEnqrqRwEJZ2zKi+D63Xad3pECw2MK4YT+txmvbd1a2UfMd5E+Mc5NNi0LNDBTXFrEEEytQMjJfoG8AL5Cu8DRwR1x0njsNQjWzFVJL5AyGOxJ3+SvD8mXbBpVZ+aEOBHXoU/ETFvSZvaox6tZS3M3J/dtuz/0e07VQu0RUP2zGSXwERspwxldCr10Nb2cIDLQ8rGtSJ12DnAq1qJZTjSWixeGHhFlLlrZl07sLNyt07N0XM/1FxRiJE0PUsmF2eBCgBOHrgd5xcsH2kYh94ttocFoylSWOVIPE8A0OR3RQ1FjHPbgjc0y2u/h13qKjSDK9UdonTcxHlxb6W8C4RHLGlqXAjdBk1RE5xlzASEIS8WAf5Ft/FHMr/UJ3akk4XGdtSaug2Rn91BJk2+l+QVWbT6UW3UdA6MCniP9pbASvuJinQMnPr5Yi19/TQ4IoZH5qlPKS19IUYmEWniz6OQfsjFTIXS3J9h77IHrBxOYBJCj8+pR03MsIpu8bfhjt5AFxUY5/n4mVaAwpZVvAnV0L9IBl3BZ8bYmp6m44oU8mm2WX69WnnbydMiE+No047aIlyQsx4g25YbAwNRI8jO+IN0A3jct3lr2EebVq 44Blxd+1 PI6ZFgHwBX3RWFWUR2oucZ7rSFybzUOPrLHoQY1pkZyNjyxjTesEd5uUE6lywYnv+LmkXCcqTlKAvmogysGCdffH5+XfAmQ1WTcHADgQ3SfLeUH/CYOWcMT34JJL5ns/T+l/VOFfS2BRcTu/Jhn9r4I5HsCXNq24qDxOogkvIuaQYz3hDoUjsuueE9dM5vowFHbxceM2W9lhVS777wJg8jf52DyKSIBVBUdNL8NbiuysgN+KT4E1QEFRLCvBcmzANG6aEZMIYFfSYZKVglsFZPuszLSWHQJXYRifv X-Bogosity: Ham, tests=bogofilter, spamicity=0.001498, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 13, 2024 at 5:39=E2=80=AFPM Ilya Leoshkevich wrote: > > Like for KASAN, it's useful to temporarily disable KMSAN checks around, > e.g., redzone accesses. Introduce kmsan_disable_current() and > kmsan_enable_current(), which are similar to their KASAN counterparts. > > Make them reentrant in order to handle memory allocations in interrupt > context. Repurpose the allow_reporting field for this. I am still a bit reluctant, because these nested counters always end up being inconsistent. But your patch series fixes support for SLUB_DEBUG, and I don't have better ideas how to do this. Could you please extend "Disabling the instrumentation" in kmsan.rst so that it explains the new enable/disable API? I think we should mention that the users need to be careful with it, keeping the regions short and preferring other ways to disable instrumentation, where possible. > Signed-off-by: Ilya Leoshkevich Reviewed-by: Alexander Potapenko