From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FA24C83F15 for ; Wed, 30 Aug 2023 07:41:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2051028003E; Wed, 30 Aug 2023 03:41:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B4F08E0009; Wed, 30 Aug 2023 03:41:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A49A28003E; Wed, 30 Aug 2023 03:41:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EAC3B8E0009 for ; Wed, 30 Aug 2023 03:41:58 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B5524C02DE for ; Wed, 30 Aug 2023 07:41:58 +0000 (UTC) X-FDA: 81179977116.14.900ED89 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by imf02.hostedemail.com (Postfix) with ESMTP id DEB578001B for ; Wed, 30 Aug 2023 07:41:56 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=KCJ8u8Eq; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of glider@google.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693381316; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kwOnzp96+NaUMFkX4e+N6heHm1OXXvklEEOWXELjx0E=; b=UqPUVnwT459W0hfmi/WeXNybRGCIk/aqrlLN/0WVIZvbBWUeVbuAmqaNLjQyIeswJx3Aob nicwzfD1TfKk0fOxiLPVkQPIHxZUiwOqSBiWKI4Hicg+3e2zFUwhRtCQS5miUQWF3+P6k6 U5ivEvvlfaRk+Sn49qjRRYxqNDuj/Hk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=KCJ8u8Eq; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of glider@google.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693381316; a=rsa-sha256; cv=none; b=eXQgkRO0ya6PpvFaICxqcGbqd7mZHh7o17NWYWtJnhMC8hH/Szdm+rX9HU1xA8DjRAmlgZ 2gnyuolD4MNFA0e27uJuqGWyZBm796jvsSM8zkQqM4shaBOZ7+PTTIDiLdh8fqhA96DyM0 rcoKCGJlV21eynEJp8b4XBT7RwsGsDo= Received: by mail-io1-f54.google.com with SMTP id ca18e2360f4ac-77ac14ff51bso169281139f.3 for ; Wed, 30 Aug 2023 00:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1693381316; x=1693986116; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kwOnzp96+NaUMFkX4e+N6heHm1OXXvklEEOWXELjx0E=; b=KCJ8u8EqekY0CjqtygesSEs8PhLj0A3qYDjIC4Kgt1rfRLQtmjCaes54e8vJSfaAng QfNQcsWsflf+/HgsKxSVoiVuUfMa2cNI/8A0Dxnfwvjx58r64gLGRL6Y/Vf4ZjPOSx72 DzUuvY03Ez5pbm6nLy/e9/thmubX/NS2ASCVgmLa73FQHm1aXXMsDBKjij5RC18swrj1 V5xMwNJfJCKPKctWbDjQ76MokmwTeNbxfiDhQt9pW/s2Y1POZBys383X81ZMmJ1VAr+I 9VxW7X29TtH6SJ6CV+d5w1aSH4TLii3v5NLmtupcmrPaOSX57GTlKcsBFBqq/k5xcvMZ S/bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693381316; x=1693986116; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kwOnzp96+NaUMFkX4e+N6heHm1OXXvklEEOWXELjx0E=; b=k26pTjU+294aDSmVvpxEMxW/WANMVdAvDCSA/vcoCSzUt7T0TVEeaai/YbTWvvuC8s hiE5P8iVNwhVo0FuGa1CS6BTugttZYtVCYgSYP9XWDbTz5/uXY4W1BTZkIQaCFKAbmEw sw/tzSWsPraMYQ7+Me2cGgxSq6XTpR/UB6j0OHFasznI7PAnWjsmTZJ0NXiVbyf3T98h oOnzX/8JnVASl8re+ZU3+qv533J8eNQnA1m3as2KliQcyCxvL3i8k+9PDUH+lVM9lt8F RrJv+xd+YTujgWt8cZFYtEcToLmo1/rqRlnIK0/WsTShdOeMoa746DCGmrjtsZM+MlcH zyUQ== X-Gm-Message-State: AOJu0YxfOk1rvKdD2WwcNOF57R7fC3AUnADHKIyQqgeKK0HCuUBr7WZj 5vD9d88iVPU54jDHgy29QvRgFslLRW7JjZOLPfe/NQ== X-Google-Smtp-Source: AGHT+IHnlH8T841/U7zxVM8rzI6aAaHgJzNBrhwH1VTR1KHTectxQpR+q8ReMBiLUaJN7OO5qlZqQA0EiGXPHuIwJdo= X-Received: by 2002:a5e:c91a:0:b0:783:7275:9c47 with SMTP id z26-20020a5ec91a000000b0078372759c47mr1716516iol.7.1693381316001; Wed, 30 Aug 2023 00:41:56 -0700 (PDT) MIME-Version: 1.0 References: <20dbc3376fccf2e7824482f56a75d6670bccd8ff.1693328501.git.andreyknvl@google.com> In-Reply-To: <20dbc3376fccf2e7824482f56a75d6670bccd8ff.1693328501.git.andreyknvl@google.com> From: Alexander Potapenko Date: Wed, 30 Aug 2023 09:41:19 +0200 Message-ID: Subject: Re: [PATCH 02/15] stackdepot: simplify __stack_depot_save To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: DEB578001B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: kcqgo6u3gpgy6mawk7s7tucwbmxsywzd X-HE-Tag: 1693381316-517340 X-HE-Meta: U2FsdGVkX19vs7FQKigjMwf0cYk1xbMV1qz9D/2ld5DF2C/MHKgVfYxRiW/fonM3XDzSODM67oW2cqQFIHYHgX8/8E9ZGZF72jHxwzU7wu0OYhoj7HUnu+qrs77mIvxqjD8yNsYyiIK6/2/ZbXvAEZ3i1gTr96sUcdpr+p3lMqfvuxzbgroXr9OYoFDWlqG7Pv6EgkqAaPwO2aMXM+HGbSFsicvHVC/luImxcOxr0qViuVMcVIqVN02NJ5BHAu5lfHkAHNfgtorz6FFvB96yY/VosWosYlau1vsBv4KXxxCV3VERRWRX6R3BrOZKyCCZlHknxc0mzV3mCJ3+n43fr0GwtP3N72bdIw9Js0kbXhSjPHRr7ij5i4AhqqpH6O9+Xa4QAq4BPJfUz0hQFd3yGEtSFGORegL8+haJQuKhCDGPTViBwUayOlsk4Bs7oMg8g393iRpmDQEj9bSWTMi3aawJfKO/JgeJRnNi50LCyrYxIjLschHn+2kUoQEhS7GueFsPuWXuvjy4SbF4jao8xZZ/IeBQBDLqjlxdhZlBPVEehJgka/t2h6+cDJSwg3MA+2HaDHSBHDCmFiP914E5LgWyUzV4lRbqGCBTpAApUrD6aorwcelEz/k93VGtzWU9QyXgEblsvaKh5yW3KbubyG08fwwqlN8qBUPf01taXAjUVugTv9e1kaLDH5wh+hM88UINZmsoLSQ9hCyyTZ5Q/UDtFvg5/pj4N+e32Jb/AhI6cM/ruxQe8y5LvNQne2WgOrn91vGBNmUJlo7V5wd90dv1jPyhE/T0EawnwlZoPWK/J3cG7YhQU/fE32/79Ik3kcp7L4xqUCzddnWmTHsrBJiv945qKuCgpJTy28nhXMQdXJbm3NNRHzgkPaPIW4T87dUwQ8gzz4FJoi+OrikfKK9JFvT/b8O3P+7TXG1ju25erUfEjPEmlUUXLPuiQADYDl3QpYeZPKrOXUoV02B tK0jCMVx aXV0115zmsJXF5eOdjf07msUbeht3h2GC7xzYpwMTTAdk7gLuev/3zSiV1VJ3sGZV4VEyajfuW5DcZnT1UNXH/GE+TMsBVKjGpjJzC2FwbHhT4piGuwfTl4n8ABOwXYeaFBG6sB8fdqRJuQzvMWPPbJpDSsv3fA77Zy1/HXp4KD1simNifkxvx5roU4MEx++PiBSDb0//mXPU7fZoukG8k6J0uYyYLnCQ157lKoyqqSaRWe30Ga6vOZMKfJAHrbaT+cif8m3UbLw1YDzDSPnZEF0AIOjJrA0TiFBQJn1BXw6Cx9a4c4/4qQM7x819CpvhoTJpmutc8fQOVcA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000145, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 29, 2023 at 7:11=E2=80=AFPM wrote: > > From: Andrey Konovalov > > The retval local variable in __stack_depot_save has the union type > handle_parts, but the function never uses anything but the union's > handle field. > > Define retval simply as depot_stack_handle_t to simplify the code. > > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko