From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B1BCE81E19 for ; Fri, 6 Oct 2023 16:15:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13DB88D00CE; Fri, 6 Oct 2023 12:15:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EE4D8D00C9; Fri, 6 Oct 2023 12:15:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED0328D00CE; Fri, 6 Oct 2023 12:15:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DB76D8D00C9 for ; Fri, 6 Oct 2023 12:15:39 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A8A0BA0190 for ; Fri, 6 Oct 2023 16:15:39 +0000 (UTC) X-FDA: 81315537198.20.91F3798 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by imf01.hostedemail.com (Postfix) with ESMTP id 993B140023 for ; Fri, 6 Oct 2023 16:15:37 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=UFl9xn4p; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of glider@google.com designates 209.85.219.42 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696608937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ai1VUkXPsadETq6pOE6a32ZLkIYlGlq9aDxrp9PEvE4=; b=W64YWfWDKpoY+8+n31kivas7lX04tfAFK/bgBZkBMfbCRe7Ojmo788Yk/jlGKrb5Wx1QhC R+qHLEOL3Fx4NUabo3H7pOhSd54T+GgvDkssT18JK6h+sPZRVukQqLnI0Gu5h3S9Fjjmol p1VWwIHPGJkv/Rav6kXTY+bRPGOBe7g= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=UFl9xn4p; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of glider@google.com designates 209.85.219.42 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696608937; a=rsa-sha256; cv=none; b=tQv0a/pnFG2hrf3xYbQngVU4hqjzQJbUOr8QIXwDKlnMqxQEtUUN7xjDjFcaPDY6+Ltino AavQmizzjD4FhalEBsLpgAZHB9oaAXFCJTfFokMMFCDY7ZeW3ONTjDxL1togKdrCeIh2Dt 6tC5gOWaU4M7txCehSBH4DaYMNDG83E= Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-65b0383f618so13091556d6.1 for ; Fri, 06 Oct 2023 09:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696608936; x=1697213736; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ai1VUkXPsadETq6pOE6a32ZLkIYlGlq9aDxrp9PEvE4=; b=UFl9xn4p+7aznMx/gX3djbp6Ok5CjljqVsxz6ZWEfeA0sNJldaFpgqSUcKeXBCaxvi EgikWM307n8CWB15LpTzhYYL1a8BKJfIvweiuLLhM3uq8nO8KxONu3Y+u+FuWuviFPR3 dFAFhUsrLGiq7NkDBX6ENrvJcIb2ibVEGWnR1KTgxWjhLGHDfM5TD8vkXV7dKd8WdifM A5r0tCQvYjQt17PqW3NRSmdFjY2psHMMq6+tgYFWLMCmePrD91M5h/3GG0Et+QPnXa1B 0qDbP+PAV/hDbTA0WoNmq62QIFTDzRRAe90W19yzfo43AIdZdpVMYtvk9HNn7m/yINhg vJcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696608936; x=1697213736; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ai1VUkXPsadETq6pOE6a32ZLkIYlGlq9aDxrp9PEvE4=; b=RspWpdhWFDhWo2RK8Sk/oJBHgT/PfTwIyYvFxdkG65LW7C9auOn1clEs1753ORTGlQ jyIViwTDsTySgh8WE3llysdwb4tipsHam3EKIaVnABA5CbgrWo7zv82VtSBYcSoEjOee p+YK6yuArIIgjV3KLUynTRlxY1i8sjWhhqNyya19TRpcHbTa4oY6AoYkhn4Lo6yv/pZf ECuoM5kwUyLjTAbLph2PYT5SrIOlUkquIW9XjR42QG3sP2vpSQxr3689oN+jif8XElgh eGHREmjI73emZ3NtE8rrkCIhsCr3XnzPEFJANJAX68ifp/ir2qefo1l7cX6vfAoFkUwf Snzw== X-Gm-Message-State: AOJu0YzARp4+N4yNIDAzs2Dw/iznrUwIcZB4vMm3SCLj7VnZ14vvMu6C dDzS/55UxhQ0l8QY3lrm+OF57Q5Fpu0lBe4qDf8UGg== X-Google-Smtp-Source: AGHT+IEx1r9T2vcKD7OU3CKGcePtixoTmdCamC4dHynLFAkpHGb+HrzdeTktZR9NJ/zM4r7N4H39UZ7z9KbKRitbBww= X-Received: by 2002:a05:6214:4285:b0:658:708c:4d56 with SMTP id og5-20020a056214428500b00658708c4d56mr8723713qvb.17.1696608936423; Fri, 06 Oct 2023 09:15:36 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Potapenko Date: Fri, 6 Oct 2023 18:14:56 +0200 Message-ID: Subject: Re: [PATCH v2 06/19] lib/stackdepot: fix and clean-up atomic annotations To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 993B140023 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: jko1wr76hatwpta9pextdfr1kmyd7mw1 X-HE-Tag: 1696608937-592638 X-HE-Meta: U2FsdGVkX18WBehBmnHoD/iW+Ojyl/SRZNuHMTokBHfehI2xaA4aCVxtzSrn2Jzl7rVvcF2D7eXvcN5l1IBNGjHN6l8kIp+hbYvJIzYuUxZvoN7ZYgIt1PNkWV3Ep+FZQSauq5N7X2qacG6qWywpfUHC0H45q8x8jOorELXJoYIEWpvJ+1Vl0kpTjdMS93ah12q9MZLztIyPr7dVqiz7KG8SKzUHsnZwzx/Ut9+Tf0dW8RUWrYgcFYGkoqVNUwQ08ZwRC5fW/mFRasa044Xc/CIbN1PWeSapWeQ9ClrCj5Rtq8N1PdomRR2rHWfOVeaYIE1ATiBGR8i7cjUxg9glNS7+Kfmnj2wO5G0lHUzCu7IDp48w3VhPpyuPp/QETH6QrSfdmAMD5gRLigmUng2pt1pSEVGmx5oppH00eP0s8nu4R7otQzUWybknFB9saxHBnhNA/R+qg2u9cbVIHNEmk7ne2czMd2dGQZaGxVS7vSk0jqHyjeO6gwCPfg6ULAuaqcn+3sZd8xcrpU8yLCaWIqAdMjGFw/ODudP6IFtn+QZs5WAUSNQy9Rl3DYuY7x6leV3a137SWEgCfq30mGR/NmOF1DQgr+yau729trCcBKJ3TguCZeTEPPJaAyxtkg33MvfhizDtjjZnXeGV6bb5taw9Fpl4XOGqhmdueR3O6hQ6vw8vfvjIHVHThGU8VrKQt2S8slRSL9n0GZGMUEPP3Ok9SUdzsq9Sv4A8YOCJFO53NpvlFsYP0bJ583StqwUwK1HnmIWxmjC6cqJjFc/lOCCzrBBznPlFMrRpcYvJsoRjD1i3lKHjf7OUCo9zMxTNctuKleMJ+16w5DxzmvtmL2iYC9u2EWcUKDTR3XgwsfsyHJQb7z03IXIPCIsZgz4MAktMWzGjD6TThf2QUw7SsHGqzZpcqHz9v/FDx2Ejupponp7VKpDz3wTBe93y+OD2puXYCNHRWSf5yYVE9c+ oNYwt5Wz w2xaY/ygJyqd5VZixmk4Ya5Iu1QGkFIj9X2PBiOXzSAtjKLotYfNW57QSmzEqzHrR6VdkqZp/EMJw3yvLuOFLsUQMhi1xcvVBjesa6p1doCW4nqO1hfnAk5Sr7q4im9Cn5nXTR//JKggR00owkryzQ501p+uIeiRsbAJWwHLgQXQz2wQw4W+0jIvyh9T2nQWVSMIa6cJ4vv4HxQIS3BMRBAZrM6ekqmrLdy//TCPlVDYnTOKlJ+kdVMiE2CwcCeLaHIlvk7OCrnAedyfZ3cNPYVqhx1bnrj3oGYbODoVhWtqst222858KsbS7Tg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.108618, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 13, 2023 at 7:15=E2=80=AFPM wrote: > > From: Andrey Konovalov > > Simplify comments accompanying the use of atomic accesses in the > stack depot code. > > Also drop smp_load_acquire from next_pool_required in depot_init_pool, > as both depot_init_pool and the all smp_store_release's to this variable > are executed under the stack depot lock. > > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko (but see below) > * Move on to the next pool. > * WRITE_ONCE pairs with potential concurrent read in > - * stack_depot_fetch(). > + * stack_depot_fetch. Why are you removing the parentheses here? kernel-doc uses them to tell functions from non-functions, and having them in non-doc comments sounds consistent.