From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0A9AC678D4 for ; Thu, 2 Mar 2023 14:28:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 656CE6B0074; Thu, 2 Mar 2023 09:28:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 606E96B0075; Thu, 2 Mar 2023 09:28:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CFBC6B0078; Thu, 2 Mar 2023 09:28:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3F10C6B0074 for ; Thu, 2 Mar 2023 09:28:27 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1F8DDC0627 for ; Thu, 2 Mar 2023 14:28:27 +0000 (UTC) X-FDA: 80524188654.24.C8B8329 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by imf18.hostedemail.com (Postfix) with ESMTP id 643B51C0013 for ; Thu, 2 Mar 2023 14:28:24 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=jOnksMU1; spf=pass (imf18.hostedemail.com: domain of glider@google.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677767304; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7xMPcWX9J82fx546/2/UxZ96PyLg7wpVPFiDqKOfZ5I=; b=WYCH5QMv6u41eD0vUSLXqGQ+dwoVVpHCmeTYXecL1sfVv79QudGI7egv1d1NmpL4UbRykM itfAq1M2r0mT7tsYOOAAfKqG8YcHvfIZR50rn7LjIMMs//YcNpSV4SB+Nowo0/se1Z0dvX 5YJG1vBCDO/HU1uRKjsUc4K2H7VF7DQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=jOnksMU1; spf=pass (imf18.hostedemail.com: domain of glider@google.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677767304; a=rsa-sha256; cv=none; b=ep1hReGPMGLRuyIP1XAkRCEKiThy8cIkRVaH2eWKNlrjFX1fnDklcDty1y2UH6LVA750EL cPvk5wUIFVPi98pZnStFu9Sq+heHMilX4es/T7v5mp6XxUtDNgZ/twx26Ot2ZSEiO7i5f7 iMVUWj8o1wMut+tGFRwieuh0PWeZU6A= Received: by mail-io1-f54.google.com with SMTP id b16so6780786iof.11 for ; Thu, 02 Mar 2023 06:28:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7xMPcWX9J82fx546/2/UxZ96PyLg7wpVPFiDqKOfZ5I=; b=jOnksMU1dAwsE3ClLTB+Su7tMpzibSIW2s5mk8JhpXwjpAGuf+ol/j0wDpAOgpI00D RJDsK6iqB2fblNnA2kwcG4VbYRLJe7eIma9voxpT5WWyJhNlqVF/hrbmgHIs0GmBEYse uTB0ZrozIke7tGkwFd8p103W1GuVQtmvVZwBCfU5371hanm78mjpsiFOBecBTs0JEvMF /7JvJGybKX9df0nqxtfbeAUUFvnNexvoFWksmdJlKuid/oTfQsHCnneBU5H6M1rKH8wI iASdynbwx2juptR2fyKyCcA4MLxXHIT19zrLvUI6I6LN4fw/Nur7W+kp5ODkAwUouHHl AGCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7xMPcWX9J82fx546/2/UxZ96PyLg7wpVPFiDqKOfZ5I=; b=OT4jTmKEhnyhD15+Sv/fWPzDEtHh5zku7sHIQrPxKM71eE+6sPkiVfirfRRFMK/nbF HNW5yhblFkMQXXHZjRMtyZTyur4FTsl44jHJ/8sx1qC7C/qFRYFMsQOX2gNua2WWTh0E upuUefsCOia1aKrv/zEKONuMh5+GvS3lYQT1XRSztI2mJhf4Cb8yJv3iO2895PRCvzR4 dCHYNrB7oM4ewctBGgc8+eMMSRn4vquCsGcSsEhrR/LFbi9UmfMEwZvtOxvn3eqJY7Nn /qTso0xYKo6PqFGBwcwPzy1chaQ2Wu1XTR1R0NvTWvaTK7hUdmz+clPtE1O6wV/XflxZ At9g== X-Gm-Message-State: AO0yUKWfOqMiuZi6GJNZmkO8F4fCJBEx7Jh5veUWPM9LPW0B4g7wJTpn m0DOD23CdkEluIw3IBzIXler7LkPx2pTyBsQrtql4w== X-Google-Smtp-Source: AK7set//gciEjOc7e7//kyU0zcBwX8c6ckX6I0Bc10xXTnFRq6UmSVxHBK5CCpixAHyAa5oOsh3vkJjUuyaod5TRtPA= X-Received: by 2002:a6b:7c09:0:b0:745:6788:149f with SMTP id m9-20020a6b7c09000000b007456788149fmr4528404iok.0.1677767303478; Thu, 02 Mar 2023 06:28:23 -0800 (PST) MIME-Version: 1.0 References: <20230301143933.2374658-1-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Thu, 2 Mar 2023 15:27:47 +0100 Message-ID: Subject: Re: [PATCH 1/4] x86: kmsan: Don't rename memintrinsics in uninstrumented files To: Marco Elver Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, dave.hansen@linux.intel.com, hpa@zytor.com, akpm@linux-foundation.org, dvyukov@google.com, nathan@kernel.org, ndesaulniers@google.com, kasan-dev@googlegroups.com, Kees Cook Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: wxhp6zfcjmhaiqjyhq1hpkppet9uf993 X-Rspamd-Queue-Id: 643B51C0013 X-HE-Tag: 1677767304-854675 X-HE-Meta: U2FsdGVkX19v3BVKvaEtjLthVPP834NBVVCtO3iDiRwuM1KfDmKkNSU0FyWvyUnlvxlF+pPn+QV0pv1GiajHzSd5jIt0Nx5wdha+oguUqA3/0QZC25qfdYS/QzDtDXKI0qjXRWHRRbeBYhzA8vVW8waLD8gzotD4M5KlmuzGcH7d5r9X9cEpq6DYG3gc1XO592q3yCxVxjyQmv8TA5sYM37wQK9ALFND4AS6/cDkZE/tsTE6tF4b/3aMOiUC5nTbIo0YBpq+a2lPTV1t1mkAg1M++E42xMVNWVIQgT0huMINcRhDcVH+VG/FpU2JRBR6Y5NjAX2ivN31RfO5xYDcY23wG/3vdUvHs07LBLKQnG8FeFXg7YfAzvtL0dEwoSAqTYeC0yqD7TlgpvqX0scmo0abiZJUNBHOvHI5LNSg0duXmbyuiz2MCU2IOqBV57giNIrdYHcgrlU4ICJk/qH9b9SY7PEmiuW7U9yHlHWx75fQRel2Bmz+c1JsZx6aXy0DKThgyxX2X4QkqejvWtn2lWnY8+KmeuAUmstVLe25cCEvAN6f2tEZ9JQEJU7eKmoyPOKVzwChus0RGoGSidhJLIk6zYeIzMuGoKl4+hyAVD1PwsAlSngW5o+1pNGcvRAqSjl48k1kDjPA/4WdmjbV35ZA/OO2pnKslHySAd78mRGWij4aa9KzzcchJPR6cQQgj30avJRTxVu9dy3H9bqjmok7Nwp3MjAvqRm4o3aP1v934Fi+eXXTzk6u4h6KGcmS0hdPdFRutOTwPW4u/xYdxm9xU3D5HowO38VzUiJEZqqs/vgirn19hqfRiL9FXW/z0Tw/CQohmnoBkTSc4CUKfwHgNon4d9tFqV3AGkpMCx8J5Zi2dk+SR04jwTiOT0VlAQ/C6RrIRlMSZBE1QCnHefGKOvvkZIlafDuM6ym1roEL8NwG+4Qg6uY8FmO/7jZWzVBcpMa/WKcS2s4HjXO B4RtZ4FD EB6yC8RS08JTnQFtY9VdEToiIR0bUUeQw6YIAbYF8/YXpgcZC9r7SLQ3DhOWAXLxvtSMJ1EeFupFLnMhtYf+WMUB6opxR8yjBXEWC7fMEhXIzpia6Xa/6gblx0HVqHCt5T7hXjWXelSzDJLO+W4AhAcgEVUFEHGYO/5f51cxNAbAf6O3MaE9s0UzeMFYHIS2BmhQVwhY5g3pqH1eEK99sbzvvIs5sKmGw5ob8Vc4kqj3J1hB0cv6ikHC64asE+cG3O5fhzl35caiZrvGcNnqLoDoolh7lHabTOq3yJMpO17oYiNg9pkNQpU0RXrdkyOGTXswVgvcAU3U85Sw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 2, 2023 at 12:14=E2=80=AFPM Marco Elver wrot= e: > > On Wed, 1 Mar 2023 at 15:39, Alexander Potapenko wrot= e: > > > > KMSAN should be overriding calls to memset/memcpy/memmove and their > > You mean that the compiler will override calls? > All supported compilers that have fsanitize=3Dkernel-memory replace > memintrinsics with __msan_mem*() calls, right? Right. Changed to: KMSAN already replaces calls to to memset/memcpy/memmove and their __builtin_ versions with __msan_memset/__msan_memcpy/__msan_memmove in instrumented files, so there is no need to override them. > > > __builtin_ versions in instrumented files, so there is no need to > > override them. In non-instrumented versions we are now required to > > leave memset() and friends intact, so we cannot replace them with > > __msan_XXX() functions. > > > > Cc: Kees Cook > > Suggested-by: Marco Elver > > Signed-off-by: Alexander Potapenko > > Other than that, > > Reviewed-by: Marco Elver Thanks!