From: Alexander Potapenko <glider@google.com>
To: Ethan Graham <ethan.w.s.graham@gmail.com>
Cc: ethangraham@google.com, andreyknvl@gmail.com,
brendan.higgins@linux.dev, davidgow@google.com,
dvyukov@google.com, jannh@google.com, elver@google.com,
rmoar@google.com, shuah@kernel.org, tarasmadan@google.com,
kasan-dev@googlegroups.com, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
dhowells@redhat.com, lukas@wunner.de, ignat@cloudflare.com,
herbert@gondor.apana.org.au, davem@davemloft.net,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2 RFC 2/7] kfuzztest: add user-facing API and data structures
Date: Wed, 3 Sep 2025 13:35:41 +0200 [thread overview]
Message-ID: <CAG_fn=U+xi3zjr+g+PaT_41JHSca1W6J72xd5=c0dVrSy75XpA@mail.gmail.com> (raw)
In-Reply-To: <20250901164212.460229-3-ethan.w.s.graham@gmail.com>
> + static ssize_t kfuzztest_write_cb_##test_name(struct file *filp, const char __user *buf, size_t len, \
> + loff_t *off) \
> + { \
> + test_arg_type *arg; \
> + void *buffer; \
> + int ret; \
> + \
> + buffer = kmalloc(len, GFP_KERNEL); \
> + if (!buffer) \
> + return -ENOMEM; \
> + ret = simple_write_to_buffer(buffer, len, off, buf, len); \
> + if (ret < 0) \
> + goto out; \
> + ret = kfuzztest_parse_and_relocate(buffer, len, (void **)&arg); \
> + if (ret < 0) \
> + goto out; \
> + kfuzztest_logic_##test_name(arg); \
> + ret = len; \
> +out: \
> + kfree(buffer); \
> + return ret; \
> + } \
> + static void kfuzztest_logic_##test_name(test_arg_type *arg)
simple_write_to_buffer() may write less than len bytes if it hits a
protected page.
You should check that `ret == len` and return -EFAULT if they differ.
next prev parent reply other threads:[~2025-09-03 11:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 16:42 [PATCH v2 RFC 0/7] KFuzzTest: a new kernel fuzzing framework Ethan Graham
2025-09-01 16:42 ` [PATCH v2 RFC 1/7] mm/kasan: implement kasan_poison_range Ethan Graham
2025-09-05 8:32 ` Alexander Potapenko
2025-09-05 8:46 ` Ethan Graham
2025-09-05 9:32 ` Alexander Potapenko
2025-09-01 16:42 ` [PATCH v2 RFC 2/7] kfuzztest: add user-facing API and data structures Ethan Graham
2025-09-02 10:37 ` Marco Elver
2025-09-03 8:40 ` Alexander Potapenko
2025-09-03 10:15 ` Alexander Potapenko
2025-09-03 11:35 ` Alexander Potapenko [this message]
2025-09-01 16:42 ` [PATCH v2 RFC 3/7] kfuzztest: implement core module and input processing Ethan Graham
2025-09-03 9:53 ` Alexander Potapenko
2025-09-01 16:42 ` [PATCH v2 RFC 4/7] tools: add kfuzztest-bridge utility Ethan Graham
2025-09-03 14:07 ` Alexander Potapenko
2025-09-05 10:43 ` Alexander Potapenko
2025-09-01 16:42 ` [PATCH v2 RFC 5/7] kfuzztest: add ReST documentation Ethan Graham
2025-09-04 8:53 ` Alexander Potapenko
2025-09-01 16:42 ` [PATCH v2 RFC 6/7] kfuzztest: add KFuzzTest sample fuzz targets Ethan Graham
2025-09-04 9:59 ` Alexander Potapenko
2025-09-01 16:42 ` [PATCH v2 RFC 7/7] crypto: implement KFuzzTest targets for PKCS7 and RSA parsing Ethan Graham
2025-09-03 8:58 ` Ignat Korchagin
2025-09-04 20:20 ` Ethan Graham
2025-09-04 9:11 ` [PATCH v2 RFC 0/7] KFuzzTest: a new kernel fuzzing framework David Gow
2025-09-04 20:08 ` Ethan Graham
2025-09-08 13:11 ` Johannes Berg
2025-09-10 10:40 ` Alexander Potapenko
2025-09-10 15:59 ` Johannes Berg
2025-09-11 13:59 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG_fn=U+xi3zjr+g+PaT_41JHSca1W6J72xd5=c0dVrSy75XpA@mail.gmail.com' \
--to=glider@google.com \
--cc=andreyknvl@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=davem@davemloft.net \
--cc=davidgow@google.com \
--cc=dhowells@redhat.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=ethan.w.s.graham@gmail.com \
--cc=ethangraham@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=ignat@cloudflare.com \
--cc=jannh@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lukas@wunner.de \
--cc=rmoar@google.com \
--cc=shuah@kernel.org \
--cc=tarasmadan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox