From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
Received: from mail-wm0-f72.google.com (mail-wm0-f72.google.com [74.125.82.72])
	by kanga.kvack.org (Postfix) with ESMTP id D01F66B0038
	for <linux-mm@kvack.org>; Tue,  4 Oct 2016 12:54:14 -0400 (EDT)
Received: by mail-wm0-f72.google.com with SMTP id b80so14562241wme.1
        for <linux-mm@kvack.org>; Tue, 04 Oct 2016 09:54:14 -0700 (PDT)
Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com. [2a00:1450:400c:c09::22b])
        by mx.google.com with ESMTPS id cj2si5569175wjc.184.2016.10.04.09.54.13
        for <linux-mm@kvack.org>
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Tue, 04 Oct 2016 09:54:13 -0700 (PDT)
Received: by mail-wm0-x22b.google.com with SMTP id f193so26671262wmg.0
        for <linux-mm@kvack.org>; Tue, 04 Oct 2016 09:54:13 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <877f9p55lu.fsf@concordia.ellerman.id.au>
References: <20161003161322.3835-1-dvlasenk@redhat.com> <CAGXu5j+haCUW_AEPLPcVGtrnv4ojQ79FDpspUurYJSX_-TXeow@mail.gmail.com>
 <877f9p55lu.fsf@concordia.ellerman.id.au>
From: Kees Cook <keescook@chromium.org>
Date: Tue, 4 Oct 2016 09:54:12 -0700
Message-ID: <CAGXu5jJ3PpvNBYyBWa_M8ELLPuJOcJt-KuH0uRK66peJM_CnSg@mail.gmail.com>
Subject: Re: [PATCH v6] powerpc: Do not make the entire heap executable
Content-Type: text/plain; charset=UTF-8
Sender: owner-linux-mm@kvack.org
List-ID: <linux-mm.kvack.org>
To: Michael Ellerman <mpe@ellerman.id.au>, Andrew Morton <akpm@linux-foundation.org>
Cc: Denys Vlasenko <dvlasenk@redhat.com>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>, Jason Gunthorpe <jgunthorpe@obsidianresearch.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, Oleg Nesterov <oleg@redhat.com>, Florian Weimer <fweimer@redhat.com>, Linux-MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>

On Mon, Oct 3, 2016 at 5:18 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> Kees Cook <keescook@chromium.org> writes:
>
>> On Mon, Oct 3, 2016 at 9:13 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
>>> On 32-bit powerpc the ELF PLT sections of binaries (built with --bss-plt,
>>> or with a toolchain which defaults to it) look like this:
> ...
>>>
>>> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
>>> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
>>> Acked-by: Kees Cook <keescook@chromium.org>
>>> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
>>> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>>> CC: Paul Mackerras <paulus@samba.org>
>>> CC: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>>> CC: Kees Cook <keescook@chromium.org>
>>> CC: Oleg Nesterov <oleg@redhat.com>
>>> CC: Michael Ellerman <mpe@ellerman.id.au>
>>> CC: Florian Weimer <fweimer@redhat.com>
>>> CC: linux-mm@kvack.org
>>> CC: linuxppc-dev@lists.ozlabs.org
>>> CC: linux-kernel@vger.kernel.org
>>> ---
>>> Changes since v5:
>>> * made do_brk_flags() error out if any bits other than VM_EXEC are set.
>>>   (Kees Cook: "With this, I'd be happy to Ack.")
>>>   See https://patchwork.ozlabs.org/patch/661595/
>>
>> Excellent, thanks for the v6! Should this go via the ppc tree or the -mm tree?
>
> -mm would be best, given the diffstat I think it's less likely to
>  conflict if it goes via -mm.

Okay, excellent. Andrew, do you have this already in email? I think
you weren't on the explicit CC from the v6...

-Kees

-- 
Kees Cook
Nexus Security

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>