From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f176.google.com (mail-io0-f176.google.com [209.85.223.176]) by kanga.kvack.org (Postfix) with ESMTP id 79F496B0263 for ; Wed, 18 Nov 2015 18:26:34 -0500 (EST) Received: by ioir85 with SMTP id r85so71391465ioi.1 for ; Wed, 18 Nov 2015 15:26:34 -0800 (PST) Received: from mail-ig0-x22a.google.com (mail-ig0-x22a.google.com. [2607:f8b0:4001:c05::22a]) by mx.google.com with ESMTPS id x9si8007483igl.12.2015.11.18.15.26.34 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Nov 2015 15:26:34 -0800 (PST) Received: by igbxm8 with SMTP id xm8so51119747igb.1 for ; Wed, 18 Nov 2015 15:26:34 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <564D088E.7060409@android.com> References: <1447886901-26098-1-git-send-email-dcashman@android.com> <1447886901-26098-2-git-send-email-dcashman@android.com> <564D088E.7060409@android.com> Date: Wed, 18 Nov 2015 15:26:33 -0800 Message-ID: Subject: Re: [PATCH 1/4] mm: mmap: Add new /proc tunable for mmap_base ASLR. From: Kees Cook Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Daniel Cashman Cc: LKML , Russell King - ARM Linux , Andrew Morton , Ingo Molnar , "linux-arm-kernel@lists.infradead.org" , Jonathan Corbet , Don Zickus , "Eric W. Biederman" , Heinrich Schuchardt , jpoimboe@redhat.com, "Kirill A. Shutemov" , n-horiguchi@ah.jp.nec.com, Andrea Arcangeli , Mel Gorman , Thomas Gleixner , David Rientjes , Linux-MM , "linux-doc@vger.kernel.org" , Mark Salyzyn , Jeffrey Vander Stoep , Nick Kralevich , Catalin Marinas , Will Deacon , "H. Peter Anvin" , "x86@kernel.org" , Hector Marco , Borislav Petkov , Daniel Cashman On Wed, Nov 18, 2015 at 3:23 PM, Daniel Cashman wrote: >> I think the min/max values should be const, since they're determined >> at build time and should never change. > > Ok. Also, I just submitted the patch-set again with [PATCH v3] instead > of [PATCH] so I'd prefer discussion there; sorry for the mistake. Oops, yeah, just saw that come in after I already sent my comments. :P -Kees -- Kees Cook Chrome OS Security -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org