From: Kees Cook <keescook@chromium.org>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: Thomas Garnier <thgarnie@google.com>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Thelen <gthelen@google.com>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
Laura Abbott <labbott@fedoraproject.org>
Subject: Re: [RFC v1] mm: SLAB freelist randomization
Date: Thu, 7 Apr 2016 19:31:52 -0700 [thread overview]
Message-ID: <CAGXu5j+4AJ_TMKus=bwWdK9+xBgWF44gHxcu5Bagw5ApB3Eg0A@mail.gmail.com> (raw)
In-Reply-To: <20160407231413.53e371ff@redhat.com>
On Thu, Apr 7, 2016 at 2:14 PM, Jesper Dangaard Brouer
<brouer@redhat.com> wrote:
>
> On Wed, 6 Apr 2016 14:45:30 -0700 Kees Cook <keescook@chromium.org> wrote:
>
>> On Wed, Apr 6, 2016 at 12:35 PM, Thomas Garnier <thgarnie@google.com> wrote:
> [...]
>> > re-used on slab creation for performance.
>>
>> I'd like to see some benchmark results for this so the Kconfig can
>> include the performance characteristics. I recommend using hackbench
>> and kernel build times with a before/after comparison.
>>
>
> It looks like it only happens on init, right? (Thus must bench tools
> might not be the right choice).
Oh! Yes, you're right. I entirely missed that detail. :) 0-cost
randomization! Sounds good to me. :)
-Kees
>
> My slab tools for benchmarking the fastpath is here:
> https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/mm/slab_bulk_test01.c
>
> And I also carry a version of Christoph's slab bench tool:
> https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/mm/slab_test.c
>
> --
> Best regards,
> Jesper Dangaard Brouer
> MSc.CS, Principal Kernel Engineer at Red Hat
> Author of http://www.iptv-analyzer.org
> LinkedIn: http://www.linkedin.com/in/brouer
--
Kees Cook
Chrome OS & Brillo Security
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-04-08 2:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 19:35 Thomas Garnier
2016-04-06 20:54 ` [kernel-hardening] " Greg KH
2016-04-06 21:03 ` Thomas Garnier
2016-04-06 21:45 ` Kees Cook
2016-04-07 15:28 ` Thomas Garnier
2016-04-07 16:17 ` [kernel-hardening] " Yves-Alexis Perez
2016-04-07 16:35 ` Thomas Garnier
2016-04-07 21:14 ` Jesper Dangaard Brouer
2016-04-08 2:31 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5j+4AJ_TMKus=bwWdK9+xBgWF44gHxcu5Bagw5ApB3Eg0A@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=brouer@redhat.com \
--cc=cl@linux.com \
--cc=gthelen@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=labbott@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=thgarnie@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox