From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A395C47258 for ; Fri, 26 Jan 2024 01:14:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 006AD6B0089; Thu, 25 Jan 2024 20:14:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF9366B008A; Thu, 25 Jan 2024 20:14:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC13C6B008C; Thu, 25 Jan 2024 20:14:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CC2906B0089 for ; Thu, 25 Jan 2024 20:14:45 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 980C2120290 for ; Fri, 26 Jan 2024 01:14:45 +0000 (UTC) X-FDA: 81719692530.14.5D30188 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf21.hostedemail.com (Postfix) with ESMTP id CD9A51C0012 for ; Fri, 26 Jan 2024 01:14:43 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lRhYXtGU; spf=pass (imf21.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706231683; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wppqGuChQbSUaLQ8QL8b8yX5LarATJPM1jUq1EFE/D4=; b=mNVOs+yUArKHPl57rXJ2R8CeKIuH34h+d6C3IPFBbDWa4ALMo/bWnkinDgZhnKLQoHgg5V 9Abw9aK+RyQ2aTYmrDMgiIc5g1cZMJqQlfbjJFWhg7ZEFQwSqxNvJB579crNcD++A4pHL4 fb6yHMwVr49sLOb5YOHLCSzCEFonxVE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706231683; a=rsa-sha256; cv=none; b=hz+c485vCKuRdjZ9ImQlTF4qLhvEXMJvlMLsKrxaLrLWRNsZblSHRC9JlxHcQp/kMEP8y3 Px6yIZko6zpDsekB3rnUGJv37XWBKB5qFVQpXeUmi5kXImsOk19HuccmSvMEV1BNPV7CGo PQo/pnadQqbJvv3OrjwKYiqapr9kJBU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lRhYXtGU; spf=pass (imf21.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2cf3a04ea1cso17057711fa.2 for ; Thu, 25 Jan 2024 17:14:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706231682; x=1706836482; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wppqGuChQbSUaLQ8QL8b8yX5LarATJPM1jUq1EFE/D4=; b=lRhYXtGUkRMMTs4Itt9rsLnoIFv++3+NhV8RBu430RXPwqWWwUmBX5bY+tPsS7uOi6 k0NVnOhLXvJ7kYu/f+xhfhsQkS8btM6G1qSvRQITLKg9f41BJRzfNod6v4IRgJNhdyNC pTMLebx0vAYkp+8lSIEXRDOrGI5VN6jCzQNCwmxOMpEH7LC1FsKhzJp9xUIm0HztVxKH rQMZx+YMGeDFAOVPp8IZiksqKjJ4t1WCaS6VyMuZ7UqtJK5km1xeRloTXohwccGlJ0PJ ctIah7wjXiGpU+n2b8sq/Kr08c/Em9y+d2PNBPXdC/7T2jW4kbfnzmvJgwENDgGDImhr h9Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706231682; x=1706836482; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wppqGuChQbSUaLQ8QL8b8yX5LarATJPM1jUq1EFE/D4=; b=FdiaLZBoVDhI97Htq2OLRKRCELWu1h0GkYOsHq8oQ5Lfxe+D5FUSY1gB6dvpSP3fMi hpTeuNIW+49l0zhuKJkihowfiJZ9GqMjA0FarWrKZ/F6xsyUhVQAKRIqQGy+XzOxUBdW sGiQjJgA8gz4ssXuhap+AYRaSGZWA8r3Tsx5dNVPaxwz89osvuwV9yNAUnnb38CDBnCV ws8+z0WHW/IX5mNkbd+wMNTfCk92DcdMf3gAr5ad8BR7y/n+aJRj+jNmsstCqcFgjtmr JKft65vp47MZwD2VOWH1ly9wmf6G1/ad9xbg/QcP/qdDTRWcoCytUlL8t8kc8e9hk2nE ezjw== X-Gm-Message-State: AOJu0Yxwy23rAmb2hor9pC0A8RPwfFRgc79GKNBMxE1uMdR/Iv+GVZgq 9TSYPdyTzx1sM30lYsKZeeIeUkBt6lAjSS8xK1yrOEbt45lI2+tAWACj4LZtnN7ukls9Q7raWtN xrsQoBLWoBfNiQoLQUxxh+TO10gY= X-Google-Smtp-Source: AGHT+IGqBgKBURdVBKk6O/LPAZfFF7s0fMgud8iwQ9gos3lcZ5/ojQb3dHCHIg7xdrF9moKGDhfZhKBR4ARF3KP9x64= X-Received: by 2002:a05:651c:794:b0:2ce:93b:ba6e with SMTP id g20-20020a05651c079400b002ce093bba6emr244626lje.85.1706231681456; Thu, 25 Jan 2024 17:14:41 -0800 (PST) MIME-Version: 1.0 References: <20240125071901.3223188-1-zhaoyang.huang@unisoc.com> <6b2d5694-f802-43a4-a0fd-1c8e34f8e69a@kernel.org> <95082224-a61d-4f4b-bc96-1beea8aa93a9@kernel.org> <15d07953-aeff-460e-81fe-ea7fc2f6145d@kernel.org> In-Reply-To: From: Zhaoyang Huang Date: Fri, 26 Jan 2024 09:14:30 +0800 Message-ID: Subject: Re: [PATCHv3 1/1] block: introduce content activity based ioprio To: Damien Le Moal Cc: "zhaoyang.huang" , Andrew Morton , Jens Axboe , Yu Zhao , Niklas Cassel , "Martin K . Petersen" , Hannes Reinecke , Linus Walleij , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, steve.kang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: CD9A51C0012 X-Rspam-User: X-Stat-Signature: 45m7mfr83kn339yyg391ci8u6hw9gfcn X-Rspamd-Server: rspam03 X-HE-Tag: 1706231683-264651 X-HE-Meta: U2FsdGVkX1/7Tzf9W4Q8muX+BUSTB+JJCWmOtetJxJIAWJhhl5pmUp+Wq61tQdH1ZN+3gXRnrh0JGOYHF0m0bnmcYFSA095jUEimlEe8mwpZUIiRiOhSgX2vE4ASmXoFKrjLzoDR4SmxvFAuwQ/Jdji/iapFxmD93U8FvwMw/5i7xm0w9YLmySzWtP0nsy5jzBUwHwbOlVC1ojcvFNk4/Lad8qdgKZ1RJh6lJgZufxquS63GD3lCFLTBeTvNEbUG+qmDeMhdJxKQwTjp0SfalW7ImGnxFKm6LLYreEpyS1eftM5xeATVQOEeowB9r7KU3SCHRUaMfUfLGvLGzUiQ8o6EzqYF7c+xinIPFtKJUQYNAyfMJRLAw2tqndgdtpj8uuP9LMJR+/ZRHgtlO1Xi+7Cn2cGKw0aaRc9DMoPDmdRhsQMb+pkEs5AKixCJbrvfSrH5vO7ERFA7AYhfKDh/k7XBrX307OHqfxYJEHNU3FPnE9tL82d6/eXH6NihLP1F+Pxgel44PCtRqcHfhBUiY8we3UvafLGky4YpTwLNapT6F9OAzOz0dn5SmejUTrh0O/mp1QMY4m0mysR/3WYOsiOsMcHN4D5puhG8WOgU+K71Ub/zFUSnZ64wsewB0p4DBIt/Udft8rjPERUK9Nxrui9xnw45hJDsHzD2IKsqlXZ3MFY8YzWY8WpyEZBXMlU12gvaa0tmmTHXQLUrKupPkxVD446CO3ReFzRncVuv4W+n64S3i4xkvwjviRfsj5Y/3zGoKRK7VPUg0vNpLs1kjqY4r/+wRBz23EB3I5IPCnBZK5/VvLXgxjJrwYevzuY1ghf9cb+9nq+8BuELFWhOtlBOqvI9Jk1Tq5mNlaBNS+58TfRjURwvPVonfKxT80zdtHBIwyNlnw67Qq3/8t7I+5GAhAWZDVrGpePWdkvtd9vyJ38QD7qqR9qJAxMAOYkm9ggza7o3qgr1tDMWFHZ tKrB94A9 1zDvcgAfvo1ocsIbQsNV2qCVCCZrss9PDLlH8q+7noxSV1eFhXiPB01nA+61KliOboHSyLgnr+nCsxVjBnjnncdBF43b3F4Aq9x/Pau40ALZc3JwbgunClvaWvswXuVLGKt1t9aXh1IpbB3FWnETYFaw85gbmGMYF3pdRdqOt40DpYxnr8DYdUczcWOOQSQpswgAdcmbFEb6I4zK5fmjyDD+aOkx6O9nxAKekEF1ehU38/LkHuJ4bqVROm1Zg0jYnYTZ/ZI0EspI6H2o8d6DJhenUOMafr9t/Cf9dPx4F3Urb9ICkVdSYbcsSxf8uHKXDNQBPrpG4G6c7khFVtMWzuNId6qE8pKJUMVpIg3kR+vSaq0nctV992zTVacq6EV38LRe84q/k8VqMFuzIx3l0WvWmNfjbBo7MKxi2QQAnKhmgSecVhjAhLUqdpg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 25, 2024 at 6:10=E2=80=AFPM Zhaoyang Huang wrote: > > On Thu, Jan 25, 2024 at 5:54=E2=80=AFPM Damien Le Moal wrote: > > > > On 1/25/24 18:37, Zhaoyang Huang wrote: > > > Actually, the activity information comes from page's history (recorde= d > > > at page cache's slot) instead of user space in step(1) and can be > > > associate with bio in step(2) or iterate the bio in step(3) > > > page fault(or vfs)(1) > > > | > > > alloc_pages > > > | > > > add_page_to_pagecache(get the page's activity information) > > > | > > > fs_readpage > > > | > > > bio_add_page(2) > > > | > > > > set your prio here. No change to the block layer needed. That is FS lan= d. > Yes, that is what I suggested in patchv3 which keeps the block layer > clean by introducing a set of helper functions which wrap up the > activity things for FS utilization. Maybe I misunderstand Damien's opinion which suggests iterating the bio->bvec here via a new API. I think it is more costly than counting activities when adding pages to bio and need more modifications on each fs. > > > > > submit_bio(3) > > > > > > -- > > Damien Le Moal > > Western Digital Research > >