From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28DA9C433F5 for ; Tue, 11 Oct 2022 01:33:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 735738E0001; Mon, 10 Oct 2022 21:33:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E4F56B0073; Mon, 10 Oct 2022 21:33:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5851A8E0001; Mon, 10 Oct 2022 21:33:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4073A6B0072 for ; Mon, 10 Oct 2022 21:33:26 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 106F61404E5 for ; Tue, 11 Oct 2022 01:33:26 +0000 (UTC) X-FDA: 80006946012.15.94E1D5F Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by imf21.hostedemail.com (Postfix) with ESMTP id 9D4B21C0017 for ; Tue, 11 Oct 2022 01:33:24 +0000 (UTC) Received: by mail-lj1-f179.google.com with SMTP id m14so15120944ljg.2 for ; Mon, 10 Oct 2022 18:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=20onCpfWpwkHM6YrH8+6NcOzMR0zA9uR0cJi6DXMSdc=; b=pQkoFcsZDJH0Kh/HwwTAZAl8UOddRp0WjCd+gy1m0rYnrMV4AaFygOjukdhF/v7gLX f8ypt1hxNz3Ia26Nbe+JdfgE3KrxXHVtjyNdfgegBzDQyoryG7V1QIpV8GDx8phGPeMW Lctt1vtfSaImLEdQ5nwbnwj/ucUJyRWEbLAsS8XgYBysPI3zAnpXk6IyhDYWwk9TV6Ne HhbMNzhfny3ittE9/HV7d4edRAEuk2dZJ8BXqRfk7Z1dGGKg0lTAwhh/AicTxapzQdWB wZRDEl01AApLxLqqfp13QR7sp6bNf2FG0viWFYysDcZEBz/MA06Pf9TLsQg1tr+pSij3 8Phg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=20onCpfWpwkHM6YrH8+6NcOzMR0zA9uR0cJi6DXMSdc=; b=h+MXAVT2SB+cpmGgClazHLSy0HHGEVjZQGnIt77IpZStabn86iHoH6XgZ2GRR6HmTw idr4Q417mq59fcXwarjkQsmz5q7GC2PoipKmGJuQAwd3r41Idji6JOmFfF84psf9YmBu vhtqQJhFlw5aM5W6xceb5uK41soDNrtdq702alG94VO/rOkjglzUvsEc6lK/YxL/dRe0 n+KB0SStmD9XWkHTKhVKeCk5GR6e49tRkxA2cRUObBDVrVYf+VyJAK9FXKMcG2yVc57S SkG8bVI/hnPJusQ6gbtYQyH20UG3vpPEtCeK0HqX1bezv4wN+c8bGaxyBvHh1G+GuXzK a0og== X-Gm-Message-State: ACrzQf2/p7gJFpVILhK61wY6RHAq+zcK5hz35Eb/4TofDAsQiJOxDh1g /TNkPd1SZwd7Af9P1q4hljwaReKkMw+ko3kijtE= X-Google-Smtp-Source: AMsMyM5CBoH69E1efKQZxQCb5VUFqNR+4VM/PnIu9bqO97LTXx5cOLXLgz1hWviGI3+GKKp1SFpQ2njFahl0chLbwuM= X-Received: by 2002:a05:651c:222c:b0:26b:dec5:a4f0 with SMTP id y44-20020a05651c222c00b0026bdec5a4f0mr8460069ljq.359.1665452002769; Mon, 10 Oct 2022 18:33:22 -0700 (PDT) MIME-Version: 1.0 References: <1665450964-27487-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: <1665450964-27487-1-git-send-email-zhaoyang.huang@unisoc.com> From: Zhaoyang Huang Date: Tue, 11 Oct 2022 09:32:53 +0800 Message-ID: Subject: Re: [Resend PATCH] mm: use stack_depot for recording kmemleak's backtrace To: "zhaoyang.huang" , Catalin Marinas Cc: Andrew Morton , Matthew Wilcox , Vlastimil Babka , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com, steve.kang@unisoc.com Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665452004; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=20onCpfWpwkHM6YrH8+6NcOzMR0zA9uR0cJi6DXMSdc=; b=pveFy2naOa+ufAZRveUPQHxmCnrqYo9frhpz0sVrWwXSD6K73rhOM6EeU6WNO8IHclRtiK 1CBpKnDY9Xr8lQrrSyTj3sOTcilO2ZFGimKE8oV7gMTcHDmlm8+a/l35hqs6km4ojwdpgg l+YfgNK4GWInTx25sx6w8H7Ok3W9fHk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pQkoFcsZ; spf=pass (imf21.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665452004; a=rsa-sha256; cv=none; b=gRUejch5gtK/g3T83+xbqDrgRdXpTQmEiVuHVjNemMBIAcE73mdG2GVOZTVi6QpAVpezk+ PZnJ/EJ0EuE0Vga0kdra5qmvSxRlomOz/Am4dK8QYD6xEFpSatViqxHF6AfsvtmqhFrHdk 9S3t8SBsS8jkSMqrV7owcIMmDPjSXF0= Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pQkoFcsZ; spf=pass (imf21.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: n6nfywkuw5tgrbpsaxpqprdxjybjz9wj X-Rspamd-Queue-Id: 9D4B21C0017 X-HE-Tag: 1665452004-90281 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We can account and sort the output via backtrace under this change On Tue, Oct 11, 2022 at 9:18 AM zhaoyang.huang wrote: > > From: Zhaoyang Huang > > Using stack_depot to record kmemleak's backtrace which has been implemented > on slub for reducing redundant information. > > Signed-off-by: Zhaoyang Huang > --- > mm/kmemleak.c | 43 +++++++++++++++++++++++++++++++++---------- > 1 file changed, 33 insertions(+), 10 deletions(-) > > diff --git a/mm/kmemleak.c b/mm/kmemleak.c > index 1eddc01..c9cee3a 100644 > --- a/mm/kmemleak.c > +++ b/mm/kmemleak.c > @@ -79,6 +79,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -159,8 +160,7 @@ struct kmemleak_object { > u32 checksum; > /* memory ranges to be scanned inside an object (empty for all) */ > struct hlist_head area_list; > - unsigned long trace[MAX_TRACE]; > - unsigned int trace_len; > + depot_stack_handle_t trace_handle; > unsigned long jiffies; /* creation timestamp */ > pid_t pid; /* pid of the current task */ > char comm[TASK_COMM_LEN]; /* executable name */ > @@ -346,8 +346,11 @@ static void print_unreferenced(struct seq_file *seq, > struct kmemleak_object *object) > { > int i; > + unsigned long *entries; > + unsigned int nr_entries; > unsigned int msecs_age = jiffies_to_msecs(jiffies - object->jiffies); > > + nr_entries = stack_depot_fetch(object->trace_handle, &entries); > warn_or_seq_printf(seq, "unreferenced object 0x%08lx (size %zu):\n", > object->pointer, object->size); > warn_or_seq_printf(seq, " comm \"%s\", pid %d, jiffies %lu (age %d.%03ds)\n", > @@ -356,10 +359,10 @@ static void print_unreferenced(struct seq_file *seq, > hex_dump_object(seq, object); > warn_or_seq_printf(seq, " backtrace:\n"); > > - for (i = 0; i < object->trace_len; i++) { > - void *ptr = (void *)object->trace[i]; > - warn_or_seq_printf(seq, " [<%p>] %pS\n", ptr, ptr); > - } > + for (i = 0; i < nr_entries; i++) { > + void *ptr = (void *)entries[i]; > + warn_or_seq_printf(seq, " [<%p>] %pS\n", ptr, ptr); > + } > } > > /* > @@ -378,7 +381,8 @@ static void dump_object_info(struct kmemleak_object *object) > pr_notice(" flags = 0x%x\n", object->flags); > pr_notice(" checksum = %u\n", object->checksum); > pr_notice(" backtrace:\n"); > - stack_trace_print(object->trace, object->trace_len, 4); > + if(object->trace_handle) > + stack_depot_print(object->trace_handle); > } > > /* > @@ -591,6 +595,25 @@ static struct kmemleak_object *find_and_remove_object(unsigned long ptr, int ali > return object; > } > > +#ifdef CONFIG_STACKDEPOT > +static noinline depot_stack_handle_t set_track_prepare(void) > +{ > + depot_stack_handle_t trace_handle; > + unsigned long entries[MAX_TRACE]; > + unsigned int nr_entries; > + > + nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 3); > + trace_handle = stack_depot_save(entries, nr_entries, GFP_NOWAIT); > + > + return trace_handle; > +} > +#else > +static inline depot_stack_handle_t set_track_prepare(void) > +{ > + return 0; > +} > +#endif > + > /* > * Save stack trace to the given array of MAX_TRACE size. > */ > @@ -654,7 +677,7 @@ static struct kmemleak_object *__create_object(unsigned long ptr, size_t size, > } > > /* kernel backtrace */ > - object->trace_len = __save_stack_trace(object->trace); > + object->trace_handle = set_track_prepare(); > > raw_spin_lock_irqsave(&kmemleak_lock, flags); > > @@ -694,7 +717,6 @@ static struct kmemleak_object *__create_object(unsigned long ptr, size_t size, > rb_link_node(&object->rb_node, rb_parent, link); > rb_insert_color(&object->rb_node, is_phys ? &object_phys_tree_root : > &object_tree_root); > - > list_add_tail_rcu(&object->object_list, &object_list); > out: > raw_spin_unlock_irqrestore(&kmemleak_lock, flags); > @@ -1094,7 +1116,7 @@ void __ref kmemleak_update_trace(const void *ptr) > } > > raw_spin_lock_irqsave(&object->lock, flags); > - object->trace_len = __save_stack_trace(object->trace); > + object->trace_handle = set_track_prepare(); > raw_spin_unlock_irqrestore(&object->lock, flags); > > put_object(object); > @@ -2064,6 +2086,7 @@ void __init kmemleak_init(void) > if (kmemleak_error) > return; > > + stack_depot_init(); > jiffies_min_age = msecs_to_jiffies(MSECS_MIN_AGE); > jiffies_scan_wait = msecs_to_jiffies(SECS_SCAN_WAIT * 1000); > > -- > 1.9.1 >