From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AB99C433EF for ; Tue, 7 Sep 2021 12:15:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AA7AC610A3 for ; Tue, 7 Sep 2021 12:15:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AA7AC610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 13B4F900002; Tue, 7 Sep 2021 08:15:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EAE06B0074; Tue, 7 Sep 2021 08:15:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1AE5900002; Tue, 7 Sep 2021 08:15:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0187.hostedemail.com [216.40.44.187]) by kanga.kvack.org (Postfix) with ESMTP id E3A8F6B0073 for ; Tue, 7 Sep 2021 08:15:51 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A35D7181AEF32 for ; Tue, 7 Sep 2021 12:15:51 +0000 (UTC) X-FDA: 78560673702.28.053AC54 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf25.hostedemail.com (Postfix) with ESMTP id 5BFC6B000182 for ; Tue, 7 Sep 2021 12:15:51 +0000 (UTC) Received: by mail-qt1-f170.google.com with SMTP id g11so7707766qtk.5 for ; Tue, 07 Sep 2021 05:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Sf/naFZf6gVkPlsSX0o+6KPPqLesG/NQXjC5rLD+uwc=; b=amGj2iLUpj6wBywqneokmfuPuZsCPJoLX6J1u49EhdH8Vfwqf2/GstHdLGpVvkcMlu kwauX6WyujrlPbu3z1vNhYnbCsDSkah/9JULu80Q7ZqkzkwKcqSeJrDu/EZfHA74QhB5 +MNrMu2rt/aKhm5i2i6SoIRxR1dmHMxmtis7Gxwzdj804U2w2++z8/fNbG00RLPKVLt4 AQGLUgOT3b5AVkaw7gTcT5ym6ITv2o/squ6MX7p89vnaGucFcW+AZMIsFnUc8s+jwrHx FxaEi8qoxgss6X8CiqG6xp1TSAG0TZpB8dyarNBQY2Oz32MukVvbBfBdQIp/bCyymkwX Cp1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Sf/naFZf6gVkPlsSX0o+6KPPqLesG/NQXjC5rLD+uwc=; b=XzHZiVN2OGd9Mekto7tsxYbjeJPyVYQyKLK90U5PoUCQt4f4LyjfwridgJnZ/tQovg EDNbo301bQwTEIraRNsmkcJaNwUKpQBz+GVMg82zgKhnUOZtIzadgdxHYZuO0BUaC2p5 bjSiDjnhHJje9mt34XWkEY2Rb0qFu7fcLX7GAsWlSrsZBO8F7vqfu2lA4H5pe3vCx0QP 0RCSIP5oCyAWe0/caQa5NYcKxL1mmf3g4UkEJiKGUufCs1yzt+CIPDXMZwpOnUiM2TDZ 6ni/017EjtgawZHettiC09WnxLtTijhRy4PaSIkNL8jZuGmO+6Pcygmm81aRgtmIDleO Lkyw== X-Gm-Message-State: AOAM531fQJZkqUK2IGKbKQsvN7MN+k514wlR3vdApHkpBRc8VO57YejO 4ijK1a4wLT15ieSojFmmenaS/LuZe89iL9YoizE= X-Google-Smtp-Source: ABdhPJzUpT0yC1thDFHfXq7FcaKhMPntPE8Wl2afNUgYlzyVo7jDSf2e8zOt5O6bvVtodkw1GevAyYtxlHP4BUDNbt8= X-Received: by 2002:ac8:410f:: with SMTP id q15mr14616739qtl.299.1631016950762; Tue, 07 Sep 2021 05:15:50 -0700 (PDT) MIME-Version: 1.0 References: <1631015968-9779-1-git-send-email-huangzhaoyang@gmail.com> <79c08d1d-eef5-bc15-8186-7e3367b4ebe7@suse.cz> In-Reply-To: <79c08d1d-eef5-bc15-8186-7e3367b4ebe7@suse.cz> From: Zhaoyang Huang Date: Tue, 7 Sep 2021 20:15:30 +0800 Message-ID: Subject: Re: [PATCH] mm : bail out from psi memstall after submit_bio in swap_readpage To: Vlastimil Babka Cc: Andrew Morton , Minchan Kim , Zhaoyang Huang , "open list:MEMORY MANAGEMENT" , LKML , Johannes Weiner Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=amGj2iLU; spf=pass (imf25.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: 3iqeahejckktn3zmxdpemyc7s4as69rf X-Rspamd-Queue-Id: 5BFC6B000182 X-Rspamd-Server: rspam04 X-HE-Tag: 1631016951-335171 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 7, 2021 at 8:03 PM Vlastimil Babka wrote: > > On 9/7/21 13:59, Huangzhaoyang wrote: > > From: Zhaoyang Huang > > > > It doesn't make sense to count IO time into psi memstall. Bail out after > > bio submitted. > > Isn't that the point if psi, to observe real stalls, which include IO? > Anyway, CCing Johannes. IO stalls could be observed within blk_io_schedule. The time cost of the data from block device to RAM is counted here. The original purpose is to deal with the ZRAM alike devices which deal with the bio locally instead of submitting it to request queue. > > > Signed-off-by: Zhaoyang Huang > > --- > > mm/page_io.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/mm/page_io.c b/mm/page_io.c > > index c493ce9..1d131fc 100644 > > --- a/mm/page_io.c > > +++ b/mm/page_io.c > > @@ -423,6 +423,7 @@ int swap_readpage(struct page *page, bool synchronous) > > count_vm_event(PSWPIN); > > bio_get(bio); > > qc = submit_bio(bio); > > + psi_memstall_leave(&pflags); > > while (synchronous) { > > set_current_state(TASK_UNINTERRUPTIBLE); > > if (!READ_ONCE(bio->bi_private)) > > @@ -433,7 +434,7 @@ int swap_readpage(struct page *page, bool synchronous) > > } > > __set_current_state(TASK_RUNNING); > > bio_put(bio); > > - > > + return ret; > > out: > > psi_memstall_leave(&pflags); > > return ret; > > >