From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E02B9C433F5 for ; Wed, 27 Oct 2021 07:46:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7EEDD610A4 for ; Wed, 27 Oct 2021 07:46:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7EEDD610A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1DE5F80007; Wed, 27 Oct 2021 03:46:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18E90940007; Wed, 27 Oct 2021 03:46:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 080C180007; Wed, 27 Oct 2021 03:46:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0123.hostedemail.com [216.40.44.123]) by kanga.kvack.org (Postfix) with ESMTP id ECF63940007 for ; Wed, 27 Oct 2021 03:46:41 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 955B6181D131C for ; Wed, 27 Oct 2021 07:46:41 +0000 (UTC) X-FDA: 78741435402.29.8C26B06 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf14.hostedemail.com (Postfix) with ESMTP id 39AFD6001991 for ; Wed, 27 Oct 2021 07:46:42 +0000 (UTC) Received: by mail-qt1-f169.google.com with SMTP id v17so1670873qtp.1 for ; Wed, 27 Oct 2021 00:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9q/ALGYqDwdhLtPZsbnRWyuardQKJ35TGG4OW1DjCZA=; b=iSsc5HR+fsiNxzOXfw6h8SVZvp/HbeWKB5a5myra8kgMEaeuKZoibwAnmJBqzgBi0G 1m1qjpOhXnQDXh3LhYvEbcEjb82ou3ArwduzbYcyvwPSsGF5V9yGkf+b9Nnch+BmDOMO uHllxmrRxPmnrXD49Pkxd/rrskiTt3mMr4j6PllfIyBi5IKzwb95YckztDT/iGfwfvF/ xn7HcTniSBS73kB1dk19exUmQDzL9LFhpM4yyUMvItDdauW4wnrfVUjYBn5SU1F0Kq4U lJI/ObmeGm9PEk+LI4VFQew+oSggms8jYpeGS4YCT24d7BUEtqoHAk0dhNXhFrhJhZKH 0izw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9q/ALGYqDwdhLtPZsbnRWyuardQKJ35TGG4OW1DjCZA=; b=nmpIJrWfC9WcIoIZWUSIkAvDMj92bOzMziRC4zoz8AekwCle9EWCoGI0ZJcGLvzZiK gJRPwQXe5iDiYdYuWE5z+pq5j1I2kKMxU2CNmC+XOwi8wQWLfwLGri4tQt1+HxixR0kO LnPTXD4ix2A1nGy7cPKYa2Id64TZOCds5PcC5XPt6SwhmEXOytvyLVZpTM/D5ai3UmE4 WvGcbX9YVli9Dh5QkjFjqBTPXS1E3MvGPCjDh2BsFu00634QcDklB9ByEXGT0jHPtL4P pta2ztl0sQDRlkXatMiw0avpKYkR6ZbcxHPNrswYoyp48gT6rVVAOxbAfXfDc0IzzRTe 2VHw== X-Gm-Message-State: AOAM533gjrTroTQxFL/1ewgPJailYRkk/zbA2+uHjtttzJQpdlSzHMRl ICxQ3i/dnFiS2gBIpzW5IB/2OiNlhLQtDV2QK6s= X-Google-Smtp-Source: ABdhPJysjhJbIsbdrypKts8I/ECzzs1+FWwmDNja+0mcj/JDHnm26m1OvpQDFMySjZVbRCoTkSFhLyQsvVN2X+BSCBY= X-Received: by 2002:a05:622a:11c5:: with SMTP id n5mr29694457qtk.232.1635320800710; Wed, 27 Oct 2021 00:46:40 -0700 (PDT) MIME-Version: 1.0 References: <1635318110-1905-1-git-send-email-huangzhaoyang@gmail.com> In-Reply-To: From: Zhaoyang Huang Date: Wed, 27 Oct 2021 15:46:19 +0800 Message-ID: Subject: Re: [RFC PATCH] mm: have kswapd only reclaiming use min protection on memcg To: Michal Hocko Cc: Andrew Morton , Johannes Weiner , Vladimir Davydov , Zhaoyang Huang , "open list:MEMORY MANAGEMENT" , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 39AFD6001991 X-Stat-Signature: shkaqegjfqhiinmuworru9u51qb7k4ob Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iSsc5HR+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com X-HE-Tag: 1635320802-916835 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 27, 2021 at 3:20 PM Michal Hocko wrote: > > On Wed 27-10-21 15:01:50, Huangzhaoyang wrote: > > From: Zhaoyang Huang > > > > For the kswapd only reclaiming, there is no chance to try again on > > this group while direct reclaim has. fix it by judging gfp flag. > > There is no problem description (same as in your last submissions. Have > you looked at the patch submission documentation as recommended > previously?). > > Also this patch doesn't make any sense. Both direct reclaim and kswapd > use a gfp mask which contains __GFP_DIRECT_RECLAIM (see balance_pgdat > for the kswapd part).. ok, but how does the reclaiming try with memcg's min protection on the alloc without __GFP_DIRECT_RECLAIM? > > > Signed-off-by: Zhaoyang Huang > > Nacked-by: Michal Hocko > > > --- > > mm/vmscan.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 74296c2..41f5776 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -2704,7 +2704,8 @@ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc, > > unsigned long protection; > > > > /* memory.low scaling, make sure we retry before OOM */ > > - if (!sc->memcg_low_reclaim && low > min) { > > + if (!sc->memcg_low_reclaim && low > min > > + && sc->gfp_mask & __GFP_DIRECT_RECLAIM) { > > protection = low; > > sc->memcg_low_skipped = 1; > > } else { > > -- > > 1.9.1 > > -- > Michal Hocko > SUSE Labs