From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8451DECAAD3 for ; Mon, 19 Sep 2022 05:38:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E364A940007; Mon, 19 Sep 2022 01:38:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE6DA6B0073; Mon, 19 Sep 2022 01:38:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CADD4940007; Mon, 19 Sep 2022 01:38:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B4DD46B0072 for ; Mon, 19 Sep 2022 01:38:10 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7D622120786 for ; Mon, 19 Sep 2022 05:38:10 +0000 (UTC) X-FDA: 79927729140.18.5DC6B6C Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf18.hostedemail.com (Postfix) with ESMTP id 1FDEB1C0006 for ; Mon, 19 Sep 2022 05:38:09 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id s6so33967236lfo.7 for ; Sun, 18 Sep 2022 22:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Ar1cIlsH2x7/veNswkzicYr/hnf1XxcaKOODh9BJCmY=; b=WkhsiXuqhaYpAiR2Tu3CRIkIZrpKktHxL/gX/Cg1galoMiacJW/wjWzMSpuoN1pf8B tmoSVgzIjPKAVP7rguPGmVlobPrH3ukFXHYscmEMGq+QJ14+hZ/OW3WEMUp2cyJUgMMr +EizWtqsgKuze+wzagF3XC/4qBCV7wmNo4R3x6XnglPtHXmMsR3JMfB3ZkOgdeu2o7H3 5HitPMl0rsYckMZN8w/Q7xNHeaaYV2218wn6P2zjhR22+ThfSvX+Y1g33aZf4KaZ9vl3 2HNbm5qHNjxA39FfjT/JXXbyCnCx5/1vfFDjk/uSNllWML+F5M0hgxEgggEI5TbZEZJP VwCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Ar1cIlsH2x7/veNswkzicYr/hnf1XxcaKOODh9BJCmY=; b=XozLOF8YJjtYShrEaslDKt8xqydAS8gnw37wj8418ngpe/SIqtprBEQKMF/e17cjOJ sqOc2sTaSjDNjBQn4BpTgJiR/HAEMGORKcbhh+lzj4Ddgf1EgBrpsNZ1fc28cE73hHry fylElTVURqCQdO3pRrBWWNLGIgOZ+ZlCs+DLgEbOHRdVDYU1Srs1ctW39v/oYvor2f16 6F/T6WMeY05MaCwBgjnIcllZv11noFQBywL6Yol3Pp00j4M9VCrTHyNYY110Yq9mA1Xb 0ctng5sBW0AKdqPRCDW1Lc2odf1FrQCpNFuQ5wsl5SeYaJkKMc03nna7QeS32KD2uQUv Af5g== X-Gm-Message-State: ACrzQf02TBb9b++LEcQePE64KE3au91l5K/tNMX37NfN+A7X0s5pg8em jeKTUPj8RfvJzBFszC+BW0WdjUP0YjFyMSmTRVo= X-Google-Smtp-Source: AMsMyM7eze1r52dBg67odLQkS6NRBmYKUMTkBTSg+QRoZ37nm81kdPkXPo500kjR6rm0d6iVkkxbeBta3vlV4GcP2lQ= X-Received: by 2002:a05:6512:159a:b0:49f:6357:971 with SMTP id bp26-20020a056512159a00b0049f63570971mr3218085lfb.81.1663565888427; Sun, 18 Sep 2022 22:38:08 -0700 (PDT) MIME-Version: 1.0 References: <1663559238-22918-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: <1663559238-22918-1-git-send-email-zhaoyang.huang@unisoc.com> From: Zhaoyang Huang Date: Mon, 19 Sep 2022 13:37:40 +0800 Message-ID: Subject: Re: [PATCH] mm: check high-order page when free it to pcp To: "zhaoyang.huang" Cc: Mel Gorman , Andrew Morton , "open list:MEMORY MANAGEMENT" , LKML , Ke Wang Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663565890; a=rsa-sha256; cv=none; b=lphf7TJV4wDUo5lgl/G2kIrxlUE96zHTJUDL1EH7mIDw04j/qCZz0sonKq/LoTSXVK73Yc KUbWQ17iMKk4PBbWz08AUZ38e7o/WjbmRA8TvBEbNRi1rLtIJpPCARcw6X4k+JKZu7mPdm ckykMzA59/z531lgg188+NOsJk1L7QM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WkhsiXuq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663565890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ar1cIlsH2x7/veNswkzicYr/hnf1XxcaKOODh9BJCmY=; b=2YWoBVkby0rdfbURNj8jiYel/psTvVBI9sw33XxDvUnpB2H2JZ7hWpq9ZXfLK/hv5bUmc2 VNbq47PBsSPmW50qla8YPP3vmGaqz9Q7XhJJACbEYgIwN4H9n3G8lwJL7nfTAUyJGZcvy/ C1PIxJYy+nA3sK5vwXpyImBDTRMiPkM= Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WkhsiXuq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: nt3etpnyw15u57ybf5n56dw8c57yfhp3 X-Rspamd-Queue-Id: 1FDEB1C0006 X-HE-Tag: 1663565889-189234 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: current free_pcp_prepare logic should be inherited from the code before 44042b4498, where high order pages only reside in the global list and will be checked during free and alloc. On Mon, Sep 19, 2022 at 11:47 AM zhaoyang.huang wrote: > > From: Zhaoyang Huang > > High-order pcp page escaped from checking when both of DEBUG_VM and debug_pagealloc > are all disabled if it allocated again from pcp_list without going to global > free list, which should be introduced by 44042b4498. > > fix:44042b4498 > > Signed-off-by: Zhaoyang Huang > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e008a3d..e77f3a7 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1437,7 +1437,7 @@ static bool bulkfree_pcp_prepare(struct page *page) > */ > static bool free_pcp_prepare(struct page *page, unsigned int order) > { > - if (debug_pagealloc_enabled_static()) > + if (debug_pagealloc_enabled_static() || order) > return free_pages_prepare(page, order, true, FPI_NONE); > else > return free_pages_prepare(page, order, false, FPI_NONE); > -- > 1.9.1 >