From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3A2AC77B76 for ; Tue, 18 Apr 2023 04:16:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F0FE8E0001; Tue, 18 Apr 2023 00:16:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A0F26B0072; Tue, 18 Apr 2023 00:16:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 468778E0001; Tue, 18 Apr 2023 00:16:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 366646B0071 for ; Tue, 18 Apr 2023 00:16:46 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F1D0FA0619 for ; Tue, 18 Apr 2023 04:16:45 +0000 (UTC) X-FDA: 80693200770.17.0C8A26F Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf05.hostedemail.com (Postfix) with ESMTP id 2C3ED100009 for ; Tue, 18 Apr 2023 04:16:42 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=jwtjjdmg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681791403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kxdxKq/32CCtowAPIubpFnwofkATJc7V1iVpirtu27w=; b=tFjXsbFHEGnNlv3Q9GHKfrR7hG5PJ55DWbsoACI9mySNj63PnqzVw6L+c4hmv1XvMxqwXh Zu0UZu+OuFk206uDq/rG6SOP+3XNCtFtz8OHjcA8vgnMjcrW3D18o4uwgh2omRANOvIUUz pAB54CZLesrpqlgGmB+TRi98CkqGTXc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=jwtjjdmg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681791403; a=rsa-sha256; cv=none; b=HW+V5yl8itwdjDiZWMSwH55lze4IpMl65LiuDhQTHNHJ16HEpxbMTNHSIISLHREWw7bOUT N/WWzUczYp0/PxVOPFalXIi+964afQV7fHX9QzXrpYqvmj2ZNPpPNl28n1dP9Qg3wKKqs/ NJpKoeWWcXEteM/Mu8p5L3QE/E0iArA= Received: by mail-lj1-f180.google.com with SMTP id j11so16462015ljq.10 for ; Mon, 17 Apr 2023 21:16:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681791401; x=1684383401; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kxdxKq/32CCtowAPIubpFnwofkATJc7V1iVpirtu27w=; b=jwtjjdmgHbfoBaMWcTZ7kc/zoWiLA64ABwCz7E6pD6AxAJiAWdWG1gjla1pyurFoLq Z3/7z8S9HvVHAd9hsx7uoh18w+z96cg8IaRi220JxpPj0kiNSUVoyhJtQ5LyMBHKHPyy Z9A0Lw/dMgwxgFMCqrCyPUhAus6CoT8/dg060ANuPhGpgpvztFG4n5xfk6LbqHiyFsZm oCIophkoVqNbK64Az3MT4qZw/3qcuy+MhG9i7A1I2DaUM3yQPcJHkN725u1Q9KtBxcHC ntgo/8sgU2TVzRNRkbvKGiEzjEO4XPdRBua96Svc51KxTsaljFokebCrEW8hZnJgXOaX nPcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681791401; x=1684383401; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kxdxKq/32CCtowAPIubpFnwofkATJc7V1iVpirtu27w=; b=IcgwPUQ5Gz1efkR8mQU1HJWnv9QfYcEw4Gn5izbkZJaSR49za3zfgHp5V3KZLmnD7Q ceeEYwq0hwzMVueNO26mlwhzbvSrDVTAqiHgUwU4Wh3NdXclLlT3IozN5mQBATZItvzF TTE19oWUE5sV/dYxkGj8E4bkSGZ2+1uzoGM3/xRkaFSm/vaXnoy9ytN4Otqd3eufdWjg SoavjyJA7rpTao0HoIq8Z7r1YERRAgEF2rgmoM1Fa565orK2e5cjFsSO+YBtt8yxHGux 2QUx9l3hn5XlecdFOtMkom7fxZCRUPUqRe5injH0TJil53QsgZCOJIsJ8iarVAmJlSPN NX/g== X-Gm-Message-State: AAQBX9c2Ctz8RQaYxciIgVcgKzAaJv93C6qiohZRmlrt9cm3TtLhEy2o 1Yn0+u+ryG2Ie1TbHnc28mfIxW5HGH1B6Ck8OtE= X-Google-Smtp-Source: AKy350ZF1kAdHZGxxjn3MUKBsFDMKApVmpNWiASwQIcMyvXjgL6i/yn1DzdYO1mHttL8L6EIEE+mNE/I4mafi2Dj3HY= X-Received: by 2002:a2e:9c13:0:b0:2a0:69e0:9f7a with SMTP id s19-20020a2e9c13000000b002a069e09f7amr206920lji.41.1681791401028; Mon, 17 Apr 2023 21:16:41 -0700 (PDT) MIME-Version: 1.0 References: <1681788789-19679-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: From: Zhaoyang Huang Date: Tue, 18 Apr 2023 12:16:19 +0800 Message-ID: Subject: Re: [PATCH] mm: fix printk format within cma To: Matthew Wilcox Cc: "zhaoyang.huang" , Andrew Morton , Minchan Kim , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2C3ED100009 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: cybjn3efcmim3ge84d4eq3n6nua64h79 X-HE-Tag: 1681791402-160508 X-HE-Meta: U2FsdGVkX1+nv0JufsNAK9TFU/VJX5ndMe2mkSBEeM2D4ei7xA3QlsOmyMgxkL7c7LyB6Hcs4OAJ2DTua0pSRsTtCG0+8pucsbF4jmhSlX0jeOQEUeCGGhdUEp+MnO97bu+g4Dce/kObG2spP6tr7dTsRYb11WHUPBBLw+czKg6gEexG5hSNgftH0xTB0lRDkwb4Xn0ErEym3fsRLJsgswK4Fn5GDpgq42kMnmkA1SnDMv8owX1NP7fHtzHxJcxbqEIQZxYT/hthi7t1qh7B8y+wUCLp58ADeE5jTV0Ig9YvMZ2/Q4SP9MBmShYgNA5CapYuZOsoOXsf8IAb7bKMrwU/F9l9tVr+K6ifhcIgwXixqm2gw8L7mLuco9OCIO2xCfMbzyDuXD2TL8rKwqQJHGGLJloWBmkSQ2oTj4GC48Os/XLXXueLBxxOjFz+kz/sbHV9xiPoRPfJGccV/jww51N7pm0lUWrLaRJ7oxRqORy+4SG8s5KtxgJ24n8Vb43UG25k7nQ++Ls6ljpB7x8dbLpW2dXKOHbN1hkKjzcPaHpYe7CxosSmw5VRo/Dm+zCFgzWAqxRIwqwXvr1tS3LpW37sdr8ii8lEslM5qQulsQd4d4/8Xj/wQ5WsACwMF6Quh7Bf9ntL6c+XlEWSlidG3peKxaIa+gcMX/H6S2EbveR2RrjCtaZGDFEvEK3DyegFZVlXoV9OvTjuigOwdSlN/82AhAeup7Cu2zIb2N2PsZdwSKzBpDTfYmbTaLZagdg0uUz5r2F8chPIiz5fb6sD0g9VCXsoMRmQGvIwPziCwKwoO4rChf2r/DWtgm2+fLF6mXAFyTUUDLCwIb/H3RQjto9P6oP9BwzWBk4JdCmxoHv1gJEgSE6geqbeNW416Kc43B9D25ssM2aoXTOhh8ycFv6pPVfORB4KgxN0ahioNbouLTeSE1lwKH6iruBzXhOAj0hiDHL6v0iHwArqfUF d/V25tBz rvT4kdVmA6XuZmsSq+KUDAW7UukcdCE3znuvO1Q19US1CCNd1D9T4RoS5p9Cm3oMwm1/2rKpewg3gVWbwtApqHEEODihiCaaYyqFUL9/Ghp8IG4kWVjqQjbdwv6ZGhYGpnEzjWWPMPPLOLZDJE0iFttvpOCIYi6xYmiUY2Q4X7ac3K9LOOJgqMOjBo7rAKe0cqRIlMNaTMt5lJgG+jVPbaBvMC3PsTgZ4L8OlEokGTVG6jOCgXinMF5rAX6UJS9TmS5AGoYY9ItnOR6xDK7iEBNs2l0BOyduJ1npOWTTFzZ8NKc2trUVARVgQ9/AbLVaugk7AUCb6bjmzXpDM1R0rHusY/bmfTdUMGg6VKl+Dj7Vlbz9WvxqR4tDiiLP7nTxN1eWATfhaTC6IVFkxUjV1jb61c7v+7AIgDk+K/bC5+qz30hvtCGNvmkzLE3zOPGaIddwaUuqfEQup/eMmEgOw+rkFLSEraLn6CZEhMk+1KxFvE8o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 18, 2023 at 11:38=E2=80=AFAM Matthew Wilcox wrote: > > On Tue, Apr 18, 2023 at 11:33:09AM +0800, zhaoyang.huang wrote: > > cma and page pointer printed via %p are hash value which make debug to = be hard. > > change them to %px. > > Why does printing the page pointer make any sense at all? Surely the > PFN makes much more sense. either pfn or a correct page pointer makes sense for debugging, while page could be more safe than pfn which expose the paddr directly > > > [63321.482751] [c7] cma: cma_alloc(): memory range at 000000000b5e462c = is busy, retrying > > [63321.482786] [c7] cma: cma_alloc(): memory range at 000000000f7d6fae = is busy, retrying > > [63321.482823] [c7] cma: cma_alloc(): memory range at 00000000e653b59b = is busy, retrying > > [63322.378890] [c7] cma: cma_release(page 00000000dd53cf48) > > [63322.378913] [c7] cma: cma_release(page 00000000315f703d) > > [63322.378925] [c7] cma: cma_release(page 00000000791e3a5f) > > > > Signed-off-by: Zhaoyang Huang > > --- > > mm/cma.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/mm/cma.c b/mm/cma.c > > index 4a978e0..dfe9813 100644 > > --- a/mm/cma.c > > +++ b/mm/cma.c > > @@ -435,7 +435,7 @@ struct page *cma_alloc(struct cma *cma, unsigned lo= ng count, > > if (!cma || !cma->count || !cma->bitmap) > > goto out; > > > > - pr_debug("%s(cma %p, count %lu, align %d)\n", __func__, (void *)c= ma, > > + pr_debug("%s(cma %px, count %lu, align %d)\n", __func__, (void *)= cma, > > count, align); > > > > if (!count) > > @@ -534,7 +534,7 @@ bool cma_pages_valid(struct cma *cma, const struct = page *pages, > > pfn =3D page_to_pfn(pages); > > > > if (pfn < cma->base_pfn || pfn >=3D cma->base_pfn + cma->count) { > > - pr_debug("%s(page %p, count %lu)\n", __func__, > > + pr_debug("%s(page %px, count %lu)\n", __func__, > > (void *)pages, count); > > return false; > > } > > @@ -560,7 +560,7 @@ bool cma_release(struct cma *cma, const struct page= *pages, > > if (!cma_pages_valid(cma, pages, count)) > > return false; > > > > - pr_debug("%s(page %p, count %lu)\n", __func__, (void *)pages, cou= nt); > > + pr_debug("%s(page %px, count %lu)\n", __func__, (void *)pages, co= unt); > > > > pfn =3D page_to_pfn(pages); > > > > -- > > 1.9.1 > > > >