From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26D96ECAAA2 for ; Fri, 26 Aug 2022 03:23:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B00916B007B; Thu, 25 Aug 2022 23:23:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB12E6B007D; Thu, 25 Aug 2022 23:23:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 977EA940008; Thu, 25 Aug 2022 23:23:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 895776B007B for ; Thu, 25 Aug 2022 23:23:57 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5E3BFA06A7 for ; Fri, 26 Aug 2022 03:23:57 +0000 (UTC) X-FDA: 79840299714.21.F82535B Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf29.hostedemail.com (Postfix) with ESMTP id 19AEB120007 for ; Fri, 26 Aug 2022 03:23:56 +0000 (UTC) Received: by mail-lj1-f177.google.com with SMTP id z20so408122ljq.3 for ; Thu, 25 Aug 2022 20:23:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=JNP1ORV9yRRuz9LjK0bjG2dgT1656BFJx85PdWV1CB0=; b=ZMoWy8eAx5EI8FJVjwa+6rX5EVAh3w5+u04QN8Zyok5BHhD+EjpBybcYjuWIg/KcRr wCaTfhxHzAqOiKg07LR6pGr9X/PwaynUYAaS/uCdbH3vBauGbdEkumJ8e7ZaRjzRpmCD j61Ge/4iGQedwgE4VFuh5OR17cll96aSRsosa3e3KTSwCtpiDq24i7t7TsCFRZh1i231 eOzwE/BGSBtvYH7iabyB/o3B8ip5/XHLW3Dp+gcTSoLS4jJXaJXNlf6HZ3Up5EekdluM GIuTExtecTKCnHPfohhHJlpTtLFdDdNj7VEHGvJUjQNxTBlN3hXI8FW5sdsmA9qxxBxe +XPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=JNP1ORV9yRRuz9LjK0bjG2dgT1656BFJx85PdWV1CB0=; b=Mtv0ugISl+xcBrArrKPtXvYFmoIkeo5Ui1xBJcAp7O5pVr02MgnCkj+ajcnUutETGF ecVLzwkxxVUHxsmtJdprR/IoAkobzJ4lVEHGImX5W8n9xOxoxhpesf8GpvWIMSGaxOO7 rC3ZhlhSSC2Tc/rBkSYA3wTy7KvWQ5AVVDoWssPmCisGKgzrkLmKQBzyAnlgXZyShIjE xaHLQBg+JR+Q/O5YeYcg4GhtmwRAVNQi4SgY5DHCAORIkthMWdV8i2EuZ3hdTPNp0Cdt WvJHqJt5nbyd3355WR7YW8iQth4dZ5KMZrtu5qnBg3umIvSzL/fsASA+N/AJPLv/DlM7 Bc+A== X-Gm-Message-State: ACgBeo1Om4mnVj7X3JEuS3F82PATOVLfW1HiU+BmJ7akm2tkEqX6gccI dYvmOhcIIhV3q0bC1CDnQF/83IMtrJCf5k9Acek= X-Google-Smtp-Source: AA6agR5jQr8H/RRm3ko/w/rAnGml/+TaNwQF/PWDo91XGn4YL9OJT46UXewMJmM29wAoiSk+nFPzffJHV1KlczMEF0g= X-Received: by 2002:a2e:beaa:0:b0:25e:34d0:4d57 with SMTP id a42-20020a2ebeaa000000b0025e34d04d57mr1811616ljr.329.1661484235492; Thu, 25 Aug 2022 20:23:55 -0700 (PDT) MIME-Version: 1.0 References: <1661483530-11308-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: <1661483530-11308-1-git-send-email-zhaoyang.huang@unisoc.com> From: Zhaoyang Huang Date: Fri, 26 Aug 2022 11:23:27 +0800 Message-ID: Subject: Re: [PATCH] mm: skip reserved page for kmem leak scanning To: "zhaoyang.huang" Cc: Andrew Morton , Catalin Marinas , "open list:MEMORY MANAGEMENT" , LKML , Ke Wang Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ZMoWy8eA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661484237; a=rsa-sha256; cv=none; b=NzWv71hPjpeyvua7S8HBOUZHB/lJYsfCQrAmIGjDDu1GyTcOvINLG2wDJRpZTuMjv1MT2u U1bfrR7UJm8kwK9SqzPmzmebGkgjsDXdoitGSPL9Lj5mgsLVuszvG3nzmLMZBE/MWKcBIT w126W6uvY7m8gtrnkRIjjmZqniVQQfU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661484237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JNP1ORV9yRRuz9LjK0bjG2dgT1656BFJx85PdWV1CB0=; b=xx5eeX49j5VN6ckCy94PKPg+Qip5ApZ+W1+sjTPwVuwrfzmj2ccN4lDYfATDkzcgYfMWPN eUpQ2Jfu0OoT9CXpO2LZOCjjO5XyPd+lDzBG12s3SASOIvhzVmbHHKl8jnNFhMKcfVkx33 iq/VGvtDrUAKq0XCPcDkl26081rkTNI= X-Stat-Signature: rrq3ztsicmrighuxbji7qsayejtqduxg Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ZMoWy8eA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 19AEB120007 X-Rspam-User: X-HE-Tag: 1661484236-724650 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 26, 2022 at 11:13 AM zhaoyang.huang wrote: > > From: Zhaoyang Huang > > It is no need to scan reserved page, skip it. > > Signed-off-by: Zhaoyang Huang > --- > mm/kmemleak.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/kmemleak.c b/mm/kmemleak.c > index a182f5d..c546250 100644 > --- a/mm/kmemleak.c > +++ b/mm/kmemleak.c > @@ -1471,7 +1471,7 @@ static void kmemleak_scan(void) > if (page_zone(page) != zone) > continue; > /* only scan if page is in use */ > - if (page_count(page) == 0) > + if (page_count(page) == 0 || PageReserved(page)) Sorry for previous stupid code by my faint, correct it here > continue; > scan_block(page, page + 1, NULL); > if (!(pfn & 63)) > -- > 1.9.1 >