From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2964CC25B75 for ; Wed, 15 May 2024 06:32:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9FDF6B0169; Wed, 15 May 2024 02:32:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4F076B018E; Wed, 15 May 2024 02:32:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F0676B018F; Wed, 15 May 2024 02:32:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6BA7F6B0169 for ; Wed, 15 May 2024 02:32:01 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1A12A12127B for ; Wed, 15 May 2024 06:32:01 +0000 (UTC) X-FDA: 82119660042.30.B164DEE Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf07.hostedemail.com (Postfix) with ESMTP id 40BFF40019 for ; Wed, 15 May 2024 06:31:58 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="N/U439i4"; spf=pass (imf07.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715754719; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KO/Qnq8uu0A2bAHSPuBz0lil2/aJMgXXAcipsRcH8eU=; b=nn+EWXpVC+mYXH1Ee4U748jyPZ/xWHnJSMOfBS4DkkAjrNw4j+12TTT/SlgKDy8Vq8T6aK WkBJuz4WvKvN/jGXshqWuPNwldD9bNVbA9ZSIEDbhjF39wYbOikrRgKz973iSnlWGWxtTG nRZby/5SrJ+ynJrngKsI+NgVaEeZGcE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="N/U439i4"; spf=pass (imf07.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715754719; a=rsa-sha256; cv=none; b=rAocsAUdEyAVzpcLl9wpEhwbyweWhAxr8MUR83hjgVulovA657fqWPVZIhPX5b5hBh9q// aXBccCCmjby1Yn00RFT/ibpvVPDCa98aqHNtGPlVo73z0CXFa5brwQoxp2EuDKmEywYivo 7xxYD0LE3md8KLWnNP3fg2DD85YQIoA= Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-520f9d559f6so7582633e87.3 for ; Tue, 14 May 2024 23:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715754717; x=1716359517; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KO/Qnq8uu0A2bAHSPuBz0lil2/aJMgXXAcipsRcH8eU=; b=N/U439i4Rkk+RXOZcS2rurOMx/KYyMuFvVqqG4khW+N1tNKQLsUFLiN3qZMAd4fP+8 zFs3L6LTX+uVwB9Gz6UTVKdYXpikZo6fF0ZG6ccg9WMy5VMz8IYDjNg5oVDvat6DwXlE O+z42M3/E48m+1NgsP615+Y4VeOH2CqVyH2SIralCPKOxFYgaEEITUr3DYRVwURk0y1A dQ3BmuQFccdJ4YgodGwlUHQFT1YOXq2OeSSQDdoxq/9OsFO5nk/J2mXyFSkdh83XMTLF a+wCkL5N/5KrKQKR7GIH+BrUic+feQXs5q9kYAank3ZRprHL8t+jIFnSuTZwJ0K2L9cF 27kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715754717; x=1716359517; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KO/Qnq8uu0A2bAHSPuBz0lil2/aJMgXXAcipsRcH8eU=; b=pa+d/Sz5fEJ535Z3sosLQVjnlFOuX1L/n3VI5tjXlx7FwobjXveq/59yI1Yspw1YN6 O40X3q2tGjKdA3RCqZq1mA91i7GTzs72MZYCL82qHwyMdhSB7KJDKsVUw8/1g2rgKcKW SVL7l8GsFFFCvcEcslGMNm1oKHyvHOM/8nPetmEvMlRgPzLIb7x3ALmZpXbTY7jJ3rHF Rjfb5o1JCJRVQhHioq+eUCTiFbqVkGscqM+T3aAXvZh3oP80D+Rt1izTiQ7HJFps94ge mZKvtMZ87RrXWh1wooyVJ90iPdQUbEclDGF3qatRKtO4DbhS/0wGjGVoyJUSDkwUAPrI +d9g== X-Forwarded-Encrypted: i=1; AJvYcCXG6I8CWHkw89BRV0T3FMi3+lNJdHt9Ks8cpcOey8pX1IE+WfbWswAZvadk92DB8Ty1u7+L8Pgl6E6mZKVizIceX+w= X-Gm-Message-State: AOJu0YzRRAF+Eh1ZguiHMmHUDbV3h50RNfzD2ICxPAM1ZQKSMStZYZZh bpF67VW5yaI1eAWMw0QjhTki44cxQhFP0/udQjiGtSJbTWKYk+KkBnMkoYcBiMJ+XFPLYnLbVYp 8MSTZaIpQnbc+lo8KHH5gsufmPEYjLw== X-Google-Smtp-Source: AGHT+IHoKg0Vu+Ev/OMzjy0UIYtyUIbh89ctl6Q2Uk+JY2wl6Xd+Yslf9XhsdnZpO7qUHzF5fIdfEgEnHzxHsvSQbzc= X-Received: by 2002:ac2:58e3:0:b0:518:dfed:f021 with SMTP id 2adb3069b0e04-5220fb749bdmr7624802e87.24.1715754717250; Tue, 14 May 2024 23:31:57 -0700 (PDT) MIME-Version: 1.0 References: <20240515012350.1166350-1-zhaoyang.huang@unisoc.com> <20240515012350.1166350-3-zhaoyang.huang@unisoc.com> In-Reply-To: From: Zhaoyang Huang Date: Wed, 15 May 2024 14:31:45 +0800 Message-ID: Subject: Re: [RFC PATCH 2/2] mm: introduce budgt control in readahead To: Matthew Wilcox Cc: "zhaoyang.huang" , Andrew Morton , Jens Axboe , Tejun Heo , Josef Bacik , Baolin Wang , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, steve.kang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 40BFF40019 X-Stat-Signature: ekiwnhew811twojmhsa4jfe1e7b3uiqq X-Rspam-User: X-HE-Tag: 1715754718-981430 X-HE-Meta: U2FsdGVkX19FqTX7RPp5NxBFZdxOpWc/S2BqKiTjgjoYkgeljQG+FZ+RIU5UbhpoP1yZ3PMastoxkMcV/DNadqGFf21BeW9EH5E6l6WgZKeI5+Dhka0WQR5I9OC+LOm6SaghpeJ6VGHIj8O1kdSx3XjH4jH4+34jeieEi8u/oyy34QmScCDtNOBfYihxbhHl2knDZGKDXsybtjh+8Kxo5J9qxwqoBtITwlBJzeMk45lrmUeCNuWE4S28b2b5lIRmwib0tFcj8O1ywP8WCU3seuy2g59eQ37tT08saQGR0T562uLiaNt0LPN2RVwI2rURvfCrqUhdPcPpMbCab4ehGZqDI5hxfSlukzs/UjYt/I/26q8910gQfE20gdXxE13psEcgV+9VWN3Rjr2qfrjbw4equbyWQHGXNyR+iukt2M/P8AMWUZGGMA+8Aoalv8qgBfsJJJ65Y70Z0ljHZOL79L0sU1Dln2Y/LA70C6bDbC+9dsEbht6RnzRGH/+Z1S2wb7Fft6dH3uCVy/KojqM5GtOEG8NJiZMipULrArGBvkTV2U5rsfkESjMbdJXJB3NkvTkIrfqetWeLODTeo8/CEJpj2Faf3SQnJ8k+A9xsTz0x495V8TodgRIPll65oWQc2DySBYvdtYirP39vt1jD2ixUmEZ2WK/fYbIc1alFHybWAohbBQOAu8ctb4DDxwEBZ4RBAaks/6g2dYB/4TSs6ooSY8HlnWvNY12qmQvjwUVgUHOLuFNYRwZGIyUeqP21ZLa+dA85sQ60H46eOLM0qMVBzXuQrt0hi9pDECKlQRyKOmOpBWv4GoW+i6XmwBZcy7ohSYGAPdVmarrBqmhu6PNFsosHH4L7oTjqkYI5KWXnxpN8z9tskFGW8MOfKVbzjZvG8stukkeNMTdK20pwEErYi0EUo0FNyIOTwGw2AQIb/VPMlecIGctbZ2xXl0y8ynHychVUHUCkYEirKVa R4F1YA9J OnKZMLGNXJnyjBXUcTi32o2R0SFI+YtU3MBzBpQPWmTz8ULHWYuceOkKRC6CcI68cif3AW3bI2NG9bAAwSID/AP739zD5PCRBzeJ6DPkomZ4jmQv/wGidpjXdiG0ECXGxK1PTvU2GTKhFISozuYc/ismNcZ+0FHH7sz4IdSi3z9IAELGxBK5RzTVpNybSwXW1yXuSdJl8v1LJqhzmz3mEdweRvCs8pC9R5eRb2IQbvrM1MdrgxEMJYC5LMbiKR1cpb5jwbcuRCqqGw7Bx2bTuR9A38Ng553n/E6Z2G9hNqAmEm0mJ371aJ5bQ9u3Iu5N9dxnO+M72jbnLKwrmTyPZCMKnIoaidvi7HhSlOePcjuGD+8DuEPkG6174qYgPQZqPcPVhdInyvxq6kgcT0KwVrnDPFPE0w2WWlgwh X-Bogosity: Ham, tests=bogofilter, spamicity=0.001656, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 15, 2024 at 12:09=E2=80=AFPM Matthew Wilcox wrote: > > On Wed, May 15, 2024 at 09:23:50AM +0800, zhaoyang.huang wrote: > > + unsigned long budgt =3D inode->i_sb->s_bdev ? > > + blk_throttle_budgt(inode->i_sb->s_bdev) : 0; > > NAK as previously explained. ok. But this commit could work by following the configuration of blk-throttle as long as it works on btrfs with internal RAID on. Furthermore, this will help the blkcg meet the desired BPS value perfectly.