From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C6B9C77B7A for ; Thu, 25 May 2023 01:23:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CDE1900004; Wed, 24 May 2023 21:23:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77DEF900002; Wed, 24 May 2023 21:23:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 645D9900004; Wed, 24 May 2023 21:23:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5633C900002 for ; Wed, 24 May 2023 21:23:36 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2E74E140601 for ; Thu, 25 May 2023 01:23:36 +0000 (UTC) X-FDA: 80827030032.18.D5F1FD5 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf21.hostedemail.com (Postfix) with ESMTP id 4682B1C0006 for ; Thu, 25 May 2023 01:23:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=cLEsJxGC; spf=pass (imf21.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684977813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ImO6OtSkFfnvqFi/Tdj42NbWs/io79Pf0LI695zdQVY=; b=jRuWBOV4N2btuoiPuTtHMuoN9dY98Xd+GzGGQ6TbYML+TP6euXWpI31douMf0ulhXSxHrr Xvw7jhGe36A1Oyx18IPaRjDrwmT/xY+xQZTZycl8Uus1TWYyEbJ7UNGFsFmebNbUxV7Ps2 qM9yRLyFdMU79e9DdRF4eEiaInxRwtk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=cLEsJxGC; spf=pass (imf21.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684977813; a=rsa-sha256; cv=none; b=2h7BzSiel5JR+ACFqJy+3QwvJuWpJJeVP5oErdYM+wltJk8vkMoARGHPqepu6oKHOSaL41 8EH7BL37c3ADFeEHmdjMtlc+wMoZYd9E3vA33BkGAlDWasbbPhfE8gHprR5Y+RRHmr4X92 bXhv9t41dAx+dxuixIevPLuMLQ70qJI= Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-4f3b39cea1eso1691379e87.3 for ; Wed, 24 May 2023 18:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684977811; x=1687569811; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ImO6OtSkFfnvqFi/Tdj42NbWs/io79Pf0LI695zdQVY=; b=cLEsJxGCeWR0JFmIcbzKPv46zp4Nl1rQF+aCeJitALaDzDdP0m0Dnl7gfz6vwlNqPj xp2kGQXVGvaqzlpJIoxk6U6dLDDHWyQoD4snYzy+ZHTadjqyIrgwm+AVPX//PY5VGnmr PMh8/910FClKBXpC+Ffitssgdo/KLt/GarDP192FFlK6RT3yTJxHyhYqO3YFG4FLaVvT pFmmoholHhL1vxdfVoGxUfSJJNLtWNWHQn+qgj89q2lpoHw5YHQKgAKVdEfqDnuU/NS6 TYVkQ9yAme5Jp4qflWuebnIfq9FYgpYkXWz4NlDqvK0bfKouPbbqTaJ0w352funqt2Ur 0gUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684977811; x=1687569811; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ImO6OtSkFfnvqFi/Tdj42NbWs/io79Pf0LI695zdQVY=; b=R+a68d3Edx0kdnmu4VcbLnvWWaxUz2jpPaaHi1uC3Fp3hv95Rf/l14UBfOBGhBZDCY 7Wn4nizGajn9D1f88QAHSVeCMWteSq3Iga19lj2sBTGv1eGVI8sdNdv9fedIPVorc66F 4wSvafU/BidWHeUacCNPTL0ZW4PkSQC+3ODv7Deyexzf2yxDIFP97jlvZgiNliojxJQN LCJJjGR3VU/NXf6c4A09YR9JfA8RpwZQvuBFPJGuqwTJ+UhKIol2MdXM/M/PgHS4WkwD jd3K7mHxdWRHhr45WJjWqu4mGlEuxMjxxs6xr0v+ZUxfvFnmCxTQpW2v2EUEml/mID9V KgrQ== X-Gm-Message-State: AC+VfDy0XGViMRJ3Fnz3bW0Vqndh/1eqDt09ZlVDn/p2qr9dTDBqZLPM clhFyVaBE9SLE3ohly4ngR2Xh8egi01mjKPgA6Y= X-Google-Smtp-Source: ACHHUZ4R1YP38WQ+w5tcAppMXtmV8ADJBETAAAQK+pQaNcR7Z1INqwa5atnT5D3ecG2LzRAH0mK4g7Qq2e/3e42QVbE= X-Received: by 2002:ac2:4ad1:0:b0:4f3:8c0d:41c4 with SMTP id m17-20020ac24ad1000000b004f38c0d41c4mr6139693lfp.30.1684977811090; Wed, 24 May 2023 18:23:31 -0700 (PDT) MIME-Version: 1.0 References: <1684919574-28368-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: From: Zhaoyang Huang Date: Thu, 25 May 2023 09:23:07 +0800 Message-ID: Subject: Re: [PATCH] mm: deduct the number of pages reclaimed by madvise from workingset To: Suren Baghdasaryan Cc: "zhaoyang.huang" , Andrew Morton , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4682B1C0006 X-Rspam-User: X-Stat-Signature: sryx6q5f75fxjy7fsndzbetdaath1tjz X-Rspamd-Server: rspam01 X-HE-Tag: 1684977812-629691 X-HE-Meta: U2FsdGVkX1/EbLGWEoxpUmLPWqR3OSnogRuIFs8hgO7sF44TolWpd1BQSfr/+7DqAi361zt/wzH4udvwpvk1R+FfW7lfPyyFmPzIhD7QNxj0T4RS9QbVcK7YtcsJxKdIYT5TwjrIjwYoCgexgp3TsXNMCeRNhDUZXUjJIEe5Le/bAqlWReTf/9Zda1a2es6gnqo0HHb7nBYM326FCfRWaPDdM8w53x04grcLP5ijj2H1KroRKnXO27Rf4m9MKFiWdNDULbLaTEbWkZtX8k7Yq0y39GC1V1OuwQ8MfVGXeXJ57y7j3xPy/mruD1Y1BOImKGjMutZM5bm/zLWanjk9GDhCh2pXTcpadShvhYKgFYitZKHX130voAKrMDVIbe7kuaDtrtId9KwkGR6c470qS640Kk+LQZTtus41PuucfaNwODYjlkLanIOyIWrstGiQbBASI3DhXPrV0AVpdBTp46kGOu0JaFzeQEWVhDx6U0kLrgfmWmc0PQkq6N3G9XqdJwjZIPgo7Kk1GVPGaTXozQdOB5YxaIVyxLcjIdnQW2HXgxmGW98tJ1zPWD1wwrjUKrLAfB/pRvrP23Hu4uWbwm6NgTq9/v9Zt4NwCXvjVmRGg0biDHbUIr65/Apj6dOIjYMm+BiX+fWVJGiECkDtXUBcsOPaZeXo/HGpFQSRsgzDwpPIoI+ZcSM8DScgkH1Y8waQ72kshjvv1mTCZYRnEUeKiDNe1LkgZZDjIIgZZswWuObkfSswwtUw9UNIYrESozx01TcpfLz+LCmAPug2KO3vEfiGEUNf6eKnOrmsUeThA+0DKZWIWzFgnoXwTiFeew9rOjJsp9viZEHMUzhM/PsjGtRMVyn9i2F8vbDezhJWysZ6UwBcwntI2JAQYtD6FZ6S/JvihwWgBtz+6C5aRycJxGoqi6a3ccLoU0Vo8bKSxh/uQsjWFFPsZ2ymQOW61F7kD3kXqHduY27loOd 1dL3ZOoq BlCtpOH2a+sdodnxat3MeU0SraPbif9CgmIc5LBrWeezHn1s6Zwqek4yxRabumFpkO00Se3k/p/7ZxS9OL23rEjDhDwNJxPfyE9znjEtkWZRylRkSddW2gDkQWPXoo8KxkQDLI0dxqzcjFiRM3QMgGebQxn3QC3HYfd9LUH3TNB25Ux3U4eJS7wXyh9S4qrCBnrl5desGPapYuf9FCZxydDi+MsnyyVeH00WNOXzY0RkKRHqptg76+4mRo+uMhPxukBQIDVN9TBA2say32DANfdgnnrzSfMUhKyuMAUgy3OjMFGdm3m10AliDQYzPHgVyKB8GQNyvIMfXx5AG12VW/n2zwvD3upBHsd1O/1srVb/fFTKpZHNGdMAqv7lHPtuY94vNvB26lb+DIyOm+n3i6hhvIr1jNkH5WEnf3I+WrZ6SPBn2wntDXfD1GIBJp3OU9QAqrDLsbsoeYqKHgwNIRVC7vxRNTziRqTi5jgJE1aipOx1U/BpRmwUiAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 4:41=E2=80=AFAM Suren Baghdasaryan wrote: > > On Wed, May 24, 2023 at 2:13=E2=80=AFAM zhaoyang.huang > wrote: > > > > From: Zhaoyang Huang > > > > The pages reclaimed by madvise_pageout are made of inactive and dropped= from LRU > > forcefully, which lead to the coming up refault pages possess a large r= efault > > distance than it should be. These could affect the accuracy of thrashin= g when > > madvise_pageout is used as a common way of memory reclaiming as ANDROID= does now. > > Doesn't workingset_eviction() in the following call chain already > handle nonresident page aging?: > > reclaim_pages > reclaim_folio_list > shrink_folio_list > __remove_mapping > workingset_eviction > workingset_age_nonresident Yes. What I suggest is to minor this pages from non-resident as they are dropped forcefully > > > > > > Signed-off-by: Zhaoyang Huang > > --- > > include/linux/swap.h | 2 +- > > mm/madvise.c | 4 ++-- > > mm/vmscan.c | 8 +++++++- > > 3 files changed, 10 insertions(+), 4 deletions(-) > > > > diff --git a/include/linux/swap.h b/include/linux/swap.h > > index 2787b84..0312142 100644 > > --- a/include/linux/swap.h > > +++ b/include/linux/swap.h > > @@ -428,7 +428,7 @@ extern unsigned long mem_cgroup_shrink_node(struct = mem_cgroup *mem, > > extern int vm_swappiness; > > long remove_mapping(struct address_space *mapping, struct folio *folio= ); > > > > -extern unsigned long reclaim_pages(struct list_head *page_list); > > +extern unsigned long reclaim_pages(struct mm_struct *mm, struct list_h= ead *page_list); > > #ifdef CONFIG_NUMA > > extern int node_reclaim_mode; > > extern int sysctl_min_unmapped_ratio; > > diff --git a/mm/madvise.c b/mm/madvise.c > > index b6ea204..61c8d7b 100644 > > --- a/mm/madvise.c > > +++ b/mm/madvise.c > > @@ -420,7 +420,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t = *pmd, > > huge_unlock: > > spin_unlock(ptl); > > if (pageout) > > - reclaim_pages(&page_list); > > + reclaim_pages(mm, &page_list); > > return 0; > > } > > > > @@ -516,7 +516,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t = *pmd, > > arch_leave_lazy_mmu_mode(); > > pte_unmap_unlock(orig_pte, ptl); > > if (pageout) > > - reclaim_pages(&page_list); > > + reclaim_pages(mm, &page_list); > > cond_resched(); > > > > return 0; > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 20facec..048c10b 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -2741,12 +2741,14 @@ static unsigned int reclaim_folio_list(struct l= ist_head *folio_list, > > return nr_reclaimed; > > } > > > > -unsigned long reclaim_pages(struct list_head *folio_list) > > +unsigned long reclaim_pages(struct mm_struct *mm, struct list_head *fo= lio_list) > > You would also need to change Damon usage of reclaim_pages() here: > https://elixir.bootlin.com/linux/v6.4-rc1/source/mm/damon/paddr.c#L253 ok, thanks for reminding > > > { > > int nid; > > unsigned int nr_reclaimed =3D 0; > > LIST_HEAD(node_folio_list); > > unsigned int noreclaim_flag; > > + struct lruvec *lruvec; > > + struct mem_cgroup *memcg =3D get_mem_cgroup_from_mm(mm); > > > > if (list_empty(folio_list)) > > return nr_reclaimed; > > @@ -2764,10 +2766,14 @@ unsigned long reclaim_pages(struct list_head *f= olio_list) > > } > > > > nr_reclaimed +=3D reclaim_folio_list(&node_folio_list, = NODE_DATA(nid)); > > + lruvec =3D &memcg->nodeinfo[nid]->lruvec; > > + workingset_age_nonresident(lruvec, -nr_reclaimed); > > nid =3D folio_nid(lru_to_folio(folio_list)); > > } while (!list_empty(folio_list)); > > > > nr_reclaimed +=3D reclaim_folio_list(&node_folio_list, NODE_DAT= A(nid)); > > + lruvec =3D &memcg->nodeinfo[nid]->lruvec; > > + workingset_age_nonresident(lruvec, -nr_reclaimed); > > > > memalloc_noreclaim_restore(noreclaim_flag); > > > > -- > > 1.9.1 > >