From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4250C77B78 for ; Thu, 20 Apr 2023 08:56:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76AE0900005; Thu, 20 Apr 2023 04:56:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71B02900002; Thu, 20 Apr 2023 04:56:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E2D6900005; Thu, 20 Apr 2023 04:56:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 505F7900002 for ; Thu, 20 Apr 2023 04:56:07 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3068016022B for ; Thu, 20 Apr 2023 08:56:07 +0000 (UTC) X-FDA: 80701162374.04.FEF9463 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by imf25.hostedemail.com (Postfix) with ESMTP id 63E20A000F for ; Thu, 20 Apr 2023 08:56:05 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Z9Au6FhL; spf=pass (imf25.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.182 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681980965; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IDoRV5tcV4ZLbo8bWLcQ8xGavuIx9pc5Dsyn6+Jg8jU=; b=Vc0pmmFWhyc29E6+4R/U0V/uX4IurAozhe08Kgl+7BQrf/YrtehwS3g0fsKFGI2/GPGuHX U5NhtWbjvLcUKwEiNH6sO6ddn/3pZc241nDSq0lJ7WNlj3Ady8AkvpvcnL8iIndA/yzAYq xyFIzNyrMsc9a/f+YPQLAvV3OoYcSDk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Z9Au6FhL; spf=pass (imf25.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.182 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681980965; a=rsa-sha256; cv=none; b=0qPER6rrp+AMRwrN5R5jjhOBO0id/xNM8WiUgU5gzS+4FgmHibHElrD/u0CopEZdTpsQlQ wjwBXWBdAl0owe4Jps5LXyDSY4lsL21kZDwvYAhgZpaYn3+PPbzfesXLrAXHvT4oOt+Knf nMkZ97afUBT1da3FlbSvEwX14f7DeDM= Received: by mail-lj1-f182.google.com with SMTP id c3so1949981ljf.7 for ; Thu, 20 Apr 2023 01:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681980963; x=1684572963; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IDoRV5tcV4ZLbo8bWLcQ8xGavuIx9pc5Dsyn6+Jg8jU=; b=Z9Au6FhL2zZcCfxk3Vg49XyZaJhsV+1G6HIC1zZ6IXs5r9e8qePR4i4vUBD5nWSR3x wtflzNMT2axG6I+DhEBb+ca3Wkn1CwQQFINDeXmvcnLZ/Yxpr+PWRbruJ6bXipij6Xj7 /XLYETFSUpYxKt6/1YfjnAuq8HfaN9nILBy3BIddpubClCiQahXXsGKouIuMVbSE+krZ 7NOnqSNCfkuVGFR3CwG4gB7GyfT1euYaa5X+Bfy6WZ1PYUh2RqI0s6Nzg/uatkO3VsfK oOW/JhhBpp9T3WJPGTtH80AVpnkGeselgRIci254i1RRDLj3qicDwGEt6M9BYq97nYBk r30Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681980963; x=1684572963; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IDoRV5tcV4ZLbo8bWLcQ8xGavuIx9pc5Dsyn6+Jg8jU=; b=amkDmkE7pEgLCKUGRaLDfU2yEsv7uyNt0G9LL/x0+GwWX8qe3E/OoqhDSoxmmnrEPP iZvA8XCRCTFFuqEuy8D/sUDCY0aO3y5N3ekZEAYs6vDGDEZ0HzRmCzEdE3GJtatcuUck RBoC5j2jpXrYRMaKABNG6wHWbrAopsvMCFtHfXkT3cxgqnB4nP4WAcaOR4wevbdOrPkF ybxfPAGLmvnahz+V4Yu9QJZdN5gOmFWu7jp+Qng7RJ8VdWrvJRQB3PrKhfbtrHPumUj8 PB8SA9CVpa6lh5X+NW53ZIUbtDofnAkjxrl8C6Mi3jXMx4EBjn8kiBekK2nl0MFlQvB0 7GaA== X-Gm-Message-State: AAQBX9faGnomognrQ7UO09HQgGmfOmTUbVTTjC37nU/5epYOtH0DumyW nABEVZPuCu30Yc/pz+QnTXvCb7ReD8Zhu+ektSU= X-Google-Smtp-Source: AKy350Y592dYlVHKp5FQfJ0AtiEMF9NldYZPYTj5qdStROYO2WVptcRlnvulWQNPF0lTh87Xg2gvJRog6FD0xAuddDA= X-Received: by 2002:a2e:721a:0:b0:2a8:c513:7577 with SMTP id n26-20020a2e721a000000b002a8c5137577mr182705ljc.51.1681980963361; Thu, 20 Apr 2023 01:56:03 -0700 (PDT) MIME-Version: 1.0 References: <1681979577-11360-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: <1681979577-11360-1-git-send-email-zhaoyang.huang@unisoc.com> From: Zhaoyang Huang Date: Thu, 20 Apr 2023 16:55:41 +0800 Message-ID: Subject: Re: [PATCHv2] mm: skip CMA pages when they are not available To: "zhaoyang.huang" Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 63E20A000F X-Rspam-User: X-Stat-Signature: dso4tognar75md5n84m1a4gpdxbg4w47 X-HE-Tag: 1681980965-851020 X-HE-Meta: U2FsdGVkX1/cgtmRWKoZDAugZBcYiQ0JgknBOT4qF6J/i7v8IPaR3Vyp2+N739fEikSP+iY4UbULlsOGNL/LRbBUEBwtCAZ8P16rdSNjyAEmIc8Kx2FZO6wACv8IwAhSeKnEpmDVJV8lBF5mtvnS+cfBi/OvApGVAE+90mBaBs1qha0Dmbp2kj22MmePkYF2sopen87tQn8xeHPIOYIow3xOYS/Dvg1mQVvea9QhNffOYdS26EUMcQ1duozSSx6jT/TzISX7SG5o6CequjzK3wLSGgPBMkseAgsbA+9RxX4TFy3vC96nLY+R+zNJY0aTDv2l/BQuaiF26n3JWLpgVM/ZYrC7dTxD5hOgDcYyKu6MIe8gNeybkDinLB45bzDxcxrqX93+bF8cmFe8LKtsKnWD38dYNg7mUYa5+6Uwe+xgBKyrSKIPhOBAbmUFImAurkHz+CuzCOzh2q4DdEaQrVH9QoA0FsAz/7KsBkWCP/CWsqCeEyRnArC+9h5wWdDvhaVph5S5Uqox+7GA5dY+gJnNY9cEjR1oEsQipUL4w4pOIvirh99gP92hkCOZ85TLT8WTuf85yy/fFrPm0VRjvBqIiltY9JtdtE03uKscl7KkJ+askBBJJV4vyNWfL14f63fitoaOeebTTdBwPTvuedbPrBu8Vi3WD8sxdp+DWhnLf5YAzjmbFZrU31LufwU4z8JUJUsAV5Apa+bWNEgaTrJ8p+sOMVCQdMNz0OlLHbW9eGE/e3bN6uNP+TV+zbrajGESzvU525ys1L8jg+DIKAj9fkr1h/q5Uenc+jxMvn/l6RZhx3wjEn5E8HLXS9w+nF1ZyIQceyXK01c+AKjQ8K/2O34oU0nHdwcZiYjoYTk85mmSy2nC+xtDYo5mX7iSZpo8GJmwMuVzzjg/QlinZ8zreCELsFVeOvLDKRpRztXxlx4MTSHUlHo7XmSNS7Z1EFU9AW7rXO63ZnKuUI/ sV4F8OPp 8Xc3oQKNlMmlBRJSx+t+kOoxL9xb8NpJs5HuRjpwHdaPB/GPqP2azfu71XoH8CdyFBT7qoArulxE3hLD8t6z61YrP2pkskuI04oXvEhS+yXnjR8pAmT8pZn/tUFY0/qXdxeSMnl/HYrjreSDr9atMACIgOh3N6FkvN0IkuzNLFEWG+WucSJt7BCLJDTEEHLwGS1hkNi0zqi25ApTe4K0s0cK1gNDMZLRkfxj+BwTfNvaIiSYWoZNMFjXNy9JEOOTykzyazSVwOuOFh5tWpNTUXR3z1RBScrOPV412lR7s0819bySqwBeoj6I4wm896zK8zsSW3vrhPnYWJ3vYNqgedualbIZSdFteITZe0zVdkGjpMBfHCgHP85wrzVKRdFEwXO1OWlMMb+dXIp7BABvrK7XbKyG7hYOWn2CnwmCvqQD4YviWrMwXt8FJcF4sFwyyOe1ZAK32Lr++ffE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This patch could be more helpful when large cma reserved areas reside in a single zone(etc. 500MB among a 2GB zone), where a lot of CMA pages spread in LRU allocated by fallback of GFP_MOVABLE allocation. On Thu, Apr 20, 2023 at 4:33=E2=80=AFPM zhaoyang.huang wrote: > > From: Zhaoyang Huang > > This patch fixes unproductive reclaiming of CMA pages by skipping them wh= en they > are not available for current context. It is arise from bellowing OOM iss= ue, which > caused by large proportion of MIGRATE_CMA pages among free pages. There h= as been > commit(168676649) to fix it by trying CMA pages first instead of fallback= in > rmqueue. I would like to propose another one from reclaiming perspective. > > 04166 < 4> [ 36.172486] [03-19 10:05:52.172] ActivityManager: page allo= cation failure: order:0, mode:0xc00(GFP_NOIO), nodemask=3D(null),cpuset=3Df= oreground,mems_allowed=3D0 > 0419C < 4> [ 36.189447] [03-19 10:05:52.189] DMA32: 0*4kB 447*8kB (C) 2= 17*16kB (C) 124*32kB (C) 136*64kB (C) 70*128kB (C) 22*256kB (C) 3*512kB (C)= 0*1024kB 0*2048kB 0*4096kB =3D 35848kB > 0419D < 4> [ 36.193125] [03-19 10:05:52.193] Normal: 231*4kB (UMEH) 49*= 8kB (MEH) 14*16kB (H) 13*32kB (H) 8*64kB (H) 2*128kB (H) 0*256kB 1*512kB (H= ) 0*1024kB 0*2048kB 0*4096kB =3D 3236kB > ...... > 041EA < 4> [ 36.234447] [03-19 10:05:52.234] SLUB: Unable to allocate m= emory on node -1, gfp=3D0xa20(GFP_ATOMIC) > 041EB < 4> [ 36.234455] [03-19 10:05:52.234] cache: ext4_io_end, object= size: 64, buffer size: 64, default order: 0, min order: 0 > 041EC < 4> [ 36.234459] [03-19 10:05:52.234] node 0: slabs: 53,objs: 33= 92, free: 0 > > Signed-off-by: Zhaoyang Huang > --- > v2: update commit message and fix build error when CONFIG_CMA is not set > --- > --- > mm/vmscan.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index bd6637f..19fb445 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2225,10 +2225,16 @@ static unsigned long isolate_lru_folios(unsigned = long nr_to_scan, > unsigned long nr_skipped[MAX_NR_ZONES] =3D { 0, }; > unsigned long skipped =3D 0; > unsigned long scan, total_scan, nr_pages; > + bool cma_cap =3D true; > + struct page *page; > LIST_HEAD(folios_skipped); > > total_scan =3D 0; > scan =3D 0; > + if ((IS_ENABLED(CONFIG_CMA)) && !current_is_kswapd() > + && (gfp_migratetype(sc->gfp_mask) !=3D MIGRATE_MOVABLE)) > + cma_cap =3D false; > + > while (scan < nr_to_scan && !list_empty(src)) { > struct list_head *move_to =3D src; > struct folio *folio; > @@ -2239,12 +2245,17 @@ static unsigned long isolate_lru_folios(unsigned = long nr_to_scan, > nr_pages =3D folio_nr_pages(folio); > total_scan +=3D nr_pages; > > - if (folio_zonenum(folio) > sc->reclaim_idx) { > + page =3D &folio->page; > + > + if ((folio_zonenum(folio) > sc->reclaim_idx) > +#ifdef CONFIG_CMA > + || (get_pageblock_migratetype(page) =3D=3D MIGRAT= E_CMA && !cma_cap) > +#endif > + ) { > nr_skipped[folio_zonenum(folio)] +=3D nr_pages; > move_to =3D &folios_skipped; > goto move; > } > - > /* > * Do not count skipped folios because that makes the fun= ction > * return with no isolated folios if the LRU mostly conta= ins > -- > 1.9.1 >