From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 059B8CD68E3 for ; Tue, 10 Oct 2023 01:42:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52D5480038; Mon, 9 Oct 2023 21:42:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DD8380027; Mon, 9 Oct 2023 21:42:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A52980038; Mon, 9 Oct 2023 21:42:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2B2B280027 for ; Mon, 9 Oct 2023 21:42:52 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E2AC81604B2 for ; Tue, 10 Oct 2023 01:42:51 +0000 (UTC) X-FDA: 81327852942.17.2A178FE Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf05.hostedemail.com (Postfix) with ESMTP id 21155100002 for ; Tue, 10 Oct 2023 01:42:49 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KVmaKlos; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696902170; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8r8xsqUE1WfCL4pE6OYo22lswirb6FPZBD4Cqt+Avvc=; b=4MJjPvo8vBv3feS22jENOcaTPPDrhmx+2gUmDK+Z0CKIeIPN6e/QGEzbm7mPnD+KdiPSyJ hlfLFMlMbpSNU0sc/T3/nmx2WVCB/UNRuMAVLAtnnF4HNIKc4ouH2bhe0g1Won34gFSHfh 2W0XjBjuaAgMsafmeYHepvFN/c/k7zA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KVmaKlos; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696902170; a=rsa-sha256; cv=none; b=JWVkl3eilkANnafJkR5x0eJ1AH99sg9mCpYA+g9cfoikoiWcFwPl7vL8o7AqhB8lPJZCLS z+qd+fTsgpmG7gtHuotfgGeXHNUr7fAtZw2jPEAj1WuRGtm1y+KPi5GZckrz+cSlAPIaQ+ 2hxxCMiSLlKMdptEBKo1R6+bl3y3Ngs= Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-503065c4b25so6835118e87.1 for ; Mon, 09 Oct 2023 18:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696902168; x=1697506968; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8r8xsqUE1WfCL4pE6OYo22lswirb6FPZBD4Cqt+Avvc=; b=KVmaKlosrztGUS9B9GCcLvfomc46X9F7hxB+u8ZJcc7vDQJm7+01RjdqPK0xG04odo Q/04ikT2GuSAfFFXOtlG8SfQBloS6CRMfNL55IBMSiglh8pP7Yltf7Oi5pFvm0d6+t+9 shMOJZXvt4PtEJt/lBEVYZdtqBbu43ud1HRT6O/IG2xO7BTdQlssxYOldKCwxiJL4w0W S59Kqz6N6tdFEKfLXVi35TsL9N3NMbZykPuv/sn8qyOqnkqaD/W+3SUpWLhfQJdNTHi+ +qv9UuwjaIyBKshX2kcKFSsM/4qVC+mdujSBflus1SkmVJN4Ssr3HTV74iiBJLIgmjZv DROg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696902168; x=1697506968; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8r8xsqUE1WfCL4pE6OYo22lswirb6FPZBD4Cqt+Avvc=; b=i2hiRqrtFP9aHE6rFq5s5gm52PM0VLzLFzOptRP5RMCdQEYKFd54ZJujcyX0Gqnn0n /CqArb1OIsoOAjFtttqnubBvEMTuN7ey595Wcg3v/yGANhdT5vob/SvAbRUxMQDsDY5R lfxeFtR16rM3rew1qco8pjvzLYxHLrR9w20ePg8U/RUwPEYDb35kwCZZCeGPtNqhoQsu zDkBFoLiR2Sf3MjSf7xnVLXsGUIbUGAW3x+5j+pEukzIcZbB4sj71+zDQgVp+P+QBlGP VdUgGHDsliXMHa5dwL2miDthJNPgGdMk63c/9g/nJOgxwITy7JTi5+Imsr/djytuDIEp HXsg== X-Gm-Message-State: AOJu0YyJZMBheySoHbiWL9XOoETNbJGI/wQ5Bf9SnLgILUHLDHfPxP5N T/jloMiJWa2soTXaG5ZzYO1rnyXj/FrhCHD9ngI= X-Google-Smtp-Source: AGHT+IEPcd/ue90wff4n2u/SRx6h6zwqRB8fhsQ1HkkqaByi1Z9uVEyKoevP73q+nimJAh929A9LfXs8aPzzsK5Em44= X-Received: by 2002:a05:6512:3e20:b0:502:9fce:b6cc with SMTP id i32-20020a0565123e2000b005029fceb6ccmr19062741lfv.11.1696902168001; Mon, 09 Oct 2023 18:42:48 -0700 (PDT) MIME-Version: 1.0 References: <1683782550-25799-1-git-send-email-zhaoyang.huang@unisoc.com> <20231006141750.5423083520f74bc0746fd249@linux-foundation.org> <20231009171415.cfc26b45c2f9f4489afe16c2@linux-foundation.org> In-Reply-To: From: Zhaoyang Huang Date: Tue, 10 Oct 2023 09:42:36 +0800 Message-ID: Subject: Re: [PATCHv5] mm: optimization on page allocation when CMA enabled To: Roman Gushchin Cc: Andrew Morton , "zhaoyang.huang" , Roman Gushchin , Minchan Kim , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 21155100002 X-Stat-Signature: 4padc9fxigotiu8eokbg7zpiaptmk4b3 X-Rspam-User: X-HE-Tag: 1696902169-781310 X-HE-Meta: U2FsdGVkX1/f6KAoOf34OXJDyGwIZpAAYPooOtjnIm83b7CB4EWHb57GDCUC06/CvJcvci40O5zptUS+GmPb/5MyQcklSR7/yoNYvY4qScKzNiJ++AIHVarUJnf0Q4yY6EvHurZGTX6Wmn48wHXIWibccnUaa59aRyG3FWcYim3/aMsqE+9M6nffz9x3s00osYX+X9z+kMm/o89OLfNTRvILzcYKkc13u9VOz3B/r/RbkOuq+bIAAF20H46ANRmAQ1hcCLaloPDBC+KWB5zZNJCrIYD/J8wkoDHcNispDGypTZZLaS7WH2RYwZoKnOlXp7TXr0ykvIannx6M8NSyPrJrxZztZM3UIPLou03ct0xak5V61763btnxTaLgKw1g2Lu/ZrP9xCywy/iNrZS5gw0Bm9PTG5tdfzvr9SowdxZc3JdYaZv1YWDxcc5djR/nsmKxfe8yQdn+PjYwI5e/9FvPdg1zy8DMFDRw52wY9t/N8ixumgX/UuRBaPH4/WLDWbb+Eq47Kcv5KEdn9D3Lfckd0OZPGvmfLhtxQFPbzU7q2/Ef/bxFZA6vyhVWKAEnavcnYBw2IsBB1Isk78Xt6cD7Q2ijASNUFikN7LaeW5TTW0Q7MBdItSYHaFxGGuuCoaB2bqr7ETvuOUbE8O+gIw2z4VfXdsUpOYgRvQ5Q9wx+pH5LyZ+HwEF71NjfAT0yUSKn0fLHfVn5gRccAig9UWkFAU5K/hJQFt8MdnHLzDjGPJYCpr0jH1p3UlzfmfSahsNyGYoL/TCFQd0lgdwV8HTMYXbArgZ1OCz7/wflCqzdkObk0BdhydNkvjfhqHJsqiwnrC3FglQqddvT/u5QE+nmTli6QC6Mk5CzcY+MAk4MYmH0LkS/jRXivF6l4DmfTXk/RPy4hCSzCeejIVa0ri3te6rm0JyXZqay9WqEsfVMuh/8IdtGxKLOe9vuGqllLSFbOPANJraXu/IBbex Bkx0X/+O EPrai9cMJt6uSNTxuQbJt1wqgp5MCckJuGoDpwngaJVVAHxLofh6//n7ACKI9IHruENeTjrEjAfAuFJP6bkgx7mTPHVPUM9vSwT3OYQhkF4ca7zni1snV6tFqaPHiCPZJ64upuQ75LUeRt1bloZTER7WB6iI34lIFlczrHH2qggJ+W6TtGFHPIZlWKM3mSqiAgC/JbRHuhT7yWpfNeK8GDQjfcXf/mbL4UVgkHk6LLsZ8EOnNXIFsMCW1wfP1d26qq2GjWHafQsFb0SKvuCpFbYeXmErQ8JjOlwmesrJis1XtW7zFe61g15zHbANM4ewoR3zQQuKn5PLH1hxbP8N9a03/sn3IRd/mtVP5V8sJ71yS6bnycKMDMHnpEA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 10, 2023 at 9:31=E2=80=AFAM Roman Gushchin wrote: > > On Mon, Oct 09, 2023 at 05:14:15PM -0700, Andrew Morton wrote: > > On Sun, 8 Oct 2023 15:54:40 +0800 Zhaoyang Huang wrote: > > > > > > Roman previously asked > > > > > > > > : Also I'm a bit concerned about potential performance implications= . > > > > : Would be great to provide some benchmarks or some data. Probably= it's > > > > : ok because of we have pcp caches on top, but I'm not 100% sure. > > > > > > > > Are you able to perform such testing and tell us the result? > > > I have applied this patch in a v5.4 based ANDROID system and got no > > > regression problem. Actually, this commit is aimed to have > > > alloc_pages(GFP_USER) use CMA instead of stealing U&R(could lead to > > > GFP_KERNEL fail) only when zone's free pages and free cma are around > > > WATERMARK_LOW/MIN which would NOT affect most scenarios. > > > > OK, thanks. > > > > Could the appropriate people please take a look at this? It has been > > in mm-unstable since May. > > I have 2 concerns: > 1) it's still hard to understand the commit message and comments, I can > only reverse-engineer it based on the code changes; > 2) performance concerns I expressed earlier are not addressed. Idk what's > a good benchmark for the page allocator, probably something i/o or > networking heavy. > ok, I will update the commit message > On the positive side I believe that the patch is solving a real problem.