From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB5BDECAAD8 for ; Wed, 14 Sep 2022 10:51:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D2A88D0001; Wed, 14 Sep 2022 06:51:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 381D96B0073; Wed, 14 Sep 2022 06:51:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 249DB8D0001; Wed, 14 Sep 2022 06:51:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1373F6B0071 for ; Wed, 14 Sep 2022 06:51:36 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DC156409BF for ; Wed, 14 Sep 2022 10:51:35 +0000 (UTC) X-FDA: 79910374950.19.93D4B5E Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf30.hostedemail.com (Postfix) with ESMTP id 8250D800CA for ; Wed, 14 Sep 2022 10:51:35 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id q21so24614915lfo.0 for ; Wed, 14 Sep 2022 03:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Tzg0UqcWkRO7Ez0LCVJhhSJSUEIHdVeKXG31/UCwhag=; b=P6tReRDP3eRaLV/9uibQ/73lbSW9BM1VfDUIETF0de9TTlE6DgAXsYkDiRlO+Ozlu8 YJ7plGgD3ax9uxCY5LIxYNfaiE+bHAkifNUHC/VuxRNyECI6we9DStZEvXCP4pwiGR38 26fpvrRASMtHO9K3Qp5dFxsiS77nZb2Cy7unJZnrHEBXriEz/e4kNFwm9p4Lkri2fH9/ +PHdoqK0K5azuRorTki35Be4OZacDY5R9QgXwAxUSd8tNGdgGfn5GX1mtHJ0VWiLPTmr 0xcl/Z3rNP9eDgtfdBB6RswB+KG/qhDrW1lcQIsqfcfCpvXUO8ZbMppYYrel4qj1Ud3t 51ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Tzg0UqcWkRO7Ez0LCVJhhSJSUEIHdVeKXG31/UCwhag=; b=XC+gVM0Rj13yBhrV/zeQozVycnzpy3FcQ51A67htDY0S7hwmvTf69YFERxGLJS8I9K vx17joDwc653zb+rJVtHsdnbohfQFlqrlHaEKUr1pJiuHiXijPqn4fES5BgxZywgFNGA SoEbPz+FuHPDSF0Ox/cj3a5vDvM7hAAhbTWeRi9So7bbD7LbhrG2jVzPn1d5FETqAOON 5ti4+R7N8JU5k/V4Raqdp9/syVgZC7/FpDGRfa9Sj3G46V7svuE16QjA4YjJrhd3JoYp pKDcSxBjc1PS3KmAi5skAUX8HqBE/fiCuJgbpOr0cKHzXS4ZHvsh/5ZTlFj/SH0jr8uc QqcQ== X-Gm-Message-State: ACgBeo3hzaSC+bquOHZyIRFB0KDTHCUHQ1zly7Tkn1udWoMj0eoDoevd fV3R+5zasFiIvN1HFpAFJBcp6JoPHadrVAJ232w= X-Google-Smtp-Source: AA6agR4/jJlL7UH6zxhhEoxV4Kw//WPkYLPvcLwxbA1TDgbVDsWXfksCqPfXKvnLFcVDLeLZHnz6uk33oJwtULEZzl4= X-Received: by 2002:a05:6512:151a:b0:49c:2f02:4e22 with SMTP id bq26-20020a056512151a00b0049c2f024e22mr2537908lfb.130.1663152693839; Wed, 14 Sep 2022 03:51:33 -0700 (PDT) MIME-Version: 1.0 References: <1663126621-26926-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: <1663126621-26926-1-git-send-email-zhaoyang.huang@unisoc.com> From: Zhaoyang Huang Date: Wed, 14 Sep 2022 18:51:05 +0800 Message-ID: Subject: Re: [PATCH 1/2] mm: fix logic error of page_expected_state To: "zhaoyang.huang" Cc: Andrew Morton , Catalin Marinas , Matthew Wilcox , "open list:MEMORY MANAGEMENT" , LKML , Ke Wang Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663152695; a=rsa-sha256; cv=none; b=FBVnP5cCTXRG4dzcEXzyyjVc5Oy57//V23zrxGrUz30vvXLVhe5ggJ2dHCa1PoHu5gWFiW X0lSmGM4XAKIZXxvEgMRrTSf0z8HIZgixUzBqPF2ZibZWJE+Si5pLrMKpVvMjqrMQLnWVw HzdS3AEHx+k8AGGAdmhSLZT/9F1puy0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=P6tReRDP; spf=pass (imf30.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663152695; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tzg0UqcWkRO7Ez0LCVJhhSJSUEIHdVeKXG31/UCwhag=; b=kc11ErZAh9MQZLeN0DzTao5+bg5FBYS76fSp2oK6Uku5lywv3U3eRAupFBv+yMtnk0Df1b Qic36CC+PHplOdID/vFJ9aMWJd3tw858EvVyps1t1cOsYQgIqixUYpNkvWos0WbDbcvS+R m5aUwvO47YAw3W4VkflpiFjP0uyqhWg= X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=P6tReRDP; spf=pass (imf30.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam02 X-Stat-Signature: xnddqwypmdtukmmxqxt8mefe1g7jobuk X-Rspamd-Queue-Id: 8250D800CA X-HE-Tag: 1663152695-603029 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Nack here and will be updated with trackleak if necessary. On Wed, Sep 14, 2022 at 11:37 AM zhaoyang.huang wrote: > > From: Zhaoyang Huang > > The page with special page type will be deemed as bad page wrongly since > type share the same address with mapcount. > > Signed-off-by: Zhaoyang Huang > --- > include/linux/page-flags.h | 4 ++-- > mm/page_alloc.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index e66f7aa..5d3274b 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -946,9 +946,9 @@ static inline bool is_page_hwpoison(struct page *page) > #define PageType(page, flag) \ > ((page->page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE) > > -static inline int page_has_type(struct page *page) > +static inline bool page_has_type(struct page *page) > { > - return (int)page->page_type < PAGE_MAPCOUNT_RESERVE; > + return page->page_type < PAGE_MAPCOUNT_RESERVE; > } > > #define PAGE_TYPE_OPS(uname, lname) \ > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e008a3d..3714680 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1164,7 +1164,7 @@ int split_free_page(struct page *free_page, > static inline bool page_expected_state(struct page *page, > unsigned long check_flags) > { > - if (unlikely(atomic_read(&page->_mapcount) != -1)) > + if (unlikely(!page_has_type(page) && atomic_read(&page->_mapcount) != -1)) > return false; > > if (unlikely((unsigned long)page->mapping | > -- > 1.9.1 >