From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7060C7EE23 for ; Mon, 12 Jun 2023 09:36:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51F158E0002; Mon, 12 Jun 2023 05:36:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A9BC6B0075; Mon, 12 Jun 2023 05:36:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 323058E0002; Mon, 12 Jun 2023 05:36:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1FAEA6B0074 for ; Mon, 12 Jun 2023 05:36:28 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D81FD1A01A1 for ; Mon, 12 Jun 2023 09:36:27 +0000 (UTC) X-FDA: 80893590414.23.ACBA96C Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf13.hostedemail.com (Postfix) with ESMTP id F259620016 for ; Mon, 12 Jun 2023 09:36:25 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="A/dd5Oxx"; spf=pass (imf13.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686562586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1srm/YkM/y1rMhl0wSOo4B6NI6ClKwyZp1c2RYH4wjQ=; b=bXbPHErw9Mxho7Tf92iBaidmlea9vukJGi1p+4bN2/xw/D+PWYe3jShSFJaDOsnT8b1vEL w34sRjI/5AMR33MGgO0gLLxUJvwzmN9VYTqvw1Iul6GShejx/Rd9UJ2dFvWGlFirWHhxeZ cQDIfhmAC8EfLKhcxSfxcbj3akAu0Ys= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="A/dd5Oxx"; spf=pass (imf13.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686562586; a=rsa-sha256; cv=none; b=1zrtmeD/QmQOgPK4azKlUPotXNSmUeswgDsmNquPCskDCGoHw1WA/hjKjxCczben1EZQSy TKoWOxLez38fo0h4u0L97SwwAn6dsW74oB7si71FmY3XpihCFexFx6HzmRP0yIGIAy3wZ1 UIXlsqHdUd1hDrA7Vg8A0oY/yrMHhKk= Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2b1b72dc2feso46845601fa.3 for ; Mon, 12 Jun 2023 02:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686562584; x=1689154584; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1srm/YkM/y1rMhl0wSOo4B6NI6ClKwyZp1c2RYH4wjQ=; b=A/dd5Oxx90QcXyywj0fYzHEeoVLIByVxrCDYYXtW3teID234UwIXFuW+le3fFj+uj+ SOPVQ4TN0rdzV5DTxHOcheBXC8xcx2/6vCh7OqiMpVjuPNGBiZn+NtvbpvIgMJr4UFZ6 sRG34ZgHY2QrRpi1edKHmtd+aqbkxL9oQ+oAUBO98TJP5tGm0C7oA6fTAtyywPiuAAle orWlixZ8KhcTyhkjftoTLu03WWUHmIOUj+cD9TVUQIJlCNKyJ8JBchP2NsNOtbTEQKok Uc4G3CiA2nWVkGycCgDPHGT06HUBG/tjb0HJEt+Fvt1a01ZdtMKeI+mcM7t2da+KTPq2 TiNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686562584; x=1689154584; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1srm/YkM/y1rMhl0wSOo4B6NI6ClKwyZp1c2RYH4wjQ=; b=gDd097ixfsS1GRJRCybYXivbCC1lVKTUeO0hG2TQ/1Ne1GoXtiv8SiD8BKM4UEnHLh vdmVvueQZp/58sqVIExII6HsaRVHL5VlcgBnee9WHTzlAi9bYv0OnU3VZn2gcEFfY+Hp kqWCyxnW0Ym6DrX57c7UheB0VX+9LZYicmVjl7o+v29NvI7rratmpf15+lD3R21Ah1re d9A0sP23kymQJ09/fioVBGefG/9UiSZTF0rk84o1DCQ/96eWVtkJfw80o8h0qK7BEtqF vsOay9E4JpvqxgVPS3sQWWwiHlWepbm10CCTPi3v/hg9qJ2njbUNiIRf14KIM+9FlvLY G+lw== X-Gm-Message-State: AC+VfDyG3mBNUQJLRAukVgTpBaIwem4QdTm5OOeSCaf1e3YV97srjFs+ +h7P/rqW4/S1TtFwG/p3ZF8KM77kfw9EJ88XCZQ= X-Google-Smtp-Source: ACHHUZ48ioROrY2/C6eDLwiwCkzE47MsMeBSpqjJqJmV9QPCAicvVHhfu8Sxn6AsTypryUPQenm1hZHzMLs1B//yzz4= X-Received: by 2002:a2e:b050:0:b0:2b1:a4c2:70b4 with SMTP id d16-20020a2eb050000000b002b1a4c270b4mr2706732ljl.30.1686562583736; Mon, 12 Jun 2023 02:36:23 -0700 (PDT) MIME-Version: 1.0 References: <1685501461-19290-1-git-send-email-zhaoyang.huang@unisoc.com> <20230609153519.ff01046ef0faff00a74bd5b0@linux-foundation.org> In-Reply-To: From: Zhaoyang Huang Date: Mon, 12 Jun 2023 17:35:59 +0800 Message-ID: Subject: Re: [PATCHv5] mm: skip CMA pages when they are not available To: David Hildenbrand Cc: Andrew Morton , "zhaoyang.huang" , Matthew Wilcox , Suren Baghdasaryan , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: F259620016 X-Rspam-User: X-Stat-Signature: xskonm8cfhk84n4g9nc9jdnz5bc4c7ae X-Rspamd-Server: rspam01 X-HE-Tag: 1686562585-906202 X-HE-Meta: U2FsdGVkX194T8dTES1wOmf8T9f9HFWIooVb1OW8QgHMA6IB5IcL4YDFD/ogngyg/UNJ6eqGKyS6xMZF1jKajPu3YtW/ZFudkC2Cb2bRGt9urEcijYKte61I7E39haR19egIHTDpnO2CsMApWUNzshUx6a/+dmeE97fKUSDUGnkqkRjdGMchigWIEI7jD7P6u5CbDSL/NW9c/D6qbBovuesCWM+4HxWQqOEmJDU6IuvYfYKh1Vyte/5p4/cHM0Xzh8j/z0Vz+8TcpXft0AUyYJZTWoDy6JPm/MBY4TM5jSzMGUw9qKSwHCjzomwvWi6ZBasAjYAVOtKkhsIPhzxXh7Hd6C3jh5adHqCntDBPKobWrBy2yL412byVMS+AC3XRg10ew7DEAWhjJk8wFY8KPErFStP6RUYP353guyW4rdDoc0h2Qio8asEPxuEvESpNpncye7N3KIyoAZknIktJ/XubZdLm1UZSnHzbzER2NkEggzQ0pA5a1Lwc4PN5AYfTk62BuBu/KuWmbabmFgY97z6q6y0VNWGH6owlvbbX5fDEk0eNWlu/lG8Y6LP4Z8Dlh6umuvP7iwrRoUOnRASyVPp086Nq9iQgAGNLAU8Y/Egmqjs0yhXET6+6IlkF5V5+qg+r8yv8fUE8cU3ZZf4p6+5ML3BlphWa6yR2Q8dn1JVupJ7u3CMYbQF+5U1ng46Qfp3Tn9Y4nPIKgeGIxDccQA/EbJi19rHInsvi19H9cYpFnMAvFkeANVqZA3CI2fQro0PJVMBmZLQ3oHihwi1IHTryiYJ0TN5zacro06/VdEBOtYfs7x7ZFPLeNax8bg+vIs7S0NIooQChUN5g0RybyyPSHc+Y2G/Oyl2yBz/gxLVQPn9K3jMhO7sKyUW9yU9BjZRKqV2PNBhzkVEUaDYo+o8h7WoWMkA5vF+9jGgWMvydeJvESpARi5riosxmvOluVAjUXSjW90/cv+YR9kU BwooiyTX yW7qNOikVF+PdqP2YWBoMFicGxC3SO2NeRMKhdMAvbCxBu3CmZwUEY4bcGpzveMA0aAMei6ZhSH7Ph7u5syZfQmAg8qLIPU8hkqSj3o4yOTujKdmfImiEH/qfMp7HwQOlbxCwPfHQHTH/ccaLP2Kxc0xbdcOjG34mvw/W9PP40wp2cvrRabKpUv5uk8hyQ7qWuj9zhuB+Vm4nXo+EZau1CCkO13S5CfHcIwe22MLo5xZe0g6vXyVPM7AkUoTopJV9PHPrnc5abQlznZembWxqvBFoWVBXb7wdSHIIMP/fz7aXZIVQUzc7trGP8LrOyRlWHSZBDf4YGhLz6WqDKy5q4ohUVy2+wFtUacUL4aWCrEvGjsPfKhvxLgMXYXV+uEMslhYQhb7m6lx9HbEa9oR3QXnmAqUtFkCr4EusXNtiguqvBA0GOiDVYWQCxmP616rOdV+z9W86ejZZ5JK21QQ/GiFBUAYz7zqhH0DI2K4/BUhoWh3tmIeSll+YeQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 5:29=E2=80=AFPM David Hildenbrand wrote: > > On 10.06.23 00:35, Andrew Morton wrote: > > On Wed, 31 May 2023 10:51:01 +0800 "zhaoyang.huang" wrote: > > > >> From: Zhaoyang Huang > >> > >> This patch fixes unproductive reclaiming of CMA pages by skipping them= when they > >> are not available for current context. It is arise from bellowing OOM = issue, which > >> caused by large proportion of MIGRATE_CMA pages among free pages. > >> > >> [ 36.172486] [03-19 10:05:52.172] ActivityManager: page allocation f= ailure: order:0, mode:0xc00(GFP_NOIO), nodemask=3D(null),cpuset=3Dforegroun= d,mems_allowed=3D0 > >> [ 36.189447] [03-19 10:05:52.189] DMA32: 0*4kB 447*8kB (C) 217*16kB = (C) 124*32kB (C) 136*64kB (C) 70*128kB (C) 22*256kB (C) 3*512kB (C) 0*1024k= B 0*2048kB 0*4096kB =3D 35848kB > >> [ 36.193125] [03-19 10:05:52.193] Normal: 231*4kB (UMEH) 49*8kB (MEH= ) 14*16kB (H) 13*32kB (H) 8*64kB (H) 2*128kB (H) 0*256kB 1*512kB (H) 0*1024= kB 0*2048kB 0*4096kB =3D 3236kB > >> ... > >> [ 36.234447] [03-19 10:05:52.234] SLUB: Unable to allocate memory on= node -1, gfp=3D0xa20(GFP_ATOMIC) > >> [ 36.234455] [03-19 10:05:52.234] cache: ext4_io_end, object size: 6= 4, buffer size: 64, default order: 0, min order: 0 > >> [ 36.234459] [03-19 10:05:52.234] node 0: slabs: 53,objs: 3392, free= : 0 > >> > > > > We saw plenty of feedback for earlier versions, but now silence. Does > > this mean we're all OK with v5? > > The logic kind-of makes sense to me (but the kswapd special-casing > already shows that it might be a bit fragile for future use), but I did > not yet figure out if this actually fixes something or is a pure > performance improvement. > > As we phrased it in the comment "It is waste of effort", but in the > patch description "This patch fixes unproductive reclaiming" + a scary > dmesg. > > Am I correct that this is a pure performance optimization (and the issue > revealed itself in that OOM report), or does this actually *fix* somethin= g? > > If it's a performance improvement, it would be good to show that it is > an actual improvement worth the churn ... Sorry for the confusion. As for the OOM issue, the previous commit(https://lkml.kernel.org/r/1683782550-25799-1-git-send-email-zhaoyang= .huang@unisoc.com) helps to decrease the fail rate from 12/20 to 2/20, which it turn to be 0 when applying this patch. > > -- > Cheers, > > David / dhildenb >