From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE67BC47258 for ; Thu, 25 Jan 2024 10:10:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 445726B00A6; Thu, 25 Jan 2024 05:10:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CE1D6B00A7; Thu, 25 Jan 2024 05:10:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 247FF6B00A8; Thu, 25 Jan 2024 05:10:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0BFC26B00A6 for ; Thu, 25 Jan 2024 05:10:57 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 70C29408B2 for ; Thu, 25 Jan 2024 10:10:56 +0000 (UTC) X-FDA: 81717414912.04.F3353A9 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf06.hostedemail.com (Postfix) with ESMTP id 9DC2E180002 for ; Thu, 25 Jan 2024 10:10:54 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Q68NwGsG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706177454; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DrCpUka4LE7f28/xZ1+9p8HGvQNODuskxIvCYYf144U=; b=ZDbSHMUSRwclv1GFoEw3xB6Wpc+zZiTWQbQzUC0r3r2YiBRf6/E3Wzq2fx9R3uOg8Ph66G 8sBjAeEI4XhEZgKVHVLh65Nn2hG9fjY+lGLoK42ut01/F3NAncQ2/H8v3786/RJ9k1gzFk 6OwUXlNKtTv+//dk7V5yZT4yyOAvDcc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Q68NwGsG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706177454; a=rsa-sha256; cv=none; b=1P0iHOSbaOnzbLjotNgrV+8agopBC9k0ugs/dP5bo2QM5ZpqMqdBReILb/Y7BbLfkADO9d +Y9k4ZQpPLb+0sor5q8lpkJddpLIC2vugE1gVBi0vET+CuI6nmOaihjoNkqsOZN41puUL0 i/PfwWdHMHOKBbq+KMeNoSv2yWDAE9E= Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2cf1fd1cc5bso20856721fa.3 for ; Thu, 25 Jan 2024 02:10:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706177453; x=1706782253; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DrCpUka4LE7f28/xZ1+9p8HGvQNODuskxIvCYYf144U=; b=Q68NwGsGebQFyfTCQXX+Vm51QKwaH3W+xVrNc/xviNyCGphyAojlwRJPix+TObunmj lJqVzSdz2YagMBbYtdhtXpKmVjhtqJy7g3njH1Ad709Gw4n3s8IcUDG1yMoqv5ml0q7c p2S8039aq+Ivh5fN2FXV9z7ZhKxJiiOxjvGN39e25YmTkOQMceSSKcTMraVzGS2QQO7q bmyDtblerAZSeJmb168qOi8zAt1UXsjhLlCF1APGq/NXCC+Cr4NEJi+KGv67eg6GWM1q hT9fm+KloxdPC/FvD8qziMEVN/A8uUxAhI70M2eUxLyve2WMtuDT4q6VrsfYehtX7Fo4 akkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706177453; x=1706782253; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DrCpUka4LE7f28/xZ1+9p8HGvQNODuskxIvCYYf144U=; b=P12thvZW9mXdOFWNWA/ZKc03LDNo3VT0bDBSdID7wEMcadLR3tVlBve8lYat6cYlgU +AkYitb70+S4V+tYr2MzS5ZQMzjob7Hr2qW/i3qZfkAfZ7Yp260eclDDgpLWB0GqhTHe eVDorVi+UPq8OapdizMAGyxYq12aJG6BDy8y6QGmzhq/MJwUFeqchAcWjDGU0d7cGayT oqlQPRqi3wFKLr6BbB7lUy6plQprkVR/aD/LOcYmRbV5PO1jTREeB5CwGf+U/qh6vok5 BNPR739eJ6EReFdS2LjaQ1tf4D0Y65/gK7hKP3NJr3hIYW7SmYOr9zLulfHBG7WHEtf9 +Z/A== X-Gm-Message-State: AOJu0YzbxXJ4at2mX1eIlpItub7fpYu3u/0oCv6Ouv+2PbTS6OVJ7GWq Ruxko1nNMlZM2HVUX2wRcCMHJhzyQcJFnYRk47RcayDshzCWhuzAalKJ8uRu3ozrAJhC73V8NpU 1fjr5UmICzQkz7nrSer2V1MHYxYg= X-Google-Smtp-Source: AGHT+IEpIDWyl6tFm+r49tMS3Z+8PP4EdyyPXZikf9e6m3sNiCyizIlXH8ymocrkSQalk5NR4qt9fpxCV5mQmwC4Q/g= X-Received: by 2002:a2e:a277:0:b0:2ce:d2d:72a0 with SMTP id k23-20020a2ea277000000b002ce0d2d72a0mr528628ljm.104.1706177452638; Thu, 25 Jan 2024 02:10:52 -0800 (PST) MIME-Version: 1.0 References: <20240125071901.3223188-1-zhaoyang.huang@unisoc.com> <6b2d5694-f802-43a4-a0fd-1c8e34f8e69a@kernel.org> <95082224-a61d-4f4b-bc96-1beea8aa93a9@kernel.org> <15d07953-aeff-460e-81fe-ea7fc2f6145d@kernel.org> In-Reply-To: <15d07953-aeff-460e-81fe-ea7fc2f6145d@kernel.org> From: Zhaoyang Huang Date: Thu, 25 Jan 2024 18:10:41 +0800 Message-ID: Subject: Re: [PATCHv3 1/1] block: introduce content activity based ioprio To: Damien Le Moal Cc: "zhaoyang.huang" , Andrew Morton , Jens Axboe , Yu Zhao , Niklas Cassel , "Martin K . Petersen" , Hannes Reinecke , Linus Walleij , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, steve.kang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9DC2E180002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 7u5ajr4x1te9q3aaghxzaffof8m3serq X-HE-Tag: 1706177454-118738 X-HE-Meta: U2FsdGVkX19aWjKXeuihCQksxeSs9RVfh32WdT1QhDUJebWAOKS/Nq7TZ5rB6+g9WdyJsi5DxkSGbbXqM9kUgCg65kVFWLesgwOWJmNewYB9J46xsZkR27akhCzrphgN7jfSSGCmmyuHR7JC42eQzIi80NQbituZtLUjFFOsj9LV7sEuKNXcHLJ8mTx5Eu1rcRJ++HvxcJSge9xvGebPm1ZC7NGWYE6yAkPE/k/qjIqon7FgUNpdVAapD4QWng1FDwM3P0MJCWzPxbPsRvEK2JQ8xRJk3EWJw42fabeyHh2fACzsxQycT/cDuw3h45FF9HFKJgADQTNnzf+RgpoxKQXLKBC8fDq9GbFKYBXv0OhYLX8wA74TxsvGVyuRlwKUujHbgtbFTkNzS25fLjVZMRH4o+Gsf3BiQ3ZF4pJJsmZ8/9TY2AKEI30+/VgSjDMaftgfi9EdVVw7m1VR16RJSIV6BRK6+OdIDy0R6AiqwW9fvfgbAv2u0gE6Adn9x47SgJITj97gGswefMgQtuCz7aPXkts0fs0OtrBI2YcxIN7wGE2Zi5BA15pMS8EOrPlm6OSUoZ1GtmRpS6tLvxoMTYIZHfLvY/qcppv/6opoNBsPjf+ARxFOZ5LZomcA9c0BgVzGTYBCAJU6H9Fb1mjYvxpsQZeGeuvcYBD0agybepfsLdfDDzU217Z5mx3AOsfKEQr4wsoiifT0S/B/W+p95xo93KB+DqAOry34K6ToM37g6q2Lw+//tn1/TuMNENc1K3UumbcML5YjrwnCKy7+USh9aA9cs7kU+bXBi7xx8wDxqNwSZcPJhT0I6HEZVVBebaolqzezx6GYKbAUPjkC7KsZJyeBj5FQM9zZezdCLg65jCP/gNRlAmjs5IJCaZBTgHgd1ctEbC8hVFB/XIT8/aDEyswnowJR6NnB5q8q+PhmSVRM0KXNvHEDDmH5pYpHETWAn3S8IKjyX80aali rdqPSgH8 zA1AOwQSDDwhxEV3dJ2PS2VKc/+8h7f4FjTDIG5+WOkxVGm64h+e0WxjmaZy3zFBjhgpE5Gvy0ZiqvgNpQvmQzk7kgSyLTNcdpv01d+fgxIUgq5YBJMnuiCxLOgsMeup77VvZT385jf8niJKNZcMpaBYyz52RsJcUqx7nMXahVV8ob3aydpZoemCXjhI3YdLIqAFgNLKGVsbrh5RlhL7F/Nx6bz1wzt/qLg+zjK7LnIsbFyTzyWnoT+0y5aAtSNSq8s6KbwGXQfRp81s/D/YcxD9aMT8+y92wCgrK3PyEhgwjbcNRtpFkW94DHy9b30eLX9pPjLbJtN+fpGOG3TOLqKWmpM0CzThFydEiGA0uW1qaXiOMPlEds6MoWJm8f2ghJ6EuT3/94U4gKkoWGJ4juYkPn7N6Ehyrbk01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 25, 2024 at 5:54=E2=80=AFPM Damien Le Moal = wrote: > > On 1/25/24 18:37, Zhaoyang Huang wrote: > > Actually, the activity information comes from page's history (recorded > > at page cache's slot) instead of user space in step(1) and can be > > associate with bio in step(2) or iterate the bio in step(3) > > page fault(or vfs)(1) > > | > > alloc_pages > > | > > add_page_to_pagecache(get the page's activity information) > > | > > fs_readpage > > | > > bio_add_page(2) > > | > > set your prio here. No change to the block layer needed. That is FS land. Yes, that is what I suggested in patchv3 which keeps the block layer clean by introducing a set of helper functions which wrap up the activity things for FS utilization. > > > submit_bio(3) > > > -- > Damien Le Moal > Western Digital Research >