From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 727E6ECAAD3 for ; Wed, 14 Sep 2022 04:36:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1EBD6B0071; Wed, 14 Sep 2022 00:36:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCDAF6B0073; Wed, 14 Sep 2022 00:36:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A956C8D0001; Wed, 14 Sep 2022 00:36:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 95D576B0071 for ; Wed, 14 Sep 2022 00:36:01 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 690F3A9DB6 for ; Wed, 14 Sep 2022 04:36:01 +0000 (UTC) X-FDA: 79909428522.16.5090312 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf14.hostedemail.com (Postfix) with ESMTP id 2682F1000A9 for ; Wed, 14 Sep 2022 04:36:00 +0000 (UTC) Received: by mail-lf1-f44.google.com with SMTP id f14so22320654lfg.5 for ; Tue, 13 Sep 2022 21:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=rbQPO/ZpUx83BVqTcUPRWq9WRGiF0/a3kr8stv4AT0Y=; b=AzPktmJc0ZWX4Ni3a3C/lXwuHKpiPaI+HekMQ8GCkUoVcbjWCUJ2TCFyLwZ6qPmFpw ZCfNh+2EvGokEkXHRTWMfg+gnabu40a0DT1mmPN2xGRaKOBb+NUu0xvZTF14KpG4Lssk QQXVIzRrKQW1w5HhfFR74NKPApGorGSCFsNZuYnTIHvpzplrWERLos32S+rXfBIU/XaT nJuZIHd0cLW1c1SAuW8z+dTuwxUtSAllK3WXkHan7RKlixZvddaLg6qkjT4fxyX4FqDW /2VKg0s+J0+YU2/SYqnstVJ7fZeJmF2f4pKU3sfPb8CtjkMjK8Fv0QjvgDUo5sgxTzAw tGdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=rbQPO/ZpUx83BVqTcUPRWq9WRGiF0/a3kr8stv4AT0Y=; b=JSUk49Q9akZfUZvOSTZ3FKn3CnYWZPddnsaanu0OU6od2bYsipY1YX3BiEiWlDgr8r cijfXGy15MBOeFIh8MWPPOeqYiMDdE4zskGY9DEQkrPN6VBRdpAwcDIGq7guc5+D4NuO 0UxfwrqeWam0PkL2IhSqLysItRxu1Eyy59mPTh6lnVaF7s3R2X0BoIGjbot4hHIseFva j4cirMxuKWoX4+wc34B+3sbn5CXIh0pY/UCsE0xqZdjRYw2H5Y3MIy84aoGb4pA/Ejfu ZYS3G376o/UvoVz1jN0fpVlJfKYaVjboeapzaCY/ZmdS5KGakcHgsdIMTh6ZGbPooSFd j7wQ== X-Gm-Message-State: ACgBeo07yKZLQZi1K9oJoi/Q6jUyIk5yxXgPEOdrAZdZ0bjrZbyqw7m5 e3zANAp3RntxT9jN3sqjetVzVULbGujQ9A93Z90= X-Google-Smtp-Source: AA6agR6ma+qcE13y21n0LVozu7pgM/Ek6PTgLkOVLaxz9CE6W4rFCufLahRW9O1FJQWRGGm4RgnEhInFgIQWVRe5w8A= X-Received: by 2002:a05:6512:c18:b0:49a:d44b:435 with SMTP id z24-20020a0565120c1800b0049ad44b0435mr3792619lfu.468.1663130159435; Tue, 13 Sep 2022 21:35:59 -0700 (PDT) MIME-Version: 1.0 References: <1663126621-26926-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: <1663126621-26926-1-git-send-email-zhaoyang.huang@unisoc.com> From: Zhaoyang Huang Date: Wed, 14 Sep 2022 12:35:31 +0800 Message-ID: Subject: Re: [PATCH 1/2] mm: fix logic error of page_expected_state To: "zhaoyang.huang" Cc: Andrew Morton , Catalin Marinas , Matthew Wilcox , "open list:MEMORY MANAGEMENT" , LKML , Ke Wang Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663130161; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rbQPO/ZpUx83BVqTcUPRWq9WRGiF0/a3kr8stv4AT0Y=; b=nk/b/d5UnMo7c3NWV6AS0KLlP/M11LCdSecslWEJ2bjNtC+qxQe6OQYNkoj2Z08M5SqbXP LUmeO+xoruT4x/e3CxRd6UIhUNI/a3SeIb10okD5+2VWcMtnBoGzcS2TG2RGykYkM2keXl nEWJ1RjEEJt3F3XnBlan+5f6tM0Fq/A= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=AzPktmJc; spf=pass (imf14.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663130161; a=rsa-sha256; cv=none; b=X+nl0EiCmQlsXMepCqWT7/fSTqMv+fSskLOmwuuWybD4adZuH99P+I8hK/WQhYZ+Tjhbnp 5Rnx1BIMDhlXQB7IL143JOmIH+5K5LJ0JiPUnGgFRL/Sa/TTIrTaRnich1dMygNPlVHZYv FZJpWUasDgYVT2Y9uY3iGVQrF17H2UY= Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=AzPktmJc; spf=pass (imf14.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam08 X-Rspam-User: X-Stat-Signature: mfx69eth5hdodp59psqdxm49ch63egeg X-Rspamd-Queue-Id: 2682F1000A9 X-HE-Tag: 1663130160-610826 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 14, 2022 at 11:37 AM zhaoyang.huang wrote: > > From: Zhaoyang Huang > > The page with special page type will be deemed as bad page wrongly since > type share the same address with mapcount. > > Signed-off-by: Zhaoyang Huang > --- > include/linux/page-flags.h | 4 ++-- > mm/page_alloc.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index e66f7aa..5d3274b 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -946,9 +946,9 @@ static inline bool is_page_hwpoison(struct page *page) > #define PageType(page, flag) \ > ((page->page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE) > > -static inline int page_has_type(struct page *page) > +static inline bool page_has_type(struct page *page) > { > - return (int)page->page_type < PAGE_MAPCOUNT_RESERVE; > + return (int)page->page_type < PAGE_MAPCOUNT_RESERVE; amend the type conversion > } > > #define PAGE_TYPE_OPS(uname, lname) \ > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e008a3d..3714680 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1164,7 +1164,7 @@ int split_free_page(struct page *free_page, > static inline bool page_expected_state(struct page *page, > unsigned long check_flags) > { > - if (unlikely(atomic_read(&page->_mapcount) != -1)) > + if (unlikely(!page_has_type(page) && atomic_read(&page->_mapcount) != -1)) > return false; > > if (unlikely((unsigned long)page->mapping | > -- > 1.9.1 >