From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CCE7C77B7F for ; Fri, 19 May 2023 08:42:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E545E900006; Fri, 19 May 2023 04:42:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E02DA900004; Fri, 19 May 2023 04:42:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCBD2900006; Fri, 19 May 2023 04:42:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BB3E0900004 for ; Fri, 19 May 2023 04:42:08 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 913248099D for ; Fri, 19 May 2023 08:42:08 +0000 (UTC) X-FDA: 80806362336.09.EC01737 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf20.hostedemail.com (Postfix) with ESMTP id B26011C0013 for ; Fri, 19 May 2023 08:42:06 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=NNKcIZCO; spf=pass (imf20.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684485726; a=rsa-sha256; cv=none; b=Lw0ckd7ibRXvLIX3yhSnEB2lmseLN0rlFgR3o7rrI+Uddn8+Z3ZXFUnb37N5Y9i5Ttc38g HIZw73Aecz2uIl2sgIUtXjrjK8JPgvAgayjkNUwf8pWXQZzbPiyIh3x/C7jmFPT6EzdPYP LEskPgcsaadVqavQlvAKuUesiANmBIM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=NNKcIZCO; spf=pass (imf20.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684485726; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5255kXpZcvDfSbdEjjfj0wDzDYeZl9Iyd3E1JVL9e4M=; b=L1SvCLoSwY6SDbbUHgdgF+1vnb9h5PKwh8Pcn04GMPxzloFFrJvUlAOI171kJMODnidM5Q g4Ei9YHfUWlKWKob/oPRRyM3lBv/tUnhqgBa3VHoCC6zc9bwegwStmjZhNJSjiWFz4/Fkk dhe7AyRVU6O+AyRSb0HFL13N1Wy1vKs= Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-4f00c33c3d6so3598947e87.2 for ; Fri, 19 May 2023 01:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684485725; x=1687077725; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5255kXpZcvDfSbdEjjfj0wDzDYeZl9Iyd3E1JVL9e4M=; b=NNKcIZCOcfAL1PGgsRH7yRmuawCJbPolKfHcrOE8wSVubVMg/Wl03r6qGzKy32w2gL wlSJ3He2N5zgBzzw6KLTKxZqI+huyCi/7kf3eBCG/t2995mw8urZlF7SL2lTIgy+yW/9 08+AZajAipppqJSfXjE+Jj6355rU/DoWHUOkmZ+UJml/6nIxK3wxY4wI6PKABEpfakS2 BLfYfpF/ZvB9gVgNbmXGtih/oTexIVNDKLfTvNK1JIFyX1HII9xK0CQai04SlX8EuiWF uiC3sNmfdf4j77T5tFLxuc4iY7RuPbLX9bT/dPRNufj8IBzYPvtruE6jZgezqWTOMfoT g09g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684485725; x=1687077725; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5255kXpZcvDfSbdEjjfj0wDzDYeZl9Iyd3E1JVL9e4M=; b=Yk+V+Bl8XG3T0SZ5J9X8f5zkfddwiHzrnie1tM+X0nZgcN/ytqAT9YjV1E2eP88vR3 mGm9ktooLpgT5Oa2abuk4KGEinc7oOMKEe/+q4hKwCMwlqvk2TTtCELXxuDjG0UBnq8w N0Et5OrxNahMB58cSDG+0/V5xuRjqx/0mNyY6KbCPCSldXWc5ZChKwCzb7jZi8l0xDcE 4GI1EXBj7oA06l/eZdhG0nVE4ydmFMKzP0phcACUIDIh+0EhE2dTLdgq3owxuOd58I2s iSHmIwlaoN27xUkqRD4QTJ/PYrrDWCj3XZrbF0LuRmPgKZM4UHYvEkdRp4kLj0+UUPte wkyw== X-Gm-Message-State: AC+VfDzkUKs+/aBTU1v++XVfrnKwSsjgTaTu4KMsbnOLEnhaAeiCPDw2 hblO6Ck603HxL4XiUvFVNfXfTkAx/GhaLRPM0EA= X-Google-Smtp-Source: ACHHUZ7MDVMgzAyPCUOAhics8HdICRUpTwMecIekZUumpEfCWXG5H/yhNcDNfxhjdaOZwmtG3bz/f+7DQsU/3xURbc4= X-Received: by 2002:ac2:4c8a:0:b0:4f3:78e5:fe93 with SMTP id d10-20020ac24c8a000000b004f378e5fe93mr629179lfl.6.1684485724534; Fri, 19 May 2023 01:42:04 -0700 (PDT) MIME-Version: 1.0 References: <1684143495-12872-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: <1684143495-12872-1-git-send-email-zhaoyang.huang@unisoc.com> From: Zhaoyang Huang Date: Fri, 19 May 2023 16:41:41 +0800 Message-ID: Subject: Re: [Resend PATCHv2] mm: skip CMA pages when they are not available To: "zhaoyang.huang" Cc: Andrew Morton , Matthew Wilcox , Minchan Kim , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B26011C0013 X-Stat-Signature: owwe1hjm3bjy8491e5dwg7as3kyz7esc X-Rspam-User: X-HE-Tag: 1684485726-564352 X-HE-Meta: U2FsdGVkX1/uqQIC2IqcXlFS2NfgHxFhwsjbOqGT6zTAaBrLatjEHiknTUFuiBn0qw/JI12n+DrZsz1eq9OR/esAIhox0rSrhr7I2+u4RB46yt8TGPtMC4VPYecZOq5ZKayM/4cPqBFmlMyqoJSLhICfV3cWjP6lBbP/gdJguerew0SzeR7UH/SHK8Q5Ef5q3kmwDgaAZw7aQYxtmgTXNbBTTARKnKmZN93uCkl6NJkfhIgIl3nOfov0v497TKvHKzXI/HOZ8o8mDDZxH/mCG2M0GxDFjEPHcruHl++HBEirQygg/X1UBHNd368ZWse4b/ZjoxNbO+956ijLjBHpDUm3IVx/O/FnpTa3EKkOsmp2O9+wcbC2KBg4MLTvd9IilyW6e5834uTIpJq5LwsIw2ecKvPHpSWipCcK1ThatX61cYJPqHxu9epIAXnBxelTsLBHKD7KR4dRSOv2/CZfx7na2hDGB9rzZ6zzCqOVLfgcj6JQrsTm3D26+aiFlIAAeEl9HhH0odp2cjXXw5poRfdhyXAMs84VQyLI+6GKS8emvbnXCWw8TXlIf54pV0nvYHex2tUzL25R1PwPVaEWFkhbTO2GQ7Zkfvd66xgmmFQuFn+15s1yB+otf13xvL5pVlj89lONVPh58aZaTFol/LMBL1q1svaxR+TtSbL8OWcSG8tR5h2ZnzAqnMqJCST0YMj5KiQxYjGBWKpnvQj5POyGLiedp3vOpDwd9UZRzkYYA3VTTBtJxF09KbPBkGgQrtABDWis+MGmeDOTz2f803pRSAPcSd6eGZSGCqoB+zh+u8tMvaZ7DxY++RmdtAt8XGyr5GZqr+FcrcZj3zjW6SnHsoJBkR7Kk1X5Gtg+cRFL6rOR4TNn9ZBk3W5JMrFtFPTrQObfwcr87viFg5a8rZ7Mj7EhsdVgqFkyxJIxms2d+a7k2pVWsnqYqSbZP7D+rcJledKEMzKL/Z+vGcd xWlPcRL6 tgsh2N1PK2cSo3dAZ/ZLESM2PZtvp7mj4LYs4T8XkdNxkvUxPdWdZPVOqd4RaE9/TrweZzzxpB1BKsYdmjiUdrdy9klDpKpw6Ixw0p8MKW85/umHlN31DNQ4i9PsYgWjGpyl9AquCFwxrVG/6lEqiYS0lEHNz5g31xby9ykuPxSJnNOBRmZ43D/p2ftcmGdhNzQnY1s70DYJZSisFdvocwEfY9MzeTemHeNyqOLF0v1vmhRvbxrllHuEohHAdujo1EUOsxg5m//mipUwc6Pbf5CfI+OM6lnkwY8DaZmpznnX/hP8fwXglFJ/sdrryN//m7VBUca/dPWUrnv7IoIlJ2bzN5dH2Z7n4xnJ0xVlgY8dMMPiuELK8LG0ZElPnd9/Hacflp5HDanGiK5OESA+UcfmyBVcWSXON+DBZJ3q5aNUNxfDRi/tcPVc2hfZ2c+s8jKnF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: any comments? On Mon, May 15, 2023 at 5:40=E2=80=AFPM zhaoyang.huang wrote: > > From: Zhaoyang Huang > > This patch fixes unproductive reclaiming of CMA pages by skipping them wh= en they > are not available for current context. It is arise from bellowing OOM iss= ue, which > caused by large proportion of MIGRATE_CMA pages among free pages. There h= as been > commit(168676649) to fix it by trying CMA pages first instead of fallback= in > rmqueue. I would like to propose another one from reclaiming perspective. > > 04166 < 4> [ 36.172486] [03-19 10:05:52.172] ActivityManager: page allo= cation failure: order:0, mode:0xc00(GFP_NOIO), nodemask=3D(null),cpuset=3Df= oreground,mems_allowed=3D0 > 0419C < 4> [ 36.189447] [03-19 10:05:52.189] DMA32: 0*4kB 447*8kB (C) 2= 17*16kB (C) 124*32kB (C) 136*64kB (C) 70*128kB (C) 22*256kB (C) 3*512kB (C)= 0*1024kB 0*2048kB 0*4096kB =3D 35848kB > 0419D < 4> [ 36.193125] [03-19 10:05:52.193] Normal: 231*4kB (UMEH) 49*= 8kB (MEH) 14*16kB (H) 13*32kB (H) 8*64kB (H) 2*128kB (H) 0*256kB 1*512kB (H= ) 0*1024kB 0*2048kB 0*4096kB =3D 3236kB > ...... > 041EA < 4> [ 36.234447] [03-19 10:05:52.234] SLUB: Unable to allocate m= emory on node -1, gfp=3D0xa20(GFP_ATOMIC) > 041EB < 4> [ 36.234455] [03-19 10:05:52.234] cache: ext4_io_end, object= size: 64, buffer size: 64, default order: 0, min order: 0 > 041EC < 4> [ 36.234459] [03-19 10:05:52.234] node 0: slabs: 53,objs: 33= 92, free: 0 > > Signed-off-by: Zhaoyang Huang > --- > v2: update commit message and fix build error when CONFIG_CMA is not set > --- > --- > mm/vmscan.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index bd6637f..19fb445 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2225,10 +2225,16 @@ static unsigned long isolate_lru_folios(unsigned = long nr_to_scan, > unsigned long nr_skipped[MAX_NR_ZONES] =3D { 0, }; > unsigned long skipped =3D 0; > unsigned long scan, total_scan, nr_pages; > + bool cma_cap =3D true; > + struct page *page; > LIST_HEAD(folios_skipped); > > total_scan =3D 0; > scan =3D 0; > + if ((IS_ENABLED(CONFIG_CMA)) && !current_is_kswapd() > + && (gfp_migratetype(sc->gfp_mask) !=3D MIGRATE_MOVABLE)) > + cma_cap =3D false; > + > while (scan < nr_to_scan && !list_empty(src)) { > struct list_head *move_to =3D src; > struct folio *folio; > @@ -2239,12 +2245,17 @@ static unsigned long isolate_lru_folios(unsigned = long nr_to_scan, > nr_pages =3D folio_nr_pages(folio); > total_scan +=3D nr_pages; > > - if (folio_zonenum(folio) > sc->reclaim_idx) { > + page =3D &folio->page; > + > + if ((folio_zonenum(folio) > sc->reclaim_idx) > +#ifdef CONFIG_CMA > + || (get_pageblock_migratetype(page) =3D=3D MIGRAT= E_CMA && !cma_cap) > +#endif > + ) { > nr_skipped[folio_zonenum(folio)] +=3D nr_pages; > move_to =3D &folios_skipped; > goto move; > } > - > /* > * Do not count skipped folios because that makes the fun= ction > * return with no isolated folios if the LRU mostly conta= ins > -- > 1.9.1 >