From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C65BC74A5B for ; Thu, 30 Mar 2023 01:39:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9D8F6B0072; Wed, 29 Mar 2023 21:39:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4D816B0074; Wed, 29 Mar 2023 21:39:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3C936B0075; Wed, 29 Mar 2023 21:39:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B3E6B6B0072 for ; Wed, 29 Mar 2023 21:39:15 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8138940DEE for ; Thu, 30 Mar 2023 01:39:15 +0000 (UTC) X-FDA: 80623856670.23.2F61ED8 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf14.hostedemail.com (Postfix) with ESMTP id B488B100003 for ; Thu, 30 Mar 2023 01:39:12 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=m+dHxMa0; spf=pass (imf14.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680140352; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eY8yoI87Fw9sjvQOAcytic4aFldeDuP0KE7rLqC2tzA=; b=X1abMzsV7Ht93YHds9R0HWuOfl6sO53DINaS87O6VMXlA6+oSC8efgVaIZGLxesHJ2mODK vq/58xMNTWEPDvhGyfejHq5PbnAYv4z+Yy9uXAH2CMC1tG1UI3jKZfpHolCDy3UtmBEAxy A6AbpbtG9XLLRivOf6/ECwzSkZpnTXc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=m+dHxMa0; spf=pass (imf14.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680140352; a=rsa-sha256; cv=none; b=6IUSrEAkjd6mry27BB8Dm+5UumsmM1QWxm0tq1gRtpNEztvm50UaZj8ZFZss7DqDCaB94/ w57sBHBdYRXMOUQ83i2CkJXLKlNUjkHaHdWTLsDogtgiWPU+RsQRojydaNPzF9EnsVi7Y8 5diPSbJlJsfxR4hsgvxOEfQt03onyno= Received: by mail-lf1-f49.google.com with SMTP id c9so12171424lfb.1 for ; Wed, 29 Mar 2023 18:39:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680140351; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eY8yoI87Fw9sjvQOAcytic4aFldeDuP0KE7rLqC2tzA=; b=m+dHxMa0el4FJBFdtSzfkNiBgDSQwwDlzm0EI2e0xBVMRsG51xpgOfqs54kTHURZTo xh0uN6A+IPKjUxjgmLF33J5glnaIYQCRpHSHNTWDtxyXtDMCGKBeLHzeza3oSpHxejpY BLemhxxpmKcsYRbbZWFH2NeWVe+4CWyU9J+EHdqYSc/ncVXeofRs40x3LfuAzy4C80bA KfvxgqNtQagprilzWQ9P7GPTHREv9hLZRWdWesh/Or2ti87mb6UTw37gTgCFgyrQooFF /8RR2VKqFJKhOT8UGu88jFxrpZabuJB4VYjTBlDtUHMyebD+8WN0ra+oaokQ4XzTjgHv hJOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680140351; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eY8yoI87Fw9sjvQOAcytic4aFldeDuP0KE7rLqC2tzA=; b=vCCikNE1Bz3kc9s9t3lf1Z4x+gz6KEk9ch+PT4CWSXa/qvZCyyrv0XGIX1mERu2sTZ hTRN6ZSRicMLQGig4s8GipICjKXI8qkkrleqtDsLfungMKBU/p55uuspGytg9FYSoZH9 ILpyXzUMWzeiBcq4SFHc21y0dOUqnfJEhIu47x3/QtfdjMJhNMMo9ysv6CZGpNiwxUbV 01be9ex2EMQGW8/AL+xdRtfwq/o8LIntKwIEfPVhSeITxk+NvSVqHUo7VtuiD+53Tfo2 2WWFQmyrjEH4XLZVYtxzVR1oxzy8gXKYPosi6DC9oFy0d7tjVLU+0VamXVzdQpKUu+Tt gmyQ== X-Gm-Message-State: AAQBX9dIwCnyVwS35t4QJjdqPMLRS2JLwn0Vi5YtxRmzfQEJTzSMkwmc KSvZVQ2xSWVj98askDgPHwK7X2TRVE7Q4f44sbQ= X-Google-Smtp-Source: AKy350Ys+tRkZDDt8zOnNuJUAayRnaxn+bx32fPsSuqzbylKPXs526Qy3Ps4UQKgKBP7NvUs4Wg5QaaDV7vjBIegT8M= X-Received: by 2002:ac2:4436:0:b0:4e8:9049:b640 with SMTP id w22-20020ac24436000000b004e89049b640mr6389757lfl.4.1680140350794; Wed, 29 Mar 2023 18:39:10 -0700 (PDT) MIME-Version: 1.0 References: <1680086855-7989-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: From: Zhaoyang Huang Date: Thu, 30 Mar 2023 09:38:48 +0800 Message-ID: Subject: Re: [PATCH] mm: mark folio as workingset in lru_deactivate_fn To: Johannes Weiner Cc: "zhaoyang.huang" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: ohbaehc3m3uo8m4ebrk6xzeemnno7ikt X-Rspam-User: X-Rspamd-Queue-Id: B488B100003 X-Rspamd-Server: rspam06 X-HE-Tag: 1680140352-766601 X-HE-Meta: U2FsdGVkX197C+NqQqkodiTS4prht2n4OXoDSCa448y8tlswtqofvx3vGe7EO9yb9c4wHuQGHaEA/R0zpWtQpjog1LFhu3Jbt/4weSgkBKMcM9o3Wj9+D4fjtB+msvk08UNBTitQyzn4A+BTaD4hW7RkkB0ZOAlcXf4oUnBEYB0JkZCxHO/zM0YSF9fkYLnUWXyOTIg3zHDy2BIoV3n7MX7FdpQYryV5zNvhaWe4F6PUl+GXSMlSnVmTxTgHQ43rzgS3UEK5I+85/KfgcbPEHl/7nvTP9YRYGjK5wYCXTAIhTcqLI5+jXJUt2c/HonbaeaL8hIoBIfLNyfIDb8tSSxMt+m3mWULl+xxSwvHSxgJRziatqSbQnZDwKg9AK6qBo3PZglCHX2UudYaPRNV9g9+qybru9zfUCBHi3GFvS90Ccp7QR4qpCKmzNu9PJYfTDtGtNjqXaEKnj7qZrHV/ym4RX0y8MeUAby+hSNNqE/ugWut2hzaKCkp8PJlW0ivjP8R6IV4N1ovFgSgaTJ4KSf2G7+QIhgv47D5+4UchbMrR8Mgze3Hvy0k4epi6rK5e6KdyotELnrXdnAiArzf2jNz88l6izyARmP2JJgjJOlpzPZ9G2mCjLqmS4N/y5YNXz/u9IZYan1It9e6/TfTJAu/AQMVBcs3mvrMbV9RjE++NP6xr64DNsc+q/TSChWYR8DhDHMOGsdcMSho/EGgCQrfA6yXjxtbNUr+AWOAyz6tv9VmCT7yJZ+ntt3YkwqYr/sWovxkRtIeDKZ7vbCfQ83gRyGavDZtvCoSjZSLCXGpygncSUJkjMRke01ALK74bjXe53rVbV452DOmGeZB+uxueu7jzXA52Ui3r3/wf4GotMdRQhWdwSzvyi9tUQ+iOiCtSXo1MZuJzumRUWtaLciMLjrXN4c17+jtSET9lk5JMpo0KE2FBhx3/8D6+bxigj2FsxRzssanHUq5juDV rF6MWthZ drarNmJ8QffRdqME2x3SWD9V4J5Wib8nzPWrKuxxWgM+jcMDd9UZp12Tfiel44lbN44qwPr5ZMzM31diylwNY0Ha0hx7KtxgdUz1V7KaAkSKzex858VLXDC+mw/5YdO43KchZb6euv1GvM8CvX6JHC64ZAZVFxBcbBfcC154S7Rob852srJUXwnf7QhiVzD7tiMc26Bq77znJ7cRWZz8qpBJ3sIkw8FfG+NZBJf7xzKU8lbffZGzwHtKKiEhZr1ydflZcciYy2GIGhYHt8UxvS3vogugabA+P0AsCcejai77I85Tn9EQv5nxfeDcExCsAkzjcZJ+GYK2moq6oOcT/y4DNKwaBTGZFjpx0+no53zRzEp+7n/EUHobpb/k9NpG0d6h65GogbOfcSHC9KJ7RmhBHSP5P1nMFZH6AxRbvBJJKFUoapPUQ3ZKFeNscMQ3ARfPBGPUrBmW1j5ERV2gVYWOMilM7BJcmWr063eM2Q41KEvTRb1aozd4nQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 29, 2023 at 10:55=E2=80=AFPM Johannes Weiner wrote: > > On Wed, Mar 29, 2023 at 06:47:35PM +0800, zhaoyang.huang wrote: > > From: Zhaoyang Huang > > > > folio will skip of being set as workingset in lru_deactivate_fn. > > Can you please elaborate why that's undesirable? What's the problem > you're fixing? If I am correct, folio will skip being set as workingset when moving from active lru to inactive lru, which is performed on every folio in shrink_active_list during normal reclaim.