From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71B9DC77B7E for ; Mon, 29 May 2023 01:02:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9749B900003; Sun, 28 May 2023 21:02:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92546900002; Sun, 28 May 2023 21:02:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7ECCF900003; Sun, 28 May 2023 21:02:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6D51A900002 for ; Sun, 28 May 2023 21:02:50 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 307831A038D for ; Mon, 29 May 2023 01:02:50 +0000 (UTC) X-FDA: 80841492900.03.60B9749 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf07.hostedemail.com (Postfix) with ESMTP id 312834000F for ; Mon, 29 May 2023 01:02:47 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=rVTEkTtn; spf=pass (imf07.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685322168; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YAOt4oPartPpVs7vXsp6wFuAa9Ek5s4xyJ3hrSVbVOU=; b=FK9B4SgQ0aPiFoInUFCLoBy1B2zbyYzY/Oj/i5AIbvd8nEQ5ExOb2Zsmj3pGi0mcL5D+/L PIZ+tdm1vVoP/Pz+mqd3DjHGviEYaGbmP+odAZgHu6BrOmxm8nJ24jLV2iO/C2lJ+G9+54 VtzEN6ousI3dUB8+iV4Gk1loxz+xPIQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685322168; a=rsa-sha256; cv=none; b=oMycDQjVQe2Y3hFW2nZ345/QxkfrtT4qYOA4hA357qz0sL3wdy4oCF+T82jlR6CmG0nwmT 7gr++GvBzeLqrZIerN200e3+KwWIJF1hvzvmtLDZGGblL1GVXgFmk9+6l9LFDOR1/maRGq bxZkIGq0yW7g8Uf+4cTbn2ZwRv9Lh7c= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=rVTEkTtn; spf=pass (imf07.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-4f3a611b3ddso4900108e87.0 for ; Sun, 28 May 2023 18:02:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685322166; x=1687914166; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YAOt4oPartPpVs7vXsp6wFuAa9Ek5s4xyJ3hrSVbVOU=; b=rVTEkTtnG+GrdW1F+fDgHzrXaUR1GaSlS6ciAD57OSTWwfNzbO8LU0jRTg3tnBFlYc JEpIHdHD92XFqWlEkmD6jNPNuWfbmtKAZ8IvVQGp6AS57kdNzyvkOsDCg2irWyiIq3Pj fO6LHc7f0I9srhYAObHirfVX/NiQqrKBRO6+cgTAhde1Yz2+SjiLHpBv+dyC3Tm+u2TQ TVMTH1P6DrtEFwz8Kg2bzjSRVLzOgrzNGch7+A3kyhqWMKsASa3k0TlHU5COLR2cKxk7 iA71B5+JNBqHDE2jH/FxczTxejr5AR6ILvIRfC9NSDrdw+jLPgh3g2xFXCT2MzHri0kG c2Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685322166; x=1687914166; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YAOt4oPartPpVs7vXsp6wFuAa9Ek5s4xyJ3hrSVbVOU=; b=bSzudgDVjROg800Ew6hYd0tKdTqPvHOAm54PjOMcx58HiIOfstI6sK6eTtLHfAZIzQ 42lzCw4y/ZFYP/3643FFwQXTbEa4N1OArrOnhsLgjAgfurqZTh0k7L95YW/sthCVReaP BdGKc+VGhtjRohbQlzDgQSKN7uT4D6kohj0ON+teylvKKsZd7E/KkRn9kGS7kubii1Gk vJxvuohHEY8dIoQG9pDkNkl5dLT0ARQ4ZSXUSk4GVxi72yutwNEOlQXCspr0q68fdS1D 8P7RpDIzLURA+WJ4UpQDFXbQjfI0dYjULGM8OskMMCZ/35/orlk55f3gh2myYNw9zacl GWnw== X-Gm-Message-State: AC+VfDxCOtuyqtDfyS6r+k4tolZ6iOg26Z0GaN9naFoW4hwsJa0eJ8dn fitJxRuNMDL0xJ9b/8nCBMQlnMREdtFdhtmbs7Q= X-Google-Smtp-Source: ACHHUZ51+MI8VdUitklbGDRvhdM0M9Kgj0kEd8qnZI+fpI1g3YEiJzoT/ShqA8Bj9VXiy2w6GGri4ILmDEQWDe3DAUc= X-Received: by 2002:ac2:4c0b:0:b0:4f1:2ebf:536f with SMTP id t11-20020ac24c0b000000b004f12ebf536fmr2463186lfq.16.1685322166039; Sun, 28 May 2023 18:02:46 -0700 (PDT) MIME-Version: 1.0 References: <1684737363-31554-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: From: Zhaoyang Huang Date: Mon, 29 May 2023 09:02:22 +0800 Message-ID: Subject: Re: [PATCHv4] mm: skip CMA pages when they are not available To: David Hildenbrand Cc: "zhaoyang.huang" , Andrew Morton , Matthew Wilcox , Minchan Kim , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 312834000F X-Rspam-User: X-Stat-Signature: ay48krdcfwj7bfssqef93z94d4u7hrti X-Rspamd-Server: rspam03 X-HE-Tag: 1685322167-432103 X-HE-Meta: U2FsdGVkX1/XpMgEsCl/g/hejat2Dpd9Zxqk9IstJxCHTSXhKcLBZ+Mh+OGgTf2MX3+aFLFTMvvTvN7yIc4YAdxBT5Y7SnAqtkouEBXlcdTUUoeNwx2qOAafAgeyo+bpm9LUjm9aPM0MoMvYLYelzbxw/h+DIlbt2cl2H3ehtdZBGS7g9gFvzYcKYigB4hmLZbdPP3uEsy8D7wbuoXMkxxX8w7YQwpEqQbbHQnzUhMsR9AY13lLFfiILXS7CJ//M/3yyZ+0EHqjQiz2UYb6FBzTEII83BkC9KbCuNYydTGQBei42R1BNfS6+UwR51yF3VfsxozUWDiYOqGgEMpT2TORWuxITjjTkV+DQ7G64Q5Pd0CVHMT7xGkfjIYMfTyz/f+mSU0xZuzNUFmKYa9Tbrl1UI3rGHgmtyY2ML5qvw4lKwuaMPbAj1+ZAMygwG8+9sls7DCUQbqpV7xEWBvwhNqYDqS1Oypz1xN1Q1v0LcfnQpLaHtpcdUib0//45eo95Qzs/dP8Xcl4d6wvbmQOcs+EfP1Eb3xPd05ialNeUtDU8VS2TiDH71Q7seoasCPLXQLf+oMBgNGbW2cvSBzesCehWl70kEoH18Td/DsxN+nbLpvFtjET2MJcHfSNABqPmVT/0UBuJZtwBFlHR1F8mLWDvwqaq3/96Sx/sddpjhmjs79CDRua/lFKM1mBhD8h2DfpYAKIaeFcp5uaY3Gj0o9UNhCLTKkQ2dZH0r5yKQP4ucLlh0DzshfnxAyAEeNpGtTqvjTNtzGkSiexnNjevJ8ZtTqDnxDPfu7bR3+rfA8jLPm3giS54MLWllKuOxidRPJtwbUMLBDGfKCk/3i+QTEd3m4VRXP9YvsTE/wYj8mmkPnB/4PMtMEkQ5Fr1+FnnCT14aDpOoxm+1T0hA3v5muTGM4Ga/XJZQndaSqWfbJ8aOC8uQEJBlGzGmkalkM6+91l+eGE3RUbVfnybxQs CdT6veVO /VTbx36FJWyRmwACyIBledptidjRKC0M/7w/s5DL+JrKxGH1lU69xkw+J55r70DehJFAj1YnxY/r5gJ4XUC+g3GWcMNyzVFWDuPoAJ3u921JIgMQ41GZpVwI735yczWW382NtYtNJmYJ4MdxteriM4+lFDxtveXxEOKXsCuSHIXCfnhNgIzzGvTq9BVs661sZWBz0BtM9OURqBLW2Z65T1pdRSlQ8dnsaVrEtHyZmt6IC5PHy3estxZJ65qWGc1BssiKUwa9Z4PqJwwiMh2bT91qFZ3xmspIfJYPruBOUjsAXZHO8p8cNFJ7GjlPGZXpQhhXvOUZzGb+qS0pkU0uL/FDg0uvj1TSpWDntnoLiVaxkF9SJNxJS0o0ya5EnIeg7uu4ZLZzO4ZuIH8KVBzgABfMMa6o6PflnaQFTkQGY0cthhPYTT0hzp+ihzg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 27, 2023 at 3:36=E2=80=AFAM David Hildenbrand wrote: > > On 22.05.23 08:36, zhaoyang.huang wrote: > > From: Zhaoyang Huang > > > > This patch fixes unproductive reclaiming of CMA pages by skipping them = when they > > are not available for current context. It is arise from bellowing OOM i= ssue, which > > caused by large proportion of MIGRATE_CMA pages among free pages. > > > > [ 36.172486] [03-19 10:05:52.172] ActivityManager: page allocation fa= ilure: order:0, mode:0xc00(GFP_NOIO), nodemask=3D(null),cpuset=3Dforeground= ,mems_allowed=3D0 > > [ 36.189447] [03-19 10:05:52.189] DMA32: 0*4kB 447*8kB (C) 217*16kB (= C) 124*32kB (C) 136*64kB (C) 70*128kB (C) 22*256kB (C) 3*512kB (C) 0*1024kB= 0*2048kB 0*4096kB =3D 35848kB > > [ 36.193125] [03-19 10:05:52.193] Normal: 231*4kB (UMEH) 49*8kB (MEH)= 14*16kB (H) 13*32kB (H) 8*64kB (H) 2*128kB (H) 0*256kB 1*512kB (H) 0*1024k= B 0*2048kB 0*4096kB =3D 3236kB > > ... > > [ 36.234447] [03-19 10:05:52.234] SLUB: Unable to allocate memory on = node -1, gfp=3D0xa20(GFP_ATOMIC) > > [ 36.234455] [03-19 10:05:52.234] cache: ext4_io_end, object size: 64= , buffer size: 64, default order: 0, min order: 0 > > [ 36.234459] [03-19 10:05:52.234] node 0: slabs: 53,objs: 3392, free:= 0 > > > > Signed-off-by: Zhaoyang Huang > > --- > > v2: update commit message and fix build error when CONFIG_CMA is not se= t > > v3,v4: update code and comments > > --- > > --- > > mm/vmscan.c | 23 ++++++++++++++++++++++- > > 1 file changed, 22 insertions(+), 1 deletion(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index bd6637f..20facec 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -2193,6 +2193,26 @@ static __always_inline void update_lru_sizes(str= uct lruvec *lruvec, > > > > } > > > > +#ifdef CONFIG_CMA > > +/* > > + * It is waste of effort to scan and reclaim CMA pages if it is not av= ailable > > + * for current allocation context > > + */ > > /* > * Only movable allocations may end up on MIGRATE_CMA pageblocks. If > * we're not dealing with a movable allocation, it doesn't make sense to > * reclaim from these pageblocks: the reclaimed memory is unusable for > * this allocation. > */ > > Did I get it right? Yes, it is right. > > > +static bool skip_cma(struct folio *folio, struct scan_control *sc) > > +{ > > + if (!current_is_kswapd() && > > + gfp_migratetype(sc->gfp_mask) !=3D MIGRATE_MOVABL= E && > > + get_pageblock_migratetype(&folio->page) =3D=3D MI= GRATE_CMA) > > + return true; > > + return false; > > return !current_is_kswapd() && > gfp_migratetype(sc->gfp_mask) !=3D MIGRATE_MOVABLE && > get_pageblock_migratetype(&folio->page) =3D=3D MIGRATE_CMA= ; ok, thanks > > > -- > Thanks, > > David / dhildenb >