From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 590B0C00A5A for ; Wed, 18 Jan 2023 01:49:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED00C6B0072; Tue, 17 Jan 2023 20:49:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E80376B0074; Tue, 17 Jan 2023 20:49:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D47E46B0075; Tue, 17 Jan 2023 20:49:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C579B6B0072 for ; Tue, 17 Jan 2023 20:49:28 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 979AD1C609F for ; Wed, 18 Jan 2023 01:49:28 +0000 (UTC) X-FDA: 80366237616.29.32EF4F4 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by imf22.hostedemail.com (Postfix) with ESMTP id F12D3C0004 for ; Wed, 18 Jan 2023 01:49:26 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=boIYGE+m; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.182 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674006567; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EofrsKclU1Bd3gKxPPxphmvSRJzHoKFWbRAdp5SlbJI=; b=iQswMkdZcHxkN+hcQWHlcgqEkwwqKHnL8+gBnBAq63aOFjdgKjYvUmlvzAKWAsIWza+1CI 1AOTsXYZYHJ9FodMnwh3qDWAAb+xGASEpn6YMw51KqDzKIBeMxsaovw1m7ZyjtE37B2W9x eMT0nyuDgbkx8UCF0kOPjikL8ZyPlc4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=boIYGE+m; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.182 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674006567; a=rsa-sha256; cv=none; b=HzT4GGutrVw/+jUz6EB2R7b1ZEfLhMhyD/lfDDAy779YfpBLgeXevv8396s17tFwinQ5t8 rpzU/M+kwuQPb2BlMuUXjOwT89ifBVi9qY0/s1xUtb2Fv0MmPzCl3RRJwzERbVqSdpDdd/ IK5/sCjG3IrAXj3JPW/9IHGovbE0XvE= Received: by mail-lj1-f182.google.com with SMTP id e16so8213827ljn.3 for ; Tue, 17 Jan 2023 17:49:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EofrsKclU1Bd3gKxPPxphmvSRJzHoKFWbRAdp5SlbJI=; b=boIYGE+m3kCDRxqRd/7+64o/AV97y54ui0V/gJ+LcZtZQFDolp9kiY0orqv9r6OoWz 6WvVy7YJDD4saHCXC0p38hRhEYs3CITcGcu4PaFl/KhTs5bo3Xc5xn4pZ1o7Cx4KSBPL e3OROPvSLfcbPA64tDnupmGitqE0lDZs2hwSQ76OLgO6ioV0sll70E6e7nX1QIFQ74TS H5pOEeCnxYiVT3694FMkgGVSCdfx0ogjR2AUWGwyZDtqfqu3i0gNAYgVp2vUQ9s0arls w1sf23ADKa46AMgylZG/XezZgu6Ah6yauYwEieEp7nj8hu418zEn8eLHvmadNFgrqiF0 qaTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EofrsKclU1Bd3gKxPPxphmvSRJzHoKFWbRAdp5SlbJI=; b=Rw4gnZvV47E9gHz7RwfsszJPPC7BScCyQly1vL100AanSsgafxQvnkBvzUa6y/kdvu nEBwOWa3tGck4K6rbo/i3pKoIRD8uPgXUHwklhVc/+gYI0k5e0u/On7SdHGzDgz7sc6y 81ZfE173zJYiD4zmXAuCqNNhnsvOtTMSwvKL2Nerk06PFcJXqja7nBbMOrDCXrmJPHoj yM9DRyIS0IrRt70iPWY68u/OgqbNxZ2kK06XvLdbur8cHAp6qIKIzG6KEh2kQKYayHxa YEvdraVf2CV4ZO6dF8rBt2Hk1mOuG2/3G7hqsoD65eJu051o1q1sNao6zmP9xA0ZFrw7 WsAw== X-Gm-Message-State: AFqh2kr2VIfc+Ync2BdLPVh1gANzDxZRwi24OeeCu7KtjxoLiMrHB7tg loFfpDm2lsZe7D4jJeSyOFOfH78F6Frncg4rasA= X-Google-Smtp-Source: AMrXdXtOClVIp1XhZ2IuXdLjsnrX8fXXvUg+8qrxI/0LmwZXgA8uFMETv75h/57JZoWdiu1DERbX/HGKuAOKcji4vc8= X-Received: by 2002:a2e:a49a:0:b0:28b:6abf:29ea with SMTP id h26-20020a2ea49a000000b0028b6abf29eamr464639lji.359.1674006565275; Tue, 17 Jan 2023 17:49:25 -0800 (PST) MIME-Version: 1.0 References: <1673943112-8620-1-git-send-email-zhaoyang.huang@unisoc.com> <20230117161731.ab69c2352a62a0693570cf70@linux-foundation.org> <20230117173145.867a06c1585728da1e9b6a54@linux-foundation.org> In-Reply-To: From: Zhaoyang Huang Date: Wed, 18 Jan 2023 09:49:01 +0800 Message-ID: Subject: Re: [PATCHv2] mm: use stack_depot_early_init for kmemleak To: Andrew Morton Cc: "zhaoyang.huang" , Catalin Marinas , Vlastimil Babka , Nathan Chancellor , Peter Zijlstra , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com, Mirsad Todorovac Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: F12D3C0004 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 3qhik5g14n3p9g3gq4whb767yxzupzj9 X-HE-Tag: 1674006566-175599 X-HE-Meta: U2FsdGVkX1/RZt4QOGyhrY4y0vEJeo3uy69xOXe1KvP9M2+sz0OU9Gt/dSUh8Xz8r3axmdC98dtLKtR3hhueCgQXCvnP5d5ZWzbqHru5LTVxbohldOT2tramNZkUhhm20n1AyYJV0pl3jPfTC0Gmn695zoJr2jSExSvcLyfVASat19AGbtzwMDv61Cy4TVM0Ig6ITwXKQGxjKB4axMlC72o2yn7GTi7wtZR4opVDcY7PjMIP1MpVsKXad1GHQx27LIlJcNKfeyF0osIZ17hkLq/WzQ1om2LdruRMoWLLWt7ViOXTFhW1OTljGXUTw9yW/xDufInHfXdNSy4A74KvVuRVM2Y2swcdHhpJ7DkLgYFMUdWcZ7o/yF89rnQyAlJx0Vv7kgYjf1KLoeV4Bdv9u/iweovQDmK+DpaC4bGnzOQe9NGp5DPnhasShatRUc5uwXBcrbEfX1TLfPRceqi8RgWIQQ1LIDocRT8EvWe2XcpzEGivYaIDuPHxQpOWNfcRswty5AF8zOb7f92dbXSDJUn69SGgOR5AItd1VKK0Tr815vw74/cgKtNdQhpleLsUnw7U4HL8yZzRktbJ+e6fuanSO69OYWlsKXbZFU+cRZtf+eVw96ExTCLT2SpXCRahC8thU4JyOwKc0fWc8ecVdjBTcp4DqI3vLQud1cyeXQL4R6oMqsN6uLFJf8NQ6Ws+Hrta2pWFgy6oFgnuLWHnGv5E1zsi3eK24z6GhIpPyut5PBNqvYQssl666iaGsU72UJ91RDyPvoOeYY0dsgDAyIHB2Qpf1BNMMkxTadw8Wbmm572ziOQ1GZ1dHbPRoNHvWpP33firMl20Qn31IZkkjl2laZ3XYUZ/LqgoNQkXfswtj+09Z+DYfytYRfAIXZ4kvYkTUTHDyIwxCN/BghmBPPhX25Bm99lG1wRqME8gaX77Wpo4vhF2vkYbMwF5YXyz6fosE7dOYkZs+hf7s7E ypuKoL7j RAkhLT07DHBYaJ2c6s98LhsBa1clDy9/T4KAxcGAyJF8VnW/z5IXzR/f5BSquOpMeflslRhZsJaGFl1mBwEPfxwgdD+sJw4Q/caRC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 18, 2023 at 9:40 AM Zhaoyang Huang wrote: > > On Wed, Jan 18, 2023 at 9:31 AM Andrew Morton wrote: > > > > On Wed, 18 Jan 2023 09:25:48 +0800 Zhaoyang Huang wrote: > > > > > On Wed, Jan 18, 2023 at 8:17 AM Andrew Morton wrote: > > > > > > > > On Tue, 17 Jan 2023 16:11:52 +0800 "zhaoyang.huang" wrote: > > > > > > > > > Mirsad report bellow error which caused by stack_depot_init failed in kvcalloc. > > > > > Solve this by having stackdepot use stack_depot_early_init. Extra Kconfig also > > > > > done by moving kmemleak stuff to mm/Kconfig.debug. > > > > > > > > I don't understand - what was the reason for the Kconfig change? > > > The items related to kmemleak are moved from lib/Kconfig.debug to > > > mm/Kconfig.debug > > > > Well yes, but why? > It was suggested by Vlastimil in a previous comment. It makes more > sense to have kmemleak's source code and Kconfig items under the same > directory. > > > > Is that related to this bug fix? If not then please let's have that > > change in a separate patch. > The moved items are updated for this bug fix. sorry for my faint. I will make another patch for Kconfig changes. > >