From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC387CEDDAA for ; Thu, 10 Oct 2024 01:28:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 853AB6B0085; Wed, 9 Oct 2024 21:28:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8040B6B0088; Wed, 9 Oct 2024 21:28:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CB396B0089; Wed, 9 Oct 2024 21:28:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4B75D6B0085 for ; Wed, 9 Oct 2024 21:28:23 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 821CAA1B18 for ; Thu, 10 Oct 2024 01:28:17 +0000 (UTC) X-FDA: 82655957244.05.8AEAB27 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf26.hostedemail.com (Postfix) with ESMTP id AFFC514000E for ; Thu, 10 Oct 2024 01:28:20 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LgikiKLK; spf=pass (imf26.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728523519; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VlaT00TYnkVw/cLCmAFB9f/ich8Z222RWy8eT5SZDZE=; b=4L3EAhJ5KoUfryPg0cq87StayqUXp+GLboWYv2Ei0H/TaoOMX2zS8J2p6TBYnZsrrfCgDg y2wu8F+JHPlj8rPa0w/nzqn/+T0TX8qpPwHB/xGXJ2CwE2EkmJqrjQ0UtbbGzH+j6NyA+l 5VYFqTUAIXma4SrdgNhtR4cIZx6ti+k= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LgikiKLK; spf=pass (imf26.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728523519; a=rsa-sha256; cv=none; b=20SPXkWYE/v3BKCbJPSpSrP06hz/BxydERsBC1cgH8ON55eOOLfetHTDTf85XuV0Ie90z1 +TvSKMHRjW7O8jzECK8VhpQUydI7A6PaWr7vC6+JIlTkpfOZbEFFt274PrxVItVqWiDGrX g1/fY7pAoHA5UcZSNA43ffTfxKcwmIE= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-539a13a6e67so60883e87.0 for ; Wed, 09 Oct 2024 18:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728523699; x=1729128499; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VlaT00TYnkVw/cLCmAFB9f/ich8Z222RWy8eT5SZDZE=; b=LgikiKLK9uvCLLarzq1hefSB5mb1cAbQn56ljsKamSgUES3R5LSOFmuGJABlCjMgiK IoFcWQ1QSsNb9XuCPG35C0rNwSdpxmB2dnRzpI0Kgq5jcUVR1piInStq+fkCMhJUZmUm 962F7pkdCTDpbEIFBZ0eGF/Gu2cVsLjuFhcl2dukA7lkK8EDZHID0BDzEeTZA82t0oFI 7bsuiZr1c1xZwIFbaLPsrqYdRzGk948+tt8qrdtFpnihRU8C1dbYMGoCGZTRbhebpnOJ VLO2IQ0pvCZXW7pjBewg2CtC6kxwXWsgXQE2sP+wfe/wpdhNVpLAXpPIL49X1PXnZwKr o0Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728523699; x=1729128499; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VlaT00TYnkVw/cLCmAFB9f/ich8Z222RWy8eT5SZDZE=; b=FXgVArd0ukFnFtU9qF70nvApYvxXISm3VQBrKcDJj0P86j/e0E/xebKvvf51NmfAdA kGtL5xOm3mZSkKSOlVOHNsK7iQSj/fQhLZ4SM8xYju2nsZABV0gVV2ZUBkonfOs/E/Eh YDPQTCUinQ7FGa0yjsb9Bano4hXZ01G6GfGmPsVrDTz2hkkEuyrpRB2ZNzpw5XNkOvmg MAQjX/wdAvE2+XdpBqrNbNNzN11vdcK4/W9UUrhMVfdXdzC6FpzPsk8m2OEoByHGSOXB MnujLlEmxcbyFP+nwFC2mq4MHZg5fVXb/pltEJ+VxJlH7D+1U+kEpPluol6cHtoNPVIv 5lxA== X-Forwarded-Encrypted: i=1; AJvYcCU4Zxat2OgwnZGl2MbBZNld1tNLGMbfFUJYwEnoGBixSjYddpKLNWHyCwqmvYVvfiDy0Zdr//DhNw==@kvack.org X-Gm-Message-State: AOJu0Yx0xuRF407skhbbpPv6TokJNMDti7UQv7/9mU1KH5YXU+EqHqGJ W0oOT91Ufm0IJpZQ9d8tvSQNJbywzNg3VYDp8PC5ApedyB6/Va9yOYoaQdn+hiy3dcu1FS7al/c GxykKPO0+yqXomWXeGSuMrtn6KVA= X-Google-Smtp-Source: AGHT+IGA8D4d/NKfE3sAHW3yv8tf12g0swxPE5fwD6W9LctvR9eXNFEcWIB7pKDIgeLKGG161xVsRyF0AMYmeA6bpOs= X-Received: by 2002:a05:6512:1327:b0:535:6a7b:9c03 with SMTP id 2adb3069b0e04-539c494a024mr699845e87.6.1728523698840; Wed, 09 Oct 2024 18:28:18 -0700 (PDT) MIME-Version: 1.0 References: <20241009074953.608591-1-zhaoyang.huang@unisoc.com> <20241009135252.53276de999d3006a20cad21c@linux-foundation.org> In-Reply-To: <20241009135252.53276de999d3006a20cad21c@linux-foundation.org> From: Zhaoyang Huang Date: Thu, 10 Oct 2024 09:28:07 +0800 Message-ID: Subject: Re: [PATCH] mm: throttle and inc min_seq when both page types reach MIN_NR_GENS To: Andrew Morton Cc: "zhaoyang.huang" , Yu Zhao , linux-mm@kvack.org, linux-kernel@vger.kernel.org, steve.kang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AFFC514000E X-Stat-Signature: 1sj6bbihs83ztnxk7ikdqgyiy3y6sidm X-Rspam-User: X-HE-Tag: 1728523700-988843 X-HE-Meta: U2FsdGVkX192Ysftppz99BwJZMCPnsbWQvHjIK+hVI7Vyt3q74KGTBqwEePRUihgZOR993gz3GmXtmaON3Uoq2Z+ZdbBzKonLSrrlpzZ+qXUyiKuQ6l1oYYuVCo/YA0/E9jlakqMFcdwQED3RD6npZtKjhQaE3COV8kk0t7OqcI08YUOktadJSE0lN+kgYSKIuCW8s4rwQsOiTEhmpPugPbqm2BC2B+GQKqEsiTJp8XBsC3qsAKM8+oh8cGQamGOC+sJ2eGF1P7MLVSGxhwKCb9sgYcEiPIQZDuDB6cHfoUG/yVEZPto1o7kv6TsIuVUGbuw5bkZ1dX/TxBgKKY3U/uUIayUMy8gkxJOtplDSpY1N54IzdXT12+KN/XgHAoeKPPKQJveNz9PAzVjV57di4fPPbSMw37nhTTuMG5+nQUBtTahMY0EfKG/Z6EdJu2312kwvMWwIBtLIYTOQrP5k8UO3QZdpURNANlJgb4Gn6TSbr+FkuitiVB5YO798btlKjEDZCadvPieLE0YFoWr+OY3P1LwPkatmKFJG5sviguSR+BD4EoovvWBVNuRUPdsGVT5YNsyZcoEkebEaIPKwlRyFOeY6dkMdbsKBDALQCvbwQC1A6TUJVj//o5ERfJd4U3x2B2IbGFygggH2VKDFO6WCSg1Fz4Tg65rO9frbKLD9TzA5Spvpgc5JPMlRo3ELR9BX8VDN6idLhViXhNN/bmWq9+sZsoMYNkCp68pdgSVbdyTiOEEcaw6ykyAp3B+4dg6rOu9w07Zd9ynMEMJI06/X4wLk8Yeh/rLVlMcteYcvZzfu6hdQs9eELZ9tcZgws0L2dd+EXHW3zdpgcX4pb1m7QH7dk5TrETTQD27AlerbgQWTEeqFBwvCt5r6kv2BFz+yuE6RG0vKjetOmlw02ifbgs+/Fqe3d41uUSaY7h6KEZDUeD88ZkEb7a5pNCFNwi12eZFtiFS+NMpezo nbdDtfXP xjb6HeBL9L8VLuYaWI1hbjsh5Y6+xsO1mFyLNG+xiYXwE/IkIo5v4JT4LKFNd5C3N9gCkCaWJdkxXYgLa5cwFyMQ29SX5nQGUvsWZEobcraMMWFS/ypALHs/YDxLbn4XcL/MXw74p2FnWo0N+YHU+Sa1dKiXZfIsuvlDOj0a9+VU+NKaG1vgCdZdD13zEeHYB67AiblibC4HJxt+ipUlXbjxIWhBuia0y5gj6yHrQe3RvchaJK2RYwz2ZMH93QtBCgAYFykbNgIo79JDYZLfGnsLwll6wjDkoU1wTJR3qAwxCi4zmGJII6DWlLe8Oz6MNivIgRsntx6oG7klgOITPZzFg7P0wtuNYbbme+8m3KQgo8AVcNrHPj2fwl4DZwq6bCblGObCMcfwmuuvFeqJ7UzrGphgu8XexD05n9O3LOSnBaWbK7F+wdv+4q9Sq9sEdk7k+6JbUhEAqxrLQXEYDoJtNfoicBYA9hBX+rYzRt5bqHYw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 10, 2024 at 4:52=E2=80=AFAM Andrew Morton wrote: > > On Wed, 9 Oct 2024 15:49:53 +0800 "zhaoyang.huang" wrote: > > > From: Zhaoyang Huang > > > > The test case of [1] leads to system hang which caused by a local > > watchdog thread starved over 20s on a 5.5GB RAM ANDROID15(v6.6) > > system. This commit solve the issue by have the reclaimer be throttled > > and increase min_seq if both page types reach MIN_NR_GENS, which may > > introduce a livelock of switching type with holding lruvec->lru_lock. > > > > [1] > > launch below script 8 times simutanously which allocates 1GB virtual > > memory and access it from user space by each thread. > > $ costmem -c1024000 -b12800 -o0 & > > > > That looks like a pretty simple testcase. Do people know where to get > `costmem' from? Sorry, I am just aware that this is an internal test tool integrated into the SDK by our folks. Here is an old version of costmem which I can share #include #include #include #include #include #include #include #include #include unsigned int block_size =3D 64; unsigned int cost_size =3D 1024 * 1024; int oom_adj =3D 15; static void usage(void) { printf("Usage:\n"); printf(" costmem [-ccost_size(KB) -bblock_size(KB) -oOom_adj(-16 to 15)]\n= "); printf(" such as: costmem -c2048 -b128 -o15\n"); } void process_options(int argc, char **argv) { int opt =3D 0; while ((opt =3D getopt (argc, argv, "c:b:o:")) !=3D -1) { switch (opt) { case 'c': cost_size =3D (unsigned int)atoi(optarg); break; case 'b': block_size =3D (unsigned int)atoi(optarg); break; case 'o': oom_adj =3D atoi(optarg); break; default: break; } } } int main(int argc, char *argv[]) { int i, max; char *memory; size_t j; size_t page_size; int rval =3D -EINVAL; char text[128] =3D {0}; int fd; pid_t pid =3D getpid(); if (argc < 2) { usage(); return rval; } else if (argc =3D=3D 2) { if (strstr(argv[1], "help")) usage(); return rval; } process_options(argc, argv); if (oom_adj < -16 || oom_adj > 15) { printf("Oom_adj must between -16 to 15\n"); return rval; } sprintf(text, "/proc/%d/oom_adj", pid); fd =3D open(text, O_WRONLY); if (-1 =3D=3D fd) { perror("open"); return rval; } else { sprintf(text, "%d", oom_adj); if (write(fd, text, strlen(text)) =3D=3D -1) perror("write"); close(fd); } printf("Cost mem %d KB, %d KB per Block, oom_adj %d\n", cost_size, block_size, oom_adj); max =3D cost_size / block_size; for(i =3D 1; i < max + 1; i++) { memory =3D malloc(block_size * 1024); if(NULL =3D=3D memory){ perror("malloc"); return rval; } if(mlock(memory, block_size * 1024) =3D=3D -1) { perror("mlock"); return rval; } memset(memory, 0, block_size * 1024); printf("%dKB,", (int)(block_size * i)); if(9 =3D=3D i % 10) printf("\n"); } printf("Have malloc and mlock %d KB mem\n", block_size * i); printf("Have malloc and mlock %d KB mem\n", block_size * i); printf("Have malloc and mlock %d KB mem\n", block_size * i); i =3D 0; while(1){ sleep(20); i++; printf("."); if(9 =3D=3D i % 10) printf("Please Ctrl+c to kill this APP\n"); } return 0; } > > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > This is a somewhat serious issue, so I'll add the patch for some > testing, but I'll await feedback from MGLRU developers before > proceeeding further, thanks. IMHO, MGLRU is now lack of the mechanism of 'too_many_isolated' thing, should we do it in this way or others? >