From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8598C47DDB for ; Thu, 1 Feb 2024 04:05:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA63B6B0075; Wed, 31 Jan 2024 23:05:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D55676B0082; Wed, 31 Jan 2024 23:05:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1CB96B0083; Wed, 31 Jan 2024 23:05:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ABCEB6B0075 for ; Wed, 31 Jan 2024 23:05:40 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D8D25A1A0A for ; Thu, 1 Feb 2024 04:05:38 +0000 (UTC) X-FDA: 81741895956.16.955B6A8 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf20.hostedemail.com (Postfix) with ESMTP id 0E7711C0021 for ; Thu, 1 Feb 2024 04:05:36 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=j2OAzymp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706760337; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rVtZzGrAZ7Rvq/x504vQLLiqx/E0QPJtNjyDBer37qU=; b=kDPhsGIpBkNUoVn5Kv5vNIYA8guk4DZWMNAkqexF+lYYSmfI+v6JVr/Hqs/8f/zGsPzW6R wqNfRxV8il0lb5B+PugsF6JyLmKbTzz8+kxQOiBUEg1IbRYY7VNmQfLxDQYj3l3zOpUqek 23JumWzR58leW/KGuyuAGcAj2CzRgco= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=j2OAzymp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706760337; a=rsa-sha256; cv=none; b=VcaZ5dBRhw2hfMQJE6WAuvHZ3Pt50MiQ/JG8oKoRGahYKLAtT4UjFtOT/xDl7Yn6+TMlc5 eIX4YO7zDdMaEHbAyXTE09XzeMzGFoAdQfBZ+Jo+M/fzf9QyvHe+7Mkqa79GhpkBmKHvwB qXUAcE//pp0gejWsWj3b4FOtLDrRDTw= Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5112cb6d1e7so513628e87.0 for ; Wed, 31 Jan 2024 20:05:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706760335; x=1707365135; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rVtZzGrAZ7Rvq/x504vQLLiqx/E0QPJtNjyDBer37qU=; b=j2OAzympgYSbVaN/1b+JcAuhaAt3jee3WZHLpQ6E8F4dftX9iJPGSMBW3Z/2cafuXl /P63FQWUJ9L8ltI0pchbzae8B1pswoAAy/OzSshQMu0oXschPUKyrot4ZZDSt6S8Bfb3 B/fZxmumtTFYDM8KtMVblUa8KXgICCYb15HZQUz+wXfHkWBAaKD+rBWeDmcvdznwb4v+ lSCivd+8S6QnkzVC8wgiBvojAvLDBtCgidrPlArRyUMQuhMJmqe5Gq67ZclM2xsfnL+e Al7UPz3vLYEEVFeCvo6AkdtBJdVzNiK+m0cPk5yoZQctYrYmiKU+ZZi9OnTKKnhoHsC9 oq+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706760335; x=1707365135; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rVtZzGrAZ7Rvq/x504vQLLiqx/E0QPJtNjyDBer37qU=; b=f1b1HKh00GTIALQCWcKJAac4cVF18/kmdUKsGSRSqol0YK5zydsZtMqGpRPyfwOuI7 zlPHBzlfF9FsO0WN1p7FoUgAEFBkDFyY4l6vVwGDg7n9qS8EOv3z3WXrKqSQProcKkQr 5C4oYxKV5OGBOtAthTCB04ORUJC6jnBNnxcU9wfJNtKo5C/UXJhDncoKfAQH1enHO2XF diBTwue5nxXf1DGQs5IisHavB/TRKQMOjmU1Vi6zxt8iVNTMAF4BrcTyWQ0uHaXefYnI MJ2L+sRITMMjJ6T7UlORHKHTLt312zQ9sfDXhOrfaNj22AjBN4vbzCTdS0GWCqKAgJhT RqOQ== X-Gm-Message-State: AOJu0YxJUlRd8wdOHQ4lhz5hyM0ypw+W/L4AOJ9ni2tnE+lVSlzfK0zQ x2oqBIc0yhO240OowvOyWUjoxXFBs3zZm9Z5GpF9kUCBbql+y/b7Re8z6ki+Yt17p+ycrez1WHS sTmfI02jJIG7ca0P00gdzg86Hxf4= X-Google-Smtp-Source: AGHT+IHpnc3L5drGX+KAL4BK4m0LBZFIPEWSaWzqj8aEDtJJKuyCfdXo2Mh+7dQM3JkU4FRcmq161BRCmppHxt3f2KY= X-Received: by 2002:ac2:4550:0:b0:50e:d1f9:ebe0 with SMTP id j16-20020ac24550000000b0050ed1f9ebe0mr1110331lfm.2.1706760334966; Wed, 31 Jan 2024 20:05:34 -0800 (PST) MIME-Version: 1.0 References: <20240131105912.3849767-1-zhaoyang.huang@unisoc.com> In-Reply-To: From: Zhaoyang Huang Date: Thu, 1 Feb 2024 12:05:23 +0800 Message-ID: Subject: Re: [PATCHv6 1/1] block: introduce content activity based ioprio To: Matthew Wilcox Cc: "zhaoyang.huang" , Andrew Morton , Jens Axboe , Yu Zhao , Damien Le Moal , Niklas Cassel , "Martin K . Petersen" , Hannes Reinecke , Linus Walleij , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, steve.kang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 0E7711C0021 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: adtxzomg9uhmb8boeaxzdtn97igkfqpk X-HE-Tag: 1706760336-245926 X-HE-Meta: U2FsdGVkX18x3wDxqUIGBzSLycS2MSe/+ICCsFQ8aNUsn0Yj4FYkheYkBVOuxg6XLgKeeN7NWUV1H17RheY0vfOVvaErkarFQ4+lqpwbCmhwtOR5uwfNuz2SoFPROwuPvqZuHTIdxnh81BrK+K/swNWL9qZwm8JlCpYlayq4SQta0c7PEUXaRetNyBn4D0gQcQv5eavmCg0rOp4HN6/5qFuIjmEbA27ZpN2zZH90WzouoMjc5MwTgUsXeO/g4aJMzkNj5rPvLu97vWwvuxIVLGPiY0ete8cFcl1cAlOwR78+saqdKe8yfRoOXf3rjMkoYAMXZjPcCBRnP8D+EH34oz2eUsus+SLuVKS6JRqdTtPP+gqjOQWeSRaUre36ERzOCCuvt7Vp1eezW+EGox+jkkLnF4+5c41phT7j9Ye91y8LG/UhJKMzotj+p+puPjWqm5ZN8mZInRKVpFfSQ6alxB+I7JrdH3IP/Gvp4dSXa8X4lb0FUANNpF6qxqrOT3VJeG8aN6d4gztrZ3v4EAMba16QpXNzmcsQOXSj8M88ki3v3hHrtylCl5Wyr3hleXRfkepreFWsIk+AIBDf3M76xs/BnKmqW6rKOPfo8HpCd7GJRJg+eWytJtlNrF31q7ce1zmvJgsSPRl9f8ZrI2TZaeDyNG1z7si9HpsbxoswIdg+Jwc6fEn9ytRQgjA7o0rGr2DCnkmNHmwirM9XP4A7dhEVq+wrkn4O5Oj7RsmciFjYvjqrJbg2GNAmDqPA+Vg+72SoG69eyT3sdWElKSyR75rpqL3SE78ckm2xR9sehgpjhIafZj8BqSNirBqeZX6+OlNpDA/bkSshV5EZdGxd9d1pz1XFyGWczHPuewK4xbWitgEqYVzhqmddYslL7O9/3+2O8iSP1EZm/MyQ2lb540Gew94TUwJ7v8KqaqRy0QlM8h05A6Aaxp02SQkkiSLRY31lgueW9keeiwiQICh Mqu8wdz3 ldf6gVi/tySJOItdG1gPpQmnBz+mJ9piKTxl9p5ZFJUK4lzN3jFweIJGoTTY08YIzCly/ryG/g5yT85on5pWO+lr4miruw9fIFAxGmTka9OEkS5KyAGIlGBR28Q5lt/S1oRSwHBayfhSZF7QHqb0yGLf1bapVNKTTqubCiA+PwjinVdRlWKbcwBirtF0bgoguIL0qCqkfkjOs+MTd7cSdbv4pQhNIy3hiHT6wWJuMCV3ly+sI8xdt213+IOILTJ718C3KQPBOwP8itMchgGj0rhoCeCwQ6WL9sGgGHq5U2WncpAj3vhTF22wKZmJ/6FYfYndLIXUxIxVfvrs4bhJEAcp7dtERd3/+gnFPux8FG+rPQ0OToGOt1xxS/3F9wQiBpw7ED7zCbNdNox+sS2oEgYv2zMTxnFFqqwF/BIpMeGLBxCX5J08KgSWwhQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 1, 2024 at 10:39=E2=80=AFAM Zhaoyang Huang wrote: > > On Wed, Jan 31, 2024 at 9:23=E2=80=AFPM Matthew Wilcox wrote: > > > > On Wed, Jan 31, 2024 at 06:59:12PM +0800, zhaoyang.huang wrote: > > > change of v6: replace the macro of bio_add_xxx by submit_bio which > > > iterating the bio_vec before launching bio to block lay= er > > > > Still wrong. > I did some research on bio operations in the system and state my > understanding here. I would like to have you review it and give me > more details of the fault. thanks > > 1. REQ_OP_ZONE_xxx > a. These operations are from driver/block layer/fs where we can keep > driver/block layer using the legacy submit_bio by not including > act_prio.h. > b. most of fs's REQ_OP_ZONE_xxx will be handled by blkdev_zone_mgmt > which is the same as 'a' > c. __submit_zone_reset_cmd within f2fs use no page for REQ_OP_ZONE_RESET > > 2. other REQ_OP__READ/WRITE except REQ_OP_ZONE_xxx > These operations all comes from driver and block layer as same as 1.a > > 3. direct_io > keep fs/direct-io.c and fs/iomap/direct-io.c using legacy submit_bio > > 4. metadata, dentry > Are these data also file pages? > > 5. normal REQ_OP_READ/WRITE/SYNC > fs choose to use act based submit_bio by including act_ioprio.h in > corresponding c file OR could I restrict the change by judging bio_op as below + if (bio_op(bio) =3D=3D REQ_OP_READ || bio_op(bio) =3D=3D REQ_OP_WRITE) + { class =3D IOPRIO_PRIO_CLASS(bio->bi_ioprio); level =3D IOPRIO_PRIO_LEVEL(bio->bi_ioprio); hint =3D IOPRIO_PRIO_HINT(bio->bi_ioprio); bio_for_each_bvec(bv, bio, iter) { page =3D bv.bv_page; activity +=3D PageWorkingset(page) ? 1 : 0; cnt++; } if (activity >=3D cnt / 2) class =3D IOPRIO_CLASS_RT; else if (activity >=3D cnt / 4) class =3D max(IOPRIO_PRIO_CLASS(get_current_ioprio()), IOPRIO_CLASS_BE); bio->bi_ioprio =3D IOPRIO_PRIO_VALUE_HINT(class, level, hint); + } submit_bio(bio);